Skip to content

feat(reports): leftover-map singular values on leftover-axis badges (v2.47.0) - #823

Open
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-singular-v2460from
feat/leftover-map-axis-singular-v2470
Open

feat(reports): leftover-map singular values on leftover-axis badges (v2.47.0)#823
seonghobae wants to merge 1 commit into
feat/leftover-map-plot-singular-v2460from
feat/leftover-map-axis-singular-v2470

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Caption leftover-axis report badges with persisted leftover-map singular values σ_k (ADR 0290 / v2.47.0).
  • After make seed, leftover-axis badges name persisted leftover-map singular values when finite together with persisted leftover-map axis share; leftover-map graphic axes name those same singular values; click a leftover pair opens that post.
  • A missing, non-finite, or negative singular value omits that σ badge and keeps leftover axis {k} {share}%. Rank-0 unused axes still name σ 0.00. Pair-list leftover-axis badges stay distinct from leftover-map graphic axis captions (leftover axis {k} σ {value} {share}% vs leftover-map axis {k} σ {value} ({share}%)). Do not invent σ_k from leftover-map axis share.
  • UI-only; no SQL; no new columns. Never invent a leftover score. Never invent a theta. Do not persist leftover-map inner product, cosine, or length. Grouping comparison strip does not gain this caption.
  • Stacked onto leftover-map singular values on graphic axes (feat/leftover-map-plot-singular-v2460 / feat(reports): leftover-map singular values on graphic axes (v2.46.0) #820 @ b7222713). Leave this PR open for independent review. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / feat(reports): persist leftover-map coordinates (v2.24.0) #782) rather than squash-merging here.

Verification

  • frontend oxlint: 0 warnings, 0 errors on 7 files.
  • frontend vitest: 329 passed (App.test.tsx, LeftoverMapPlot.test.tsx, LeftoverPairList.test.tsx, i18n.test.ts, leftoverMapPlotAxisSingular.test.ts, leftoverMapAxisBadge.test.ts).
  • tests/test_leftover_pairs.py and PostgreSQL period-report tests were not executed here (UI-only; no schema change).

Evidence boundary

Authenticated PostgreSQL API and k6 runtime acceptance are not claimed. No real records or credentials. Synthetic fixtures only.

Independent approval is required. No self-approval, admin bypass, or force push.

Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.

Gabriel, K. R. (1971). The biplot graphic display of matrices with application to principal component analysis. Biometrika, 58(3), 453–467.


Devin Review

…v2.47.0)

Caption leftover-axis report badges with persisted leftover-map singular
values σ_k when finite and non-negative (ADR 0290). Pair-list leftover-axis
badges stay distinct from leftover-map graphic axis captions. Do not invent
σ_k from leftover-map axis share. UI-only; no SQL; no new columns. Never
invent a leftover score. Never invent a theta.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 38d312d5-eace-4231-8213-2d76fd71ede8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Write-retry this cycle (seonghobae gh). #823 is leftover-map v2.47 leftover-axis badge singular values at eb172c40 (ADR 0290), stacked on #820. Do not squash-merge onto an unprotected leftover base. Do not self-approve. Independent APPROVE still required. Copilot/Devin COMMENT is not independent APPROVE. Do not merge #808 without independent APPROVE. Issues #79 and #87 stay open. Grouping comparison strip (ADR 0149) does not gain leftover-map captions.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment on lines +13 to +17
export function leftoverMapAxisBadgeShare(
leftoverShare: LeftoverMapAxis["leftover_share"] | null | undefined,
): string {
return ((leftoverShare ?? Number.NaN) * 100).toFixed(0);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Malformed shares remain contract-excluded

leftoverMapAxisBadgeShare can render NaN%, matching the previous formatter. Database constraints and backend serialization exclude such values from this API.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +19 to +27
export function leftoverMapAxisBadgeSingular(
axis: Pick<LeftoverMapAxis, "axis_index"> & {
leftover_singular_value?: LeftoverMapAxis["leftover_singular_value"] | null;
},
): string | null {
return formatLeftoverMapPlotAxisSingular(
leftoverSingularForAxis([axis], axis.axis_index),
);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Badge validation matches plot validation

leftoverMapAxisBadgeSingular reuses the plot helpers. Invalid values remain hidden, while rank-zero values render as 0.00.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor Author

Write-retry this cycle (seonghobae gh). #823 leftover-axis badge σ_k (v2.47.0 / ADR 0290) stays open at eb172c40 on #820. Do not squash-merge onto an unprotected leftover base. Do not self-approve. Independent APPROVE still required. Copilot/Devin COMMENT is not independent APPROVE. Do not merge #808 without independent APPROVE. Issues #79 and #87 stay open. Next buyer increment on the coverage stack: leftover-map incomplete post coverage on the grouping comparison strip (explicitly deferred by #822).

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-30T14:20Z: still waiting on independent APPROVE of exact head eb172c40 (leftover-axis σ_k badges, ADR 0290 / v2.47.0). Copilot/Devin COMMENT is not independent APPROVE. Do not self-approve. Do not squash-merge this leftover stack onto unprotected leftover base. Next buyer gap on this stack after independent APPROVE is leftover-map incomplete item coverage on the grouping comparison strip (or the next deferred graphic/list increment). #79 and #87 stay open.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-30T14:24Z: write probe (comment). Independent APPROVE still required. Do not self-approve. Stack continues leftover-map singular values after v2.47.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant