feat(reports): leftover-map cross share on pair segments (v2.32.0) - #804
Conversation
Caption leftover-map graphic-display pair segments with persisted leftover-map cross share x = 2 R̂ U / R² (ADR 0275). After make seed, closest and farthest leftover pairs sit above the member list with the Gabriel biplot of already-named coordinates, leftover-map axis share when finite, axis ticks that match ξ (x, y) ζ (x, y) on the pair row, pair segments that match d on the pair row, pair segments that match R̂ on the pair row, pair segments that match R̂²/R² on the pair row, pair segments that match U²/R² on the pair row, and pair segments that match 2R̂U/R² on the pair row; click a post marker or a pair button opens that post. A missing or non-finite x omits that leftover-map cross share caption. A finite negative share is shown; do not clamp to nonnegative. Do not invent x from R̂, U, and R or from plotted coordinates. Never invent a leftover score or a theta. No new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-29: leftover-map cross share |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const crossShareY = leftoverMapStackedCaptionY( | ||
| labelPosition.labelY, | ||
| (distanceLabel !== null ? 1 : 0) + | ||
| (reconstructionLabel !== null ? 1 : 0) + | ||
| (explainedShareLabel !== null ? 1 : 0) + | ||
| (unexplainedShareLabel !== null ? 1 : 0), | ||
| ); |
There was a problem hiding this comment.
🟡 Cross-share captions leave the plot
crossShareY places a fully populated segment’s fifth caption beyond the fixed SVG when its midpoint is near the lower edge. The value becomes clipped or overlaps content below.
Prompt for agents
The new cross-share caption adds a fourth 12-pixel downward offset from a segment midpoint, but layoutLeftoverMapPlot keeps a fixed 320-pixel viewBox and only 40 pixels of bottom padding. A segment whose endpoints lie near the lower data boundary has a midpoint near y=280, placing the cross-share baseline near y=328. Adjust segment-caption placement or plot bounds so every available caption remains inside the SVG. Account for the actual number of finite captions and both top and bottom edges; options include choosing the stack direction per segment, reserving dynamic caption space, or expanding the viewBox. Add a layout and rendered-component test with a fully populated segment near the lower edge.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Verified-successor carryover: #811 exact head e626a1d0770208d6f821e06542091aa2ead87f25 contains this exact head as its merge base and is 5 commits ahead / 0 behind. The immutable successor therefore preserves the complete cross-share implementation, ADR 0275, changelog/docs, i18n/layout/component source and executable tests/fixtures plus all later segment-caption deltas. #811 is Draft and its live-#802 conflict remains a repair finding; no historical checks/reviews are transferred. Closing #804 is valid only because the product/test/document delta is completely carried by #811.
1 participant
Superseded by verified full carryover in #811
Closed without merge only under the verified-successor exception. Exact head
c513002bea9e0ee3e6ccd0931c5256e52dbbd878is the immutable merge base of open successor #811 heade626a1d0770208d6f821e06542091aa2ead87f25; fresh compare is ahead by 5 / behind by 0.#811 preserves this PR's complete cross-share implementation, ADR 0275, changelog/docs, i18n/layout/component source and executable tests/fixtures together with every later segment-caption delta. #811 is intentionally Draft and currently conflicts with the live #802 foundation after that parent advanced; that is an active repair finding, not a lost delta.
Review
5120256041records the carryover. Historical checks/reviews do not transfer. No force-push, squash, destructive rebase, gate weakening, or source deletion was used.