feat(ontology): expand source-post Voice-of-X taxonomy (ADR 0246) - #713
Conversation
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
seonghobae
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Expand voc_type from five to twelve post types (Supplier, Employee, Business, Regulator, Investor, Society, Process added) grounded in stakeholder identification theory and quality-engineering practice, and mirror six new counterparty relationship codes so any post class can type each named organization. Ontology SKOS concepts/object properties, idempotent migration 0222, classifier vocabulary + prompt, round-trip and parser tests stay in sync.
850494c to
203d425
Compare
| - Evidence-bound occupational construct semantics now keep cognitive | ||
| abilities, work styles, work activities, affective reactions, performance | ||
| behaviors, and FJA worker functions distinct. Record-to-construct links | ||
| require a reified evidence span and PROV-O derivation/time; unsupported | ||
| DPT-to-psychology crosswalks and local scores remain unavailable (ADR 0248). | ||
| - Versioned occupational construct vocabularies and semantic-unit assertions | ||
| now persist in normalized tables. Database and application validation require | ||
| same-Post verbatim evidence, and authorized Post detail exposes provenance | ||
| without internal identifiers or numerical scores (ADR 0249). | ||
| - An operator-only O*NET 31.0 catalog synchronizer now imports every official | ||
| cognitive-ability, work-style, and work-activity Content Model element with | ||
| stable IRIs, descriptions, attribution, and a deterministic source digest; | ||
| conflicting release metadata fails closed (ADR 0250). | ||
| - Post-content ingestion now traverses bounded official O*NET hierarchy nodes | ||
| through contextual-orchestrator's multi-agent conduct workflow and persists | ||
| only exact catalog IRIs with verbatim semantic-unit evidence. A digest-bound | ||
| run ledger preserves successful empty extraction without inventing a signal | ||
| (ADR 0253). | ||
| - Authorized Post detail now shows O*NET work evidence with its verbatim source | ||
| span, explicit inference status, and official definition action. Complete | ||
| empty, processing, and unavailable states stay distinct and localized rather | ||
| than collapsing into a blank panel. Historical cutoff reads omit live | ||
| assertions and direct the reviewer to the cutoff-known body (ADR 0254). | ||
| - Assertion-backed occupational constructs now appear in the authorized | ||
| ontology neighborhood with persisted truth status, cutoff-safe availability, | ||
| exact Post evidence, and fail-closed conflicting truth. The projection | ||
| duplicates no `knowledge_graph_edge` row and creates no person trait or score | ||
| (ADR 0255). | ||
|
|
||
| - The DOT/FJA Data/People/Things worker-function taxonomy is now published | ||
| in the canonical ontology: all 24 worker functions carry the official | ||
| Dictionary of Occupational Titles Appendix B definitions verbatim, their | ||
| definitional ordinal ranks (ADR 0232). No DOT-to-O*NET or Fleishman | ||
| crosswalk is inferred without an authoritative mapping source. A | ||
| deterministic application read | ||
| model (`lineageweave.worker_function_taxonomy`) exposes fail-closed | ||
| lookups; ranks are scale positions and are never used as weights. |
There was a problem hiding this comment.
🟡 Changelog drops entries for features still in the tree
This edit deletes the changelog entries for the occupational-construct (ADRs 0248-0255) and DOT/FJA worker-function work, yet worker_function_taxonomy and migrations 0238-0241 remain in the tree. The changelog no longer documents these present, unreleased features.
Prompt for agents
The CHANGELOG 'Added' section in this PR removes the entries describing the occupational-construct features (ADRs 0248, 0249, 0250, 0253, 0254, 0255) and the DOT/FJA worker-function taxonomy (ADR 0232). These entries existed in the merge-base and the underlying features are still present in the head branch (migrations/0238_*.sql through 0241_*.sql, lineageweave/worker_function_taxonomy.py, and docs/adr/0232-worker-function-taxonomy-in-the-published-ontology.md). This appears to be an accidental loss during a rebase where the branch's older Unreleased/Added block overwrote the newer entries. Restore the removed changelog entries alongside the new Voice-of-X entry so the changelog stays synchronized with the features actually present in the tree.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
|
||
| # edge_team_affiliation/edge_mention_organization), 0042 (ADR 0207: | ||
| # the original five voc_type post-type codes) + 0235 (ADR 0246: the | ||
| # seven further Voice-of-X post-type codes), and | ||
| # 0220 (ADR 0222: node_project/edge_mention_project). |
There was a problem hiding this comment.
📝 Info: Migration-list comment no longer mentions 0241
The reformatted comment above _ADDITIONAL_LOOKUP_MIGRATION_PATHS stops at 0220 and drops the 0241 description, but the 0241 path is still in the tuple. Comment-only drift; the list itself is correct.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
Expands the governed source-post Voice-of-X vocabulary from five to twelve
codes under ADR 0246.
as SKOS concepts and replay-safe lookup values.
relationship is inferred from a post's voice.
exhaustive standard taxonomy or an exact literature crosswalk.
exposing implementation boundaries in customer copy.
Verification
pytestontology, entity-relationship, shapes, publication, documentation,and docstring suites: 69 passed, 1 skipped.
Exact-head hosted checks and independent current-head review remain
authoritative.