Repository navigation
feat: name leftover-map reconstruction on leftover pairs (v2.12.31) #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
74ed95d
feat: name leftover-map reconstruction on leftover pairs (v2.12.31)
seonghobae 940519a
Merge remote-tracking branch 'origin/main' into codex/pr588-repair
seonghobae 2f5e197
fix(adr): allocate reconstruction decision 0201
seonghobae dc60a08
Merge remote-tracking branch 'origin/main' into codex/pr588-repair
seonghobae 91d8e4f
Merge remote-tracking branch 'origin/main' into codex/pr588-repair
seonghobae 3a67a80
fix: restore R̂-persistence docs and finish ADR 0183→0201 renumbering
seonghobae e4234bc
docs: reconcile ADR 0182 reconstruction context
seonghobae 1475106
merge: reconcile raw residual reconstruction with current main
seonghobae 26c549d
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae a390d23
test(leftover): cover reconstruction candidate contract
seonghobae d3daf87
Merge remote-tracking branch 'origin/feat/leftover-map-reconstruction…
seonghobae 6185f2a
fix(leftover): prove rank-zero reconstruction identity
seonghobae e9b29f1
Merge remote-tracking branch 'origin/main' into HEAD
seonghobae c33e777
Merge branch 'main' into feat/leftover-map-reconstruction-v21231
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| ## 2.12.31 — Leftover-map reconstruction | ||
|
|
||
| - Persist leftover-map reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}` on leftover | ||
| post–criterion pairs (ADR 0183). After `make seed`, closest and farthest | ||
| leftover pairs sit above the member list with `R̂` next to leftover-map | ||
| distance `d`; click opens that post. Omit the badge when reconstruction | ||
| is missing. Never invent a leftover score. Signed reconstruction is | ||
| stored, never clamped. Identity `U + R̂ = R` stays auditable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seonghobae marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seonghobae marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # ADR 0183 — Name leftover-map reconstruction on period-report pair rows | ||
|
|
||
| **Decision status:** Accepted | ||
| **Date:** 2026-08-25 | ||
|
|
||
| Amends [ADR 0048](0048-persist-lsirm-leftover-pairs.md), | ||
| [ADR 0049](0049-leftover-pair-report-ui.md), and | ||
| [ADR 0182](0182-leftover-map-unexplained.md). Independent of landed | ||
| complete-case coverage ([ADR 0168](0168-leftover-map-complete-case-coverage.md)). | ||
|
|
||
| ## Context | ||
|
|
||
| ADR 0182 already persists unexplained leftover `U = R − R̂` after | ||
| two-axis Gabriel reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}`. That | ||
| reconstruction is computed internally so `U` is honest, then discarded. | ||
| A buyer who reads `U` next to leftover residual `R` cannot check | ||
| `U + R̂ = R` without the reconstruction the two-axis map actually | ||
| uses. Hiding `R̂` lets leftover residual `R` or leftover-map distance | ||
| `d` be read as the leftover the map reconstructs. | ||
|
|
||
| This increment persists leftover-map reconstruction `R̂`. It does not | ||
| persist leftover-map coordinates, does not name leftover-map inner | ||
| product as a separate full-rank column, does not name leftover-map | ||
| cosine, does not name leftover-map length, does not name leftover-map | ||
| explained share, unexplained share, or cross share, and does not land | ||
| Post quality on the leftover criterion. Leftover-map distance stays | ||
| two-axis Euclidean. Reconstruction is the same internal two-axis inner | ||
| product already used for `U`, so `U + R̂ = R` remains true. Do not | ||
| substitute a separately centered reconstruction `R̃` that would break | ||
| that identity. | ||
|
|
||
| The unprotected-stack reconstructions for neighbouring leftover facts | ||
| use 0162–0181 and 0184–0186. This protected-main increment uses | ||
| **0183** so it does not collide with leftover-map unexplained leftover | ||
| (0182), leftover-map reconstruction on the centered stack (0186), | ||
| leftover-map unexplained share (0184 on that stack), leftover-map | ||
| explained share, leftover-map cross share, leftover residual | ||
| disclosure, leftover observed `Y` / expected `E`, leftover-map rank, | ||
| two-axis leftover-map distance, leftover coverage, leftover-map axis | ||
| share (0148), or leftover interaction-map persistence. | ||
|
|
||
| ## Decision | ||
|
|
||
| Each leftover pair names `leftover_map_reconstruction` — two-axis | ||
| Gabriel reconstruction `R̂ = ξ_{1:2} · ζ_{1:2}`. Unused axes pad with | ||
| zero. Hidden SVD axes after the second are dropped. Migration `0183` | ||
| is the single source of the column on every install path, fresh or | ||
| existing -- shipped migrations (`0001` / `0012`) are never edited after | ||
| the fact. The column is nullable so older leftover rows keep distance, | ||
| residual, and unexplained leftover without fabricating reconstruction. | ||
| Fallback pairs that have no complete-case leftover map omit the value | ||
| rather than inventing one. A rank-0 origin map stores `0.0` (`R = 0` | ||
| and `R̂ = 0`), not a missing value. A non-finite reconstruction stores | ||
| null rather than inventing a leftover score. A signed reconstruction | ||
| is stored, never clamped. Do not add a nonnegative CHECK. | ||
|
|
||
| The pair button shows `R̂ {signed}` next to leftover-map distance `d` | ||
| when the value is finite. Next action: leftover map reconstructs `R̂` | ||
| after IRT main effects; open this post to read the named criterion. | ||
| A missing or non-finite reconstruction omits the badge and keeps the | ||
| existing unexplained-leftover next action. Do not invent a leftover | ||
| score. Do not invent a theta. | ||
|
|
||
| ## Consequences | ||
|
|
||
| `GET /api/reports/{grouping}/{period}` returns | ||
| `leftover_map_reconstruction`. After `make seed`, closest and farthest | ||
| leftover pairs sit above the member list with named `R̂` next to `d`; | ||
| click opens that post. Hidden posts stay hidden. When both | ||
| reconstruction and unexplained leftover are finite, | ||
| `U + R̂ = R`. | ||
|
|
||
| ## Related | ||
|
|
||
| Independent of leftover interaction-map persistence, leftover-criterion | ||
| evaluation landing, leftover residual disclosure, leftover observed | ||
| `Y` / expected `E`, leftover-map complete-case coverage, leftover-map | ||
| axis share, leftover pairs on the grouping comparison strip, two-axis | ||
| leftover-map distance, leftover-map rank, leftover-map inner product, | ||
| leftover-map cosine, leftover-map length, leftover-map unexplained | ||
| share, leftover-map explained share, leftover-map cross share, and | ||
| the centered leftover-map reconstruction stack. | ||
|
|
||
| ## References | ||
|
|
||
| Gabriel, K. R. (1971). The biplot graphic display of matrices with | ||
| application to principal component analysis. *Biometrika, 58*(3), | ||
| 453–467. https://doi.org/10.1093/biomet/58.3.453 | ||
|
|
||
| Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping | ||
| unobserved item–respondent interactions: A latent space item response | ||
| model with interaction map. *Psychometrika, 86*(2), 378–403. | ||
| https://doi.org/10.1007/s11336-021-09762-5 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.