-
Notifications
You must be signed in to change notification settings - Fork 1
feat: name leftover-map reconstruction on leftover pairs (v2.12.31) #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
74ed95d
940519a
2f5e197
dc60a08
91d8e4f
3a67a80
e4234bc
1475106
26c549d
a390d23
d3daf87
6185f2a
e9b29f1
c33e777
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ## 2.12.31 — Leftover-map reconstruction | ||
|
|
||
| - Period leftover pairs now expose reconstruction evidence governed by ADR | ||
| 0201. After `make seed`, open a closest or farthest pair to inspect it on | ||
| the named post. Missing reconstruction omits the badge. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -445,8 +445,9 @@ async def persist_period_report( | |
| grouping_kind, grouping_key, period_code, rubric_version, | ||
| pair_kind, post_id, criterion_code, leftover_distance, leftover_residual, | ||
| observed_response, expected_response, leftover_map_rank, | ||
| leftover_map_unexplained, leftover_map_cross_share | ||
| ) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14) | ||
| leftover_map_unexplained, leftover_map_cross_share, | ||
| leftover_map_reconstruction | ||
| ) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15) | ||
| """, | ||
| grouping_kind, | ||
| grouping_key, | ||
|
|
@@ -462,6 +463,7 @@ async def persist_period_report( | |
| pair.leftover_map_rank, | ||
| pair.leftover_map_unexplained, | ||
| pair.leftover_map_cross_share, | ||
| pair.leftover_map_reconstruction, | ||
| ) | ||
| for axis in report.leftover_map_axes: | ||
| await conn.execute( | ||
|
|
@@ -647,7 +649,8 @@ async def fetch_period_reports( | |
| select lp.grouping_key, lp.pair_kind, lp.post_id, lp.criterion_code, | ||
| lp.leftover_distance, lp.leftover_residual, | ||
| lp.observed_response, lp.expected_response, lp.leftover_map_rank, | ||
| lp.leftover_map_unexplained, lp.leftover_map_cross_share, p.post_title, | ||
| lp.leftover_map_unexplained, lp.leftover_map_cross_share, | ||
| lp.leftover_map_reconstruction, p.post_title, | ||
| p.visibility_code, p.corporate_entity_id, | ||
| ({_SOURCE_CONTEXT_PRESENT_SQL}) as has_real_source_context | ||
| from report_leftover_pair lp | ||
|
|
@@ -796,6 +799,11 @@ async def fetch_period_reports( | |
| if row["leftover_map_cross_share"] is None | ||
| else float(row["leftover_map_cross_share"]) | ||
| ), | ||
| "leftover_map_reconstruction": ( | ||
| None | ||
| if row["leftover_map_reconstruction"] is None | ||
| else float(row["leftover_map_reconstruction"]) | ||
| ), | ||
| "visibility_code": row["visibility_code"], | ||
| "corporate_entity_id": str(row["corporate_entity_id"]), | ||
| "has_real_source_context": bool(row["has_real_source_context"]), | ||
|
|
@@ -989,6 +997,7 @@ async def fetch_period_comparison( | |
| f""" | ||
| select lp.grouping_kind, lp.grouping_key, lp.pair_kind, lp.post_id, | ||
| lp.criterion_code, lp.leftover_distance, lp.leftover_residual, | ||
| lp.leftover_map_reconstruction, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: Comparison strip does not use the reconstruction next-action
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| p.post_title, p.visibility_code, p.corporate_entity_id, | ||
| ({_SOURCE_CONTEXT_PRESENT_SQL}) as has_real_source_context | ||
| from report_leftover_pair lp | ||
|
|
@@ -1033,6 +1042,11 @@ async def fetch_period_comparison( | |
| "criterion_code": str(pair["criterion_code"]), | ||
| "leftover_distance": float(pair["leftover_distance"]), | ||
| "leftover_residual": float(pair["leftover_residual"]), | ||
| "leftover_map_reconstruction": ( | ||
| None | ||
| if pair["leftover_map_reconstruction"] is None | ||
| else float(pair["leftover_map_reconstruction"]) | ||
| ), | ||
| "visibility_code": pair["visibility_code"], | ||
| "corporate_entity_id": str(pair["corporate_entity_id"]), | ||
| "has_real_source_context": bool(pair["has_real_source_context"]), | ||
|
|
||
|
seonghobae marked this conversation as resolved.
|
Uh oh!
There was an error while loading. Please reload this page.