docs(doctoring): verify loop-brief items 4, 15-18, 38, 39 already resolved - #1758
Merged
seonghobae merged 7 commits intoSep 3, 2026
Merged
Conversation
org-queue-sweep can't be replaced by plain Actions syntax (no native org-wide PR sweep primitive) and its rate-limit symptom traces to the plan-level 60-job ceiling, not the job's own design; the governance-risk- compliance caller cited in item 16 was already consolidated (#1673) and its hardcode fixed (#1743); item 17's org-wide dedup audit already ran (#1731); and no script or workflow in this repo assumes a fixed installation-token length/prefix, so the incoming ghs_ format change (item 18) needs no change here. Records the evidence so these aren't re-investigated from scratch.
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Distinguish the plan-level 60-job Actions ceiling from the separate, already-documented NVIDIA NIM LLM-provider rate limit instead of collapsing both into one cause. - Broaden the item-18 token-format search from scripts/ci/*.py and .github/workflows/*.yml to every .py/.sh under scripts/ci/ and .github/ (including the one composite action) plus a whole-repo double-check. - Drop backtick-wrapped `.github#N` references, which GitHub does not autolink inside code spans; use plain #N so they resolve on this repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The opaque 900-second Noema "Repair" wall-clock deadline (no telemetry on why) was already root-caused and fixed same-day: the bound had no owner-specified basis, and Noema was duplicating a repair/failover responsibility contextual-orchestrator already owns. The fix moved to one caller request with no fixed deadline plus per-attempt Actions telemetry, enforced by a permanent contract test. Confirmed the test still passes on this branch and that the item-39 example PR's post-fix retry is queued behind the already-documented org job ceiling, not a repair-deadline recurrence. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
changed the title
The closing line said no workflow-file edit could address any of the three rate-limit resources, but the paragraph right above it already describes two workflow-level mitigations in place (strix.yml's per-repo serialization, org-queue-sweep's own pagination/budget ceilings). Only the plan-level 60-job ceiling is actually outside a workflow file's reach; say that precisely instead of a blanket claim the preceding text contradicts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…ences Both mentions of the item-39 example PR omitted the ContextualWisdomLab/ owner prefix required for a cross-repository reference (this doc lives in .github, contextual-orchestrator is a different repo) and one was wrapped in backticks, which also blocks GitHub's autolinking. Use plain ContextualWisdomLab/contextual-orchestrator#1008 in both places. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
New repositories already get automatic CodeQL coverage from their first pull request via the org required-workflow ruleset's dynamic ~ALL target (codeql-pr.yml), with no PR needing to be opened into the new repo at all. The three repos on GitHub's native code-scanning default setup cover the ruleset's own exclusions (noema needs it because it's excluded from the ruleset; .github runs codeql-pr.yml directly; IRT-bibliography-set has neither, consistent with being a non-code repo). This is a stronger answer than the requested Noema/OpenCode-authored-PR mechanism, not a gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
changed the title
Comment on lines
+58
to
+60
| ".github", "IRT-bibliography-set"]}` — `~ALL` is a *dynamic* match, so a | ||
| brand-new repository is covered from its very first pull request with zero | ||
| manual or automated action, the moment that PR exists. `.github` runs |
Contributor
There was a problem hiding this comment.
🟡 New repositories can miss CodeQL
Repositories using another default-branch name or source language receive no applicable scan from codeql-pr.yml. The dynamic ruleset cannot provide universal coverage.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Author
There was a problem hiding this comment.
Confirmed and fixed both catches:
- The branch restriction was real and live-verified beyond the workflow text:
j-planner's open PR 🛡️ Sentinel: Add organization-wide default security policy #2 (default branchgh-pages) received every other required check but zero CodeQL checks of any kind. Removedbranches: [main, master, develop]from codeql-pr.yml's pull_request trigger, matching security-scan.yml's own "do not restrict the base ref" precedent, and updated the one contract-test assertion that pinned the old line. - The language-matrix gap (missing C/C++, C#, Go, Ruby, Swift) is correct too, but it's a larger change (new per-language detection heuristics + build-mode handling + test fixtures) than fits this PR -- filed as codeql-pr.yml language-detection matrix misses C/C++, C#, Go, Ruby, Swift #1762 rather than rushing it in.
🤖 Addressed by Claude Code
…ranches codeql-pr.yml's own `branches: [main, master, develop]` filter sat underneath the org required-workflow ruleset's dynamic ~DEFAULT_BRANCH target, silently producing zero CodeQL checks for any repository whose default branch isn't literally one of those three names. Confirmed live: j-planner (default branch gh-pages) received every other required check on its open PR #2 but no CodeQL check at all; argos/OmniRoute/graphify (forks defaulting to developmental/release-v3.8.50/v8) were equally exposed. Removed the restriction to match security-scan.yml's own established "do not restrict the base ref" precedent -- the ruleset's ref_name condition is already the authoritative gate, so the hardcoded list was redundant risk, not a second intended layer. Updated the one contract-test assertion that pinned the old line; actionlint and the rest of the workflow's/repo's tests are unaffected. Filed the language-detection matrix gap Devin also caught (misses C/C++, C#, Go, Ruby, Swift) as .github#1762 -- larger, separately-scoped change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seonghobae
deleted the
claude/workflow-orchestrator-improvements-b16824
branch
September 3, 2026 02:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Answers loop-brief items 15-18 (workflow consolidation / rate-limit /
installation-token-format check) with evidence rather than re-investigating
each from scratch. All four are already resolved on this branch's base
(
4f95abc); this PR only records that.org-queue-sweep): can't be replaced by plain Actions syntax(no native org-wide-PR-sweep primitive); its rate-limit symptom traces to
the org Actions plan 60-concurrent-job ceiling (
.github#1754), not thejob's own design.
(refactor(actions): consolidate 18 hourly review-repair callers into one file #1673) and the hardcode that made that specific run fail was already
fixed (fix(scheduler): admit governance-risk-compliance via the org variable, not a hardcode #1743) -- the linked failure predates both.
workflow files, 18/19 filename collisions are genuinely different
policies with named evidence).
ghs_installation-token format): no fixed-length or fixed-prefixtoken assumption anywhere in
scripts/ci/or.github/workflows/; theonly token regexes are format-agnostic secret-redaction patterns.
Test plan
scripts/ci/or workflow-YAML behavior touched.docs/doctoring/as a whole (onlyspecific named files), so adding this file cannot break a contract test.
🤖 Generated with Claude Code