docs: record org-wide CI workflow duplication audit (no new consolidation found) - #1731
Merged
Merged
Conversation
…tion found) Re-swept all 63 non-archived/non-fork ContextualWisdomLab repos (255 workflow files) for CI logic duplication beyond the hourly-review-repair, R-CMD-check, and dependency-review consolidations already done, in case the prior survey that found those candidates was itself capped. 19 filename groups (appearing in 2+ repos) checked field-by-field. 18 are genuinely different policies sharing only a filename convention -- backed by named, quoted evidence per group (language/toolchain, security posture, thresholds, trust model, job topology). One real duplicate found: hourly-pr-maintenance.yml in DiagramWeave/ThreadWeave, byte-identical except a deliberate cron stagger and comment wording -- not acted on since both are already ~20-30 line thin callers of a shared reusable workflow; wrapping a wrapper for two files this small would be an unrequested abstraction. Also surfaced a discrepancy worth tracking: dependency-review.yml's central reusable target exists, but none of its four intended callers (mightyETL, naruon, newsdom-api, scopeweave) has actually migrated to uses: it yet -- each still runs its original, still-diverging standalone policy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+88
to
+100
| ### Discrepancy found: `dependency-review.yml`'s central reusable target exists but no caller has migrated to it yet | ||
|
|
||
| `.github/workflows/dependency-review.yml` is already a `workflow_call` reusable target with inputs | ||
| (`fail_on_severity`, `allow_ghsas`, `continue_on_error`) and a dynamic dependency-graph-availability | ||
| probe, and its own header comment documents that it was built specifically to reconcile policy | ||
| differences found in mightyETL/newsdom-api/scopeweave's original standalone files. However, as of this | ||
| audit, **none of the four caller repos checked (mightyETL, naruon, newsdom-api, scopeweave) has | ||
| actually switched its own `dependency-review.yml` to `uses:` the central target** — each still carries | ||
| a full standalone implementation, and those standalone implementations still genuinely diverge on | ||
| severity threshold (`high` vs `moderate` vs unset), dependency-graph-unavailability handling (a static | ||
| `private == false` job split vs a dynamic curl probe vs no gating at all), presence of | ||
| `step-security/harden-runner` (naruon only), PR trigger branch scoping (naruon only restricts to | ||
| `develop`/`master`/`release/**`), and a vulnerability allowlist entry (newsdom-api only). |
Contributor
There was a problem hiding this comment.
🔍 Dependency-review history conflicts
The audit replaces argos with naruon and reports zero migrations. The accepted ADR records exact-SHA callers for all four intended repositories.
Was this helpful? React with 👍 or 👎 to provide feedback.
Comment on lines
+49
to
+58
| **Why NOT_SAFE, not just "different repo names":** every NOT_SAFE verdict above is backed by named, | ||
| quoted differences in *policy*, not cosmetics — different languages/toolchains (Rust vs Node vs Python | ||
| vs Java/Maven vs Java/Gradle), different security postures (SARIF upload present/absent, | ||
| `step-security/harden-runner` present/absent, `security-events: write` present/absent), different | ||
| trust models (OIDC trusted publishing vs secret-based PyPI auth), different thresholds (Bandit's | ||
| target directory and exclusions, Scorecard's `publish_results` toggle, a SARIF-finding suppression | ||
| step present in one file and absent in its closest sibling), and different job topology (job counts | ||
| from 1 to 7 within a single filename group). The full per-group evidence (concrete quoted lines, | ||
| action-pin SHAs, and reasoning) is preserved in this audit's workflow run journal — see Audit trail | ||
| below — and is too long to duplicate here without losing readability. |
Contributor
There was a problem hiding this comment.
🔍 Audit evidence remains private
The 19 verdicts defer their concrete evidence to wf_9d141ecd-c03. Repository rules require durable knowledge in the repository or Project.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
added
documentation
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backlog item from a peer session: re-sweep the org for CI workflow duplication the earlier
hourly-review-repair/R-CMD-check/dependency-reviewconsolidations might have missed, since thesurvey that found those candidates may itself have been capped.
Enumerated all 63 non-archived/non-fork ContextualWisdomLab repos (255 workflow files across them),
grouped by filename, and read the full content of every instance of every filename appearing in
2+ repos (19 groups) rather than trusting name matches — the exact caution this session already
learned from
dependency-review.yml's own consolidation, where similar-looking files hid realseverity-threshold and allowlist differences.
Result
languages/toolchains, security postures, thresholds, trust models, job topology. Each verdict in the
doctoring doc is backed by quoted, concrete evidence, not a name-only judgment.
hourly-pr-maintenance.ymlin DiagramWeave/ThreadWeave — byte-identicalexcept a deliberate cron stagger. Not acted on: both are already thin (~20-30 line) callers of a
shared reusable workflow: consolidating further would wrap a wrapper for two small files.
dependency-review.yml's central reusable target exists, but none ofits four intended callers (mightyETL, naruon, newsdom-api, scopeweave) has actually migrated to
uses:it — each still runs its original, still-diverging standalone policy.Full per-group evidence is in
docs/doctoring/ci-workflow-duplication-audit-20260902.md.Test plan
gh api orgs/ContextualWisdomLab/repos --paginate+ per-repo workflow listing re-verified against the doctoring doc's table🤖 Generated with Claude Code