Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add milestone markers #29

Closed
wants to merge 2 commits into from
Closed

Conversation

deodad
Copy link

@deodad deodad commented Nov 18, 2021

#27

Screen Shot 2021-11-17 at 8 28 33 PM

Screen Shot 2021-11-17 at 8 28 27 PM

@netlify
Copy link

netlify bot commented Nov 18, 2021

✔️ Deploy Preview for clever-johnson-ef5610 ready!

🔨 Explore the source changes: 64c4877

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-johnson-ef5610/deploys/6195bbdea1192b000712612c

😎 Browse the preview: https://deploy-preview-29--clever-johnson-ef5610.netlify.app/

const label = document.createElement("div");
label.className = "milestone-label";
label.style.left = percentage * 100 + "%";
label.innerText = "Goal " + (i + 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make these say $14mm and $30mm perhaps?

Copy link

@rhythms06 rhythms06 Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd also be helpful to provide brief summaries of the milestones underneath the bar. Something like:

Goal 1 ($14M): Qualify for the auction
Goal 2 ($20M): Have more than the estimated cost of the constitution
Goal 3 ($30M): Have enough to be competitive at the auction

And strikethrough all three lines to show we've beat them.

Another idea I had was to color code the goal lines on the bar as well as the summaries to make things even clearer.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more idea - have the targetUsd always be a certain percentage or amount higher than raisedUsd so that the progress bar automatically updates with a consistent and predictable look.

@tmb tmb closed this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants