Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partyinfo to update url #952

Merged
merged 3 commits into from
Dec 31, 2019
Merged

Allow partyinfo to update url #952

merged 3 commits into from
Dec 31, 2019

Conversation

namtruong
Copy link
Collaborator

PartyInfo service should allow url to be updated for an existing key.

Warn log message to suggest users to switch on remote key validation.

Fixes #951

…aviour before 0.10. Log message to recommend users to switch on remote key validation for better security
@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #952 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #952      +/-   ##
============================================
- Coverage     99.31%   99.31%   -0.01%     
  Complexity     2087     2087              
============================================
  Files           320      320              
  Lines          5709     5708       -1     
  Branches        328      328              
============================================
- Hits           5670     5669       -1     
  Misses            5        5              
  Partials         34       34
Impacted Files Coverage Δ Complexity Δ
...quorum/tessera/partyinfo/PartyInfoServiceImpl.java 97.18% <ø> (-0.04%) 18 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fd8b8...5ec814a. Read the comment docs.

@melowe melowe merged commit f6f5b60 into master Dec 31, 2019
@namtruong namtruong deleted the allow-partyinfo-to-update-url branch January 6, 2020 15:39
@Krish1979 Krish1979 added 0.10.3 0.10.3 bug Something isn't working labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.3 0.10.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow url update with same key if remote node validation is disabled.
5 participants