Allow partyinfo to update url (#952)

* Allow partyinfo to update existing key with new url. This was the behaviour before 0.10. Log message to recommend users to switch on remote key validation for better security * Update unit test for partyinfo service
Consensys · Dec 31, 2019 · f6f5b60 · f6f5b60
1 parent f7fd8b8
commit f6f5b60
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tessera-partyinfo/src/main/java/com/quorum/tessera/partyinfo/PartyInfoServiceImpl.java b/tessera-partyinfo/src/main/java/com/quorum/tessera/partyinfo/PartyInfoServiceImpl.java
@@ -72,8 +72,8 @@ public PartyInfo updatePartyInfo(final PartyInfo partyInfo) {
 
             if (!this.validateKeysToUrls(existingPartyInfo, partyInfo)) {
                 LOGGER.warn(
-                        "Attempt is being made to update existing key with new url. Terminating party info update.");
-                return this.getPartyInfo();
+                        "Attempt is being made to update existing key with new url. " +
+                            "Please switch on remote key validation to avoid a security breach.");
             }
         }
 

diff --git a/tessera-partyinfo/src/test/java/com/quorum/tessera/partyinfo/PartyInfoServiceTest.java b/tessera-partyinfo/src/test/java/com/quorum/tessera/partyinfo/PartyInfoServiceTest.java
@@ -276,7 +276,7 @@ public void createWithFactoryConstructor() throws Exception {
     }
 
     @Test
-    public void attemptToUpdateRecipientWithExistingKeyWithNewUrlIsIgnoredIfToggleDisabled() {
+    public void attemptToUpdateRecipientWithExistingKeyWithNewUrlIfToggleDisabled() {
         // setup services
         final FeatureToggles featureToggles = new FeatureToggles();
         featureToggles.setEnableRemoteKeyValidation(false);
@@ -305,6 +305,7 @@ public void attemptToUpdateRecipientWithExistingKeyWithNewUrlIsIgnoredIfToggleDi
         assertThat(updatedInfo.getRecipients()).hasSize(1).containsExactly(new Recipient(testKey, uri));
         verify(partyInfoStore, times(2)).getPartyInfo();
         verify(configService).featureToggles();
+        verify(configService).isDisablePeerDiscovery();
     }
 
     @Test