Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load resource stream over file #733

Merged
merged 3 commits into from
May 7, 2019
Merged

Load resource stream over file #733

merged 3 commits into from
May 7, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented May 7, 2019

Fixes #732

Getting the file path of a resource was causing a FileSystemNotFound exception to be thrown, which happens when trying to access the Path of the included database schemas.
To fix this, we get a stream for the resource instead of using the file directly.

Add extra debug info that contains the exception type, which proved useful in debugging this scenario; more can be added as needed.

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #733 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #733      +/-   ##
============================================
+ Coverage     99.44%   99.44%   +<.01%     
+ Complexity     1890     1886       -4     
============================================
  Files           285      285              
  Lines          5615     5620       +5     
  Branches        284      284              
============================================
+ Hits           5584     5589       +5     
  Misses            5        5              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...n/java/com/quorum/tessera/config/ServerConfig.java 100% <ø> (ø) 25 <0> (ø) ⬇️
...quorum/tessera/data/migration/CmdLineExecutor.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...rum/tessera/data/migration/SqliteDataExporter.java 100% <100%> (ø) 4 <0> (-2) ⬇️
.../quorum/tessera/data/migration/H2DataExporter.java 100% <100%> (ø) 2 <0> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e39dde...6650f71. Read the comment docs.

@melowe melowe merged commit 7e39a03 into master May 7, 2019
@prd-fox prd-fox deleted the fix-resource-reading branch May 23, 2019 13:33
@Krish1979 Krish1979 added 0.9.3 and removed 0.10.0 labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug using bundled DDL resources during data migration
4 participants