Peerdas + master upstream + test fixes#9436
Merged
zilm13 merged 74 commits intoConsensys:dasfrom May 20, 2025
Merged
Conversation
…nsys#9342) It's hard to reason on how these two should interact, and logically they're mutually exclusive, so this just solidifies the theory that they shouldn't be used together. Signed-off-by: Paul Harris <paul.harris@consensys.net>
I ended up disabling the instanceof errorprone, as it's very very common for us to be doing it apparently. I started changing things but in the interest of time will raise a ticket Signed-off-by: Paul Harris <paul.harris@consensys.net>
Co-authored-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Co-authored-by: Paul Harris <paul.harris@consensys.net>
* Start cleaning up `api/schema` - moved `ValidatorStatus` - Removed `Version` - Moved `PublicKeyException` - Moved `EventType` Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
* Added KZG computeCells method * Moved KZG no-operation logic into testFixture class
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
) - added tests to show reading lists of objects (BPO related) - added a testcase to show that hex is read correctly - added testcase to show specConfigReader isnt filling defaults when we read local config files Partially addresses Consensys#9365 Signed-off-by: Paul Harris <paul.harris@consensys.net>
- Tests demonstrate that this should at least be very close to what we require for reading BPO schedule. Partially addresses Consensys#9365 Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
…rder for GetNewBlockV3IntegrationTest
Signed-off-by: Paul Harris <paul.harris@consensys.net>
…d fulu duplication
Signed-off-by: Paul Harris <paul.harris@consensys.net> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
rolfyone
reviewed
May 20, 2025
|
|
||
| public class GetDataColumnSidecars extends RestApiEndpoint { | ||
| public static final String ROUTE = "/eth/v1/beacon/data_column_sidecars/{block_id}"; | ||
| public static final String ROUTE = "/teku/v1/beacon/data_column_sidecars/{block_id}"; |
Contributor
There was a problem hiding this comment.
why's this moving to /teku namespace?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Changes from branch peerdas-yolo at the current poiint:
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog