Created Fulu skeleton setup

[lucassaldanha]

PR Description

Preparing for the upcome addition of all PeerDAS types and logic.

Fixed Issue(s)

N/A

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[rolfyone]

we should actually be able to put all the fulu fields in and be standard to the testconfig again iirc...

[rolfyone]

i do wonder if we could just refactor this all to be less ugly... that whole pattern of for each new fork we add a line we could clean up...
something like

if (specMilestone>= ALTAIR) {
builder -> builder.altairBuilder(a -> a.altairForkEpoch(UInt64.ZERO));
}
if (specMilestone>= BELLATRIX) {
builder -> builder.bellatrixBuilder(a -> a.bellatrixForkEpoch(UInt64.ZERO));
}

[lucassaldanha]

I have made a change similar to what you suggested. My only concern is that we might end up missing this when we add a new fork. Using the switch we get a compiler time warning when we are missing a fork. Wdyt?

[rolfyone]

put a 'if last enum is greater than fulu' test... :)

[zilm13]

We have this in SpecConfigElectraImpl. My assumptiions was that we should continue in the same style:

  @Override
  public int getMaxBlobsPerBlock() {
    return maxBlobsPerBlockElectra;
  }

[zilm13]

It's a part of config, not preset, see https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L180
The main differrence is that config values can be overriden by custom config for example in Kurtosis, presets cannot

[zilm13]

It's a part of config also, see: https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L181

[zilm13]

Same here and in swift. Shouldn't be a part of preset

[zilm13]

Looking at previous milestone configurations, shouldn't it be

        tekuNodeConfigBuilder.withCapellaEpoch(UInt64.ZERO);
        tekuNodeConfigBuilder.withDenebEpoch(UInt64.ZERO);
        tekuNodeConfigBuilder.withElectraEpoch(UInt64.ZERO);
        tekuNodeConfigBuilder.withFuluEpoch(UInt64.ZERO);

[zilm13]

Not sure on this, it means no supported methods for FULU. Are you sure?

[lucassaldanha]

No. It means we are not adding any FULU specific methods.

[zilm13]

do we need to add FULU to TestSpecContext also?

[lucassaldanha]

Ooopsie :)

[zilm13]

I'd add shouldOverrideBlobRelatedValuesValues like in Electra test also

[zilm13]

notEquals?

[lucassaldanha]

What we are testing is that the equals() method still works for different values, in this case, returning false.

[zilm13]

the same notEquals?

[lucassaldanha]

Same as above :)

[zilm13]

LGTM, just few nits
Also it may worth adding/updating here or in the separate PRs:
SpecConfigBuilderTest
SpecMilestoneTest

[zilm13]

16384 in spec, see https://github.com/ethereum/consensus-specs/blob/dev/configs/mainnet.yaml#L175

[zilm13]

16384 in spec, see https://github.com/ethereum/consensus-specs/blob/dev/configs/minimal.yaml#L173

[zilm13]

I'd use minimal config number (16384) here and in other non spec-ed configs