Skip to content

Reftests alpha8 - #10762

Merged
zilm13 merged 10 commits into
Consensys:masterfrom
zilm13:reftests-alpha8
Jun 1, 2026
Merged

Reftests alpha8#10762
zilm13 merged 10 commits into
Consensys:masterfrom
zilm13:reftests-alpha8

Conversation

@zilm13

@zilm13 zilm13 commented May 28, 2026

Copy link
Copy Markdown
Contributor

PR Description

Some network tests are still ignored, we will address it later without hurry

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Low Risk
Changes are confined to reference tests, spec metadata, and read-only fork-choice test hooks; production fork-choice logic is only exposed for spec-test assertions, not altered in behavior beyond that wiring.

Overview
Bumps consensus-spec-tests from v1.7.0-alpha.7 to alpha.8, re-enables Gloas pyspec discovery (removes the alpha.7 skip), and refreshes specrefs (version, Gloas/Electra deltas, temporary exceptions for not-yet-aligned areas).

Reference-test harness: adds createAnchorFromStateAndMatchingBlock and uses it in gossip block/attestation/aggregate setup so the store anchor matches fixture blocks when state_root aligns; gossip block setup gains execution payload status handling and stricter setup import assertions; attestation gossip loads Electra SingleAttestation when applicable.

Fork-choice tests: full on_execution_payload_envelope coverage; new on_payload_attestation_message steps (wire vs block, valid flag); fork-choice checks for payload_timeliness_vote and payload_data_availability_vote, backed by new read APIs on ForkChoiceStrategy / ForkChoiceModelGloas (PTC vote tracker).

Gossip test registration: gossip_beacon_block enabled; gossip_bls_to_execution_change enabled with one skipped case; attestation/aggregate/blob gossip remain ignored.

Reviewed by Cursor Bugbot for commit 8d8df33. Bugbot is set up for automated code reviews on this repo. Configure here.

@zilm13

zilm13 commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

Current failures, 3:

gloas - mainnet - fork/fork > fork_invalid_validator_deposit_followed_by_builder_credentials FAILED
    java.lang.AssertionError: Expected BeaconStateGloasImpl's to be equal by getter, but found differences:

gloas - minimal - fork/fork > fork_invalid_validator_deposit_followed_by_builder_credentials FAILED
    java.lang.AssertionError: Expected BeaconStateGloasImpl's to be equal by getter, but found differences:

gloas - mainnet - operations/voluntary_exit > builder_voluntary_exit__success FAILED
    org.opentest4j.AssertionFailedError: 

fork/fork are probably fixed with #10729
not sure about operations one, could recheck later when all alpha.8 parts are in master and this pr is rebased on top of it

@zilm13 zilm13 mentioned this pull request May 28, 2026
17 tasks
@StefanBratanov

Copy link
Copy Markdown
Contributor

Current failures, 3:

gloas - mainnet - fork/fork > fork_invalid_validator_deposit_followed_by_builder_credentials FAILED
    java.lang.AssertionError: Expected BeaconStateGloasImpl's to be equal by getter, but found differences:

gloas - minimal - fork/fork > fork_invalid_validator_deposit_followed_by_builder_credentials FAILED
    java.lang.AssertionError: Expected BeaconStateGloasImpl's to be equal by getter, but found differences:

gloas - mainnet - operations/voluntary_exit > builder_voluntary_exit__success FAILED
    org.opentest4j.AssertionFailedError: 

fork/fork are probably fixed with #10729 not sure about operations one, could recheck later when all alpha.8 parts are in master and this pr is rebased on top of it

Voluntary tests fail because of MIN_WITHDRAWABILITY_DELAY very likely. Can you just ignore those tests for now and they will be fixed in #10729

@zilm13
zilm13 marked this pull request as ready for review May 29, 2026 14:42
@zilm13

zilm13 commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

@StefanBratanov everything is fixed, not actual

@StefanBratanov StefanBratanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment

Comment thread specrefs/constants.yml

- name: SAFETY_DECAY#phase0
sources:
- file: ethereum/weaksubjectivity/src/main/java/tech/pegasys/teku/weaksubjectivity/config/WeakSubjectivityConfig.java

@StefanBratanov StefanBratanov May 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We moved this to:

tech.pegasys.teku.spec.logic.common.weaksubjectivity.WeakSubjectivityCalculator by the way

@zilm13
zilm13 merged commit 88f3c17 into Consensys:master Jun 1, 2026
91 checks passed
@zilm13
zilm13 deleted the reftests-alpha8 branch June 1, 2026 12:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants