Optimize onboarding builders at the fork + add BuilderIndexCache - #10729
Merged
StefanBratanov merged 17 commits intoMay 29, 2026
Conversation
zilm13
previously approved these changes
May 20, 2026
| // If there is a valid pending deposit for a new validator with this pubkey, keep this | ||
| // deposit in the pending queue to be applied to that validator later. | ||
| final boolean isPendingValidator = | ||
| verifiedPendingValidatorPubkeys.contains(pubkey) |
Contributor
There was a problem hiding this comment.
nit: I'd refactor this logic to spread along more lines but be more readable
StefanBratanov
force-pushed
the
onboard_builders_fork
branch
from
May 21, 2026 12:54
b3ad979 to
2d560db
Compare
rolfyone
previously approved these changes
May 25, 2026
StefanBratanov
force-pushed
the
onboard_builders_fork
branch
from
May 26, 2026 09:38
b3452c6 to
90938e4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
StefanBratanov
force-pushed
the
onboard_builders_fork
branch
from
May 27, 2026 13:57
90938e4 to
1f154f6
Compare
StefanBratanov
changed the title
StefanBratanov
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
Reviewed by Cursor Bugbot for commit 078b4a8. Configure here.
zilm13
previously approved these changes
May 28, 2026
StefanBratanov
enabled auto-merge (squash)
May 29, 2026 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Implements functionality as per ethereum/consensus-specs#5254 The reference tests changed as far as I know so that's why they are failing, will test once we merge other alpha.8 changes
Also added
BuilderIndexCachesimilar toValidatorIndexCacheto optimize builder index retrievalSmall refactor to put back
apply_parent_execution_payloadtoBlockProcessor.Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
High Risk
Changes Gloas beacon state transition, deposit classification, fork upgrade onboarding, and fork-choice payload simulation鈥攃onsensus-critical paths tied to an in-flight spec update.
Overview
Aligns Gloas with updated consensus-spec behavior (including MIN_BUILDER_WITHDRAWABILITY_DELAY 8192 on mainnet) and speeds builder-related state work.
Introduces
BuilderIndexCache(mirroringValidatorIndexCache) for pubkey鈫抜ndex lookups with incremental scanning, bounds checks when caches are shared across states, and copied builder caches onTransitionCaches.copy()because builder slots can be reassigned.BeaconStateAccessorsGloas.getBuilderIndexnow uses that cache.Moves
apply_parent_execution_payloadback intoBlockProcessorGloas;ForkChoiceUtilGloas(and Heze wiring) calls the block processor for payload-attribute withdrawals instead ofExecutionRequestsProcessorGloas.Reworks builder onboarding at the Gloas fork and deposit request classification: single-pass pending-deposit handling with
ValidatorsUtil/isPendingValidatoron a list (no repeated full-registry/set scans).ExecutionRequestsProcessorGloasdeposit routing matches that model.Reviewed by Cursor Bugbot for commit 2051ac7. Bugbot is set up for automated code reviews on this repo. Configure here.