Skip to content

Check gas limit consistency with the target - #10760

Merged
zilm13 merged 6 commits into
Consensys:masterfrom
zilm13:check-gas-limit
May 29, 2026
Merged

Check gas limit consistency with the target#10760
zilm13 merged 6 commits into
Consensys:masterfrom
zilm13:check-gas-limit

Conversation

@zilm13

@zilm13 zilm13 commented May 28, 2026

Copy link
Copy Markdown
Contributor

PR Description

Implementation of ethereum/consensus-specs#5236
Part of alpha.8 spec #10724

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Medium Risk
Changes Gloas gossip validation and SSZ field naming for proposer preferences, affecting which builder bids are accepted; fork upgrade bid initialization is also adjusted.

Overview
Aligns Gloas proposer preferences with consensus-spec alpha.8 by renaming the SSZ field from gas_limit to target_gas_limit and threading that name through creation, publishing, and payload-attribute selection.

Execution payload bid gossip no longer rejects bids whose gas_limit differs from preferences by exact equality. It now ignores bids unless gas_limit is compatible with target_gas_limit under the EIP-1559 卤1/1024 rule from the parent execution payload鈥檚 gas limit, deferring validation when the parent limit is unknown. GossipValidationHelper exposes parent gas limit lookup from the store.

Gloas fork upgrade seeds latest_execution_payload_bid with the pre-fork latest payload gas limit instead of zero. Reference tests temporarily skip the Gloas fork directory until alpha.8 vectors land.

Reviewed by Cursor Bugbot for commit 33e3bee. Bugbot is set up for automated code reviews on this repo. Configure here.

@zilm13 zilm13 mentioned this pull request May 28, 2026
17 tasks
@zilm13 zilm13 mentioned this pull request May 28, 2026
2 tasks
StefanBratanov
StefanBratanov previously approved these changes May 29, 2026

@StefanBratanov StefanBratanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zilm13
zilm13 enabled auto-merge (squash) May 29, 2026 10:36
StefanBratanov
StefanBratanov previously approved these changes May 29, 2026

@StefanBratanov StefanBratanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zilm13
zilm13 merged commit d39b610 into Consensys:master May 29, 2026
229 of 235 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
@zilm13
zilm13 deleted the check-gas-limit branch May 29, 2026 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants