DNS support for static nodes and discovery #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a switch to enable DNS changes in raft to ensure default behaviour is backwards-compatible with older versions. Add ability to deserialise old raft address information Remove IP and undecoded elements from output via raft API. Allow P2P layer to use the FQDN Add hostname flag to specify the DNS hostname to use during discovery for this node Add hostname of this node to ping packets, so that the receiver adds the DNS name to their node bucket Add Quorum specific UDP classes and types, which are a modified version of discv4 Make bootnode listen for Quorum Discovery messages Remove double-decode of rlp elements by creating the RLP stream outside. Add forward-compatibility by adding a tail of undecoded RLP elements that are ignored. Add document for command line arguments, link to upstream arguments and including DNS specific changes.
move docs to correct place and update doc index Fix mehod comments and Quorum location comments
Move new "hostname" flag to be under Quorum options instead of networking options.
Take upstream change for hostname parsing found at ethereum/go-ethereum#18524
Keep raft CLI arg name in line with other raft args by keeping as all one word
The node will not start if the provided hostname flag does not resolve to an IP address, to prevent a user accidentally mistyping their intended address.
Krish1979
previously approved these changes
Nov 19, 2019
It should be included later with a comprehensive listing of Quorum specific options.
trung
reviewed
Nov 20, 2019
jbhurat
reviewed
Nov 20, 2019
trung
reviewed
Nov 21, 2019
jbhurat
reviewed
Nov 21, 2019
discovery based DNS support.
|
I have removed the discovery section of the PR, so discovery will only use IP addresses as before. I have resolved comments relating to those portions. |
time. This allows us to continuously try to connect to static nodes without restarting.
hostname does not resolve to a valid IP, so the output will not match the input as the current test setup expects. The output will be caught in other part of the systems and handled appropriately.
keep resolving the hostname instead of just at startup. Ran goimports.
…old" vs "new", which will not having meaning in the future.
how the resolution failed
nicolae-leonte-go
approved these changes
Nov 27, 2019
jpmsam
approved these changes
Nov 27, 2019
|
thank you Quorum team for making this enhancement! |
libby
added a commit
to libby/qubernetes
that referenced
this pull request
Aug 20, 2020
* Use k8s service hostname for quorum peers: permissioned-nodes.json and static-nodes.json. * Use k8s service hostname in tessera config for peer discovery. * The hostnames are obtained via the quorum services which are known at the time of generation and do not change. This removes the need to do sed and manipulation on the config files after they are deployed in order to set the IPs (which are not known until after k8s resources have been deployed). This also helps with automatically updating the config files when new nodes are deployed or removed, thus avoiding restarting the nodes. * Enabled by this PR: Consensys/quorum#885.
libby
added a commit
to Consensys/qubernetes
that referenced
this pull request
Aug 20, 2020
* Switch peers from using variable IPs to hostnames. * Use k8s service hostname for quorum peers: permissioned-nodes.json and static-nodes.json. * Use k8s service hostname in tessera config for peer discovery. * The hostnames are obtained via the quorum services which are known at the time of generation and do not change. This removes the need to do sed and manipulation on the config files after they are deployed in order to set the IPs (which are not known until after k8s resources have been deployed). This also helps with automatically updating the config files when new nodes are deployed or removed, thus avoiding restarting the nodes. * Enabled by this PR: Consensys/quorum#885. * Remove support / testing for quorum <= 2.3.0 * hostname not supported pre 2.3.0, if there is demand to support them, we can include support, but for now removing support as these version should be phased out. * add sleep in quorum version tests after running initial public contract to allow block number to increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds full DNS support for Quorum.
This includes:
use of DNS hostnames in the static-nodes.json file, so that we can connect to our static nodes even when the IP address of the DNS name has changed, meaning less updating of the static node definition file. This is an improvement to previous behaviour which resolved the DNS hostname once at startup and then only tracked the IP address