This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Switch peers from using variable IPs to hostnames. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use k8s service hostname for quorum peers: permissioned-nodes.json and static-nodes.json. * Use k8s service hostname in tessera config for peer discovery. * The hostnames are obtained via the quorum services which are known at the time of generation and do not change. This removes the need to do sed and manipulation on the config files after they are deployed in order to set the IPs (which are not known until after k8s resources have been deployed). This also helps with automatically updating the config files when new nodes are deployed or removed, thus avoiding restarting the nodes. * Enabled by this PR: Consensys/quorum#885.
* hostname not supported pre 2.3.0, if there is demand to support them, we can include support, but for now removing support as these version should be phased out. * add sleep in quorum version tests after running intial public contract to allow block number to increase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use k8s service hostname for quorum peers: permissioned-nodes.json and static-nodes.json.
Use k8s service hostname in tessera config for peer discovery.
The hostnames are obtained via the quorum services which are known at the time of generation and do not change.
This removes the need to do sed and manipulation on the config files after they are deployed in order to set the IPs
(which are not known until after k8s resources have been deployed). This also helps with automatically updating the
config files when new nodes are deployed or removed, thus avoiding restarting the nodes.
Enabled by this PR: DNS support for static nodes and discovery quorum#885.