Use eip155 signer for public transactions #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmsam
reviewed
Jun 4, 2018
internal/ethapi/api.go
Outdated
| @@ -1052,7 +1053,7 @@ func (s *PublicTransactionPoolAPI) sign(addr common.Address, tx *types.Transacti | |||
| // Request the wallet to sign the transaction | |||
| var chainID *big.Int | |||
| isQuorum := false | |||
| if config := s.b.ChainConfig(); config.IsEIP155(s.b.CurrentBlock().Number()) { | |||
| if config := s.b.ChainConfig(); config.IsEIP155(s.b.CurrentBlock().Number()) && !tx.IsPrivate() { | |||
| chainID = config.ChainId | |||
| isQuorum = true | |||
There was a problem hiding this comment.
@Szkered isQuorum will stay false here for private(Quorum) transactions.
…to use
V={37,38}, hence you need to set chain id to soem value other than 1 to avoid conflict
jpmsam
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use eip155 for public transactions. Private transactions will continue to use V={37,38}, hence you need to set chain id to some value other than 1 to avoid conflict. This PR should be merged along with #350 (which enable eip155 for locally signed transactions), and #354 (which fixes
TestEIP155SigningVitalikby using a new set of test vectors withchain_id=10)Tested on public value transfer, private contract deployment, public contract deployment on 'Ubuntu 16.04.4 LTS
withWeb3 1.0.0-beta.34andchain_id=10`.