-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TestUpdatedKeyfileContents, TestEIP155SigningVitalik and TestChainId #354
Conversation
@jpmsam |
Please merge this request quickly.. 'Invalid sender' error is critical for further developing.. |
@nujabes403 we are working on testing it. Please provide your feedback on whether the updates fixed the issue for you as well. |
Actually, #350 is the fix to "invalid sender". |
@tsuzukit thanks, we are in the process of testing both. |
the master branch it test failing in macos, please review and merge it asap. |
Fix TestUpdatedKeyfileContents, TestEIP155SigningVitalik and TestChainId
For fixing
TestUpdatedKeyfileContents
, I have cherry-picked c86c126 and c8b5da7 which are already merged to geth 1.7.3.For fixing
TestEIP155SigningVitalik
, I needed to changechainId
to something other than1
as it results inV
of37
and Tx is treated as protected transaction in Quorum (https://github.com/jpmorganchase/quorum/blob/master/core/types/transaction.go#L138).Since http://vitalik.ca/files/eip155_testvec.txt is not currently accessible, I just created some tx and address pair. (tx creation rules are written in comments)
For same reason, I needed to change
chainId
forTestChainId
.Please review.