Skip to content

fix: use backported gnark-crypto neg-scalar glv fix#1015

Merged
AlexandreBelling merged 1 commit into
mainfrom
fix/gnark-neg-glv-backport
May 15, 2025
Merged

fix: use backported gnark-crypto neg-scalar glv fix#1015
AlexandreBelling merged 1 commit into
mainfrom
fix/gnark-neg-glv-backport

Conversation

@ivokub
Copy link
Copy Markdown
Contributor

@ivokub ivokub commented May 15, 2025

See Consensys/gnark#1487, Consensys/gnark#1483, Consensys/gnark-crypto#680.

Updates only the solver hint for gnark, so no circuit update needed.

Do not merge to main! We should follow gnark and gnark-crypto master. This is only a backported fix.

@ivokub ivokub self-assigned this May 15, 2025
@ivokub ivokub added bug Something isn't working P1: High Issue priority: high labels May 15, 2025
@ivokub ivokub temporarily deployed to docker-build-and-e2e May 15, 2025 16:44 — with GitHub Actions Inactive
@ivokub ivokub marked this pull request as draft May 15, 2025 16:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.22%. Comparing base (11caf28) to head (671641d).
⚠️ Report is 2852 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1015      +/-   ##
============================================
- Coverage     66.24%   66.22%   -0.02%     
  Complexity     1191     1191              
============================================
  Files           339      339              
  Lines         13700    13700              
  Branches       1403     1403              
============================================
- Hits           9075     9073       -2     
- Misses         4040     4042       +2     
  Partials        585      585              
Flag Coverage Δ *Carryforward flag
hardhat 98.53% <ø> (-0.21%) ⬇️
kotlin 63.80% <ø> (ø) Carriedforward from 11caf28

*This pull request uses carry forward flags. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexandreBelling AlexandreBelling marked this pull request as ready for review May 15, 2025 17:38
@AlexandreBelling AlexandreBelling merged commit 42546e7 into main May 15, 2025
23 checks passed
@AlexandreBelling AlexandreBelling deleted the fix/gnark-neg-glv-backport branch May 15, 2025 17:38
jonesho pushed a commit that referenced this pull request Nov 20, 2025
This puts through a straightforward fix for the method
`ToyAccount.isStorageEmpty()`.  This unfortunately exposes a problem
with MXP / ROMLEX (#1014).  Two tests have been marked as `@Disabled`
until this problem is resolved.
jonesho pushed a commit that referenced this pull request Nov 24, 2025
This puts through a straightforward fix for the method
`ToyAccount.isStorageEmpty()`.  This unfortunately exposes a problem
with MXP / ROMLEX (#1014).  Two tests have been marked as `@Disabled`
until this problem is resolved.
jonesho pushed a commit that referenced this pull request Dec 8, 2025
This puts through a straightforward fix for the method
`ToyAccount.isStorageEmpty()`.  This unfortunately exposes a problem
with MXP / ROMLEX (#1014).  Two tests have been marked as `@Disabled`
until this problem is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P1: High Issue priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants