fix: use backported gnark-crypto neg-scalar glv fix#1015
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
============================================
- Coverage 66.24% 66.22% -0.02%
Complexity 1191 1191
============================================
Files 339 339
Lines 13700 13700
Branches 1403 1403
============================================
- Hits 9075 9073 -2
- Misses 4040 4042 +2
Partials 585 585
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
AlexandreBelling
approved these changes
May 15, 2025
jonesho
pushed a commit
that referenced
this pull request
Nov 20, 2025
jonesho
pushed a commit
that referenced
this pull request
Nov 20, 2025
jonesho
pushed a commit
that referenced
this pull request
Nov 24, 2025
jonesho
pushed a commit
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Consensys/gnark#1487, Consensys/gnark#1483, Consensys/gnark-crypto#680.
Updates only the solver hint for gnark, so no circuit update needed.
Do not merge to main! We should follow gnark and gnark-crypto master. This is only a backported fix.