Skip to content

fix: fake glv neg scalars#1487

Merged
ivokub merged 2 commits into
masterfrom
fix/fake-glv-neg-scalars
May 6, 2025
Merged

fix: fake glv neg scalars#1487
ivokub merged 2 commits into
masterfrom
fix/fake-glv-neg-scalars

Conversation

@ivokub
Copy link
Copy Markdown
Collaborator

@ivokub ivokub commented May 2, 2025

Description

Resolves #1483 by updating gnark-crypto which fixes the convergence.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Added edge case test for small negative scalar

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the type: bug Something isn't working label May 2, 2025
@ivokub ivokub requested review from gbotrel and yelhousni May 2, 2025 12:07
@ivokub ivokub self-assigned this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Eisenstein HalfGCD Hint computation doesn't converge for (order -2, order -3, order - 4, ...)

2 participants