Skip to content

fix: Fix unhandled ObjectDisposedException in IconTintColorBehavior.ClearTintColor on Android #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 4 commits into from
Jul 24, 2024
Merged

fix: Fix unhandled ObjectDisposedException in IconTintColorBehavior.ClearTintColor on Android #2012

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
841c9a0
fix: fix crash in IconTintColorBehavior.ClearTintColor on Android
Kay-STL Jul 11, 2024
7dfe430
Merge branch 'main' into fix/androidClearTintColorCrash
Kay-STL Jul 16, 2024
9c97840
Merge branch 'main' into fix/androidClearTintColorCrash
Kay-STL Jul 22, 2024
0f24088
Merge branch 'main' into fix/androidClearTintColorCrash
Kay-STL Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...tyToolkit.Maui/Behaviors/PlatformBehaviors/IconTintColor/IconTintColorBehavior.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ protected override void OnDetachedFrom(View bindable, AView platformView)
{
base.OnDetachedFrom(bindable, platformView);

ClearTintColor(bindable, platformView);
ClearTintColor();
bindable.PropertyChanged -= OnElementPropertyChanged;
PropertyChanged -= OnTintedImagePropertyChanged;
}
Expand Down Expand Up @@ -114,9 +114,14 @@ void OnElementPropertyChanged(object? sender, PropertyChangedEventArgs args)
ApplyTintColor();
}

void ClearTintColor(View element, AView control)
void ClearTintColor()
{
switch (control)
if (nativeView is null)
{
return;
}

switch (nativeView)
{
case ImageView image:
image.ClearColorFilter();
Expand Down