Skip to content

fix: Fix unhandled ObjectDisposedException in IconTintColorBehavior.ClearTintColor on Android#2012

Merged
TheCodeTraveler merged 4 commits into
CommunityToolkit:mainfrom
Swallowing-Technology:fix/androidClearTintColorCrash
Jul 24, 2024
Merged

fix: Fix unhandled ObjectDisposedException in IconTintColorBehavior.ClearTintColor on Android#2012
TheCodeTraveler merged 4 commits into
CommunityToolkit:mainfrom
Swallowing-Technology:fix/androidClearTintColorCrash

Conversation

@Kay-STL

@Kay-STL Kay-STL commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Description of Change

Following #1883, which fixed an ObjectDisposedException crash in ApplyTintColor, this PR fixes a crash in ClearTintColor in the same manner. Other users have reported experiencing this in the replies to the original issue linked below.

Linked Issues

PR Checklist

Additional information

Android only. Reproduced reliably in a production application on an Android 11 device, cannot reproduce after patch is applied.

@Kay-STL

Kay-STL commented Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree company="Swallowing Technologies Limited"

@Kay-STL Kay-STL marked this pull request as draft July 22, 2024 03:00
@Kay-STL Kay-STL marked this pull request as ready for review July 22, 2024 03:00
@TheCodeTraveler

Copy link
Copy Markdown
Collaborator

@Kay-STL Could you update this PR to allow maintainers to edit it? I'd like to merge it but I first need to fix the merge conflict.

image

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@Kay-STL

Kay-STL commented Jul 24, 2024

Copy link
Copy Markdown
Contributor Author

@brminnick Can't enable maintainer access since GitHub doesn't allow it on organization repos, sorry - I've fixed the conflicts, will make sure to PR from a personal repo next time :)

@TheCodeTraveler TheCodeTraveler merged commit f242cec into CommunityToolkit:main Jul 24, 2024
@Kay-STL Kay-STL deleted the fix/androidClearTintColorCrash branch July 24, 2024 23:44
@christian-strydom

Copy link
Copy Markdown

Thank you so much for this fix! This solved the last of my icon tint crashes.

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] IconTintColorBehavior crash on android.

4 participants