fix: Fix unhandled ObjectDisposedException in IconTintColorBehavior.ClearTintColor on Android#2012
Merged
TheCodeTraveler merged 4 commits intoJul 24, 2024
Merged
fix: Fix unhandled ObjectDisposedException in IconTintColorBehavior.ClearTintColor on Android#2012TheCodeTraveler merged 4 commits into
TheCodeTraveler merged 4 commits into
Conversation
Contributor
Author
|
@dotnet-policy-service agree company="Swallowing Technologies Limited" |
ScottyLightnin
approved these changes
Jul 11, 2024
Collaborator
|
@Kay-STL Could you update this PR to allow maintainers to edit it? I'd like to merge it but I first need to fix the merge conflict. |
Contributor
Author
|
@brminnick Can't enable maintainer access since GitHub doesn't allow it on organization repos, sorry - I've fixed the conflicts, will make sure to PR from a personal repo next time :) |
TheCodeTraveler
approved these changes
Jul 24, 2024
6 tasks
|
Thank you so much for this fix! This solved the last of my icon tint crashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of Change
Following #1883, which fixed an ObjectDisposedException crash in
ApplyTintColor, this PR fixes a crash inClearTintColorin the same manner. Other users have reported experiencing this in the replies to the original issue linked below.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Android only. Reproduced reliably in a production application on an Android 11 device, cannot reproduce after patch is applied.