Update nuget icon #146
Merged
Update nuget icon #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Tested in ContosoNotes and the nuget image shows up as expected when using the WCT PRs feed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The nuget icon is missing from the published preview packages on Nuget.
What is the new behavior?
I used WCT as a reference to update the property and targets files for the solution and add the icon.
I also noticed that after this change, the GraphPresenter was having a tough time deserializing some types, so I converted it from Newtonsoft Json to System.Text.Json as well to fix up the errors.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information