Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nuget package image #144

Closed
1 task
shweaver-MSFT opened this issue Aug 10, 2021 · 4 comments · Fixed by #146
Closed
1 task

Update nuget package image #144

shweaver-MSFT opened this issue Aug 10, 2021 · 4 comments · Fixed by #146
Labels
bug 🐛 Something isn't working Completed 🔥
Milestone

Comments

@shweaver-MSFT
Copy link
Member

shweaver-MSFT commented Aug 10, 2021

Describe the bug

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

There is no image shown when attempting to download the various nuget packages.

Expected behavior

The standard toolkit nuget image should be displayed, just like in the other WCT packages.

Screenshots

image

Environment

NuGet Package(s): All of them

Package Version(s): 7.1.0-preview1

Additional context

Issue first identified here: CommunityToolkit/WindowsCommunityToolkit#4100

@shweaver-MSFT shweaver-MSFT added the bug 🐛 Something isn't working label Aug 10, 2021
@ghost ghost added the needs triage 🔍 label Aug 10, 2021
@ghost
Copy link

ghost commented Aug 10, 2021

Hello shweaver-MSFT, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Aug 10, 2021
@shweaver-MSFT
Copy link
Member Author

@michael-hawker, the Directory.Build.props and Directory.Build.targets are pretty different than what I see in WCT. Do you think it's worth the effort to update the .props and .targets files to be more similar to how WCT does it? Or perhaps if it aint broke, don't fix it?

@michael-hawker
Copy link
Member

@shweaver-MSFT up to you. We recently restructured the props files in the Toolkit to pull out all the NuGet descriptive ones (you'll see the new common ones in the build directory).

If you want to tinker with it go-ahead, the main toolkit build has a bunch of extra stuff for VS designer stuff (which at some point we may want to copy over here anyway, though maybe after a source generator version works?).

Otherwise, just fixing the image is sufficient. It's always one of those things that's usually not super-important but still always worth the effort of doing. 😋

@shweaver-MSFT shweaver-MSFT mentioned this issue Aug 17, 2021
6 tasks
@ghost ghost added the In-PR 🚀 label Aug 17, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 Something isn't working Completed 🔥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants