Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated AAD support #121

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Integrated AAD support #121

merged 1 commit into from
Jul 6, 2021

Conversation

shweaver-MSFT
Copy link
Member

Fixes #116

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Currently WindowsProvider only supports authentication of consumer MSA accounts.

What is the new behavior?

This PR introduces new authentication support for organizational AAD accounts.

The WebAccountProviderType enum has a new Aad value that can be used to specify that only organizational accounts should be available to the user. Configuration in AAD is required to support authentication of organizational accounts.

I have also added a new WebAccountProviderType.Local option which uses whatever the active local account is. When using Local, configuration in AAD and a Store app association is required for the app to work consistently. If only MSA/AAD is meant to be supported, the appropriate WebAccountProviderType.Msa/Aad should be specified in the WebAccountProviderConfig provided during initialization.

Lastly, the WebAccountProviderType.All enum value has been updated to WebAccountProviderType.Any. Similar to Local, using Any requires configuration in Azure AAD as well as a Store app association in order to support which ever account types could be available.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Jul 6, 2021

Thanks shweaver-MSFT for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@shweaver-MSFT shweaver-MSFT merged commit 6e0901c into main Jul 6, 2021
@shweaver-MSFT shweaver-MSFT deleted the shweaver/aad-main branch July 6, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] WindowsProvider should support AAD login
1 participant