Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] WindowsProvider should support AAD login #116

Closed
shweaver-MSFT opened this issue Jun 11, 2021 · 0 comments · Fixed by #121
Closed

[Feature] WindowsProvider should support AAD login #116

shweaver-MSFT opened this issue Jun 11, 2021 · 0 comments · Fixed by #121

Comments

@shweaver-MSFT
Copy link
Member

Describe the problem this feature would solve

Currently WindowsProvider only supports MSA login. If a developer wants to support AAD, they must switch to use MsalProvider instead. The native WAM APIs support AAD login, the support just needs to be added.

Describe the solution

Enhance the WindowsProvider to handle AAD login and add an additional Aad value to the WebAccountProviderType enum.

By default, the WindowsProvider is already coded to handle All account types, so AAD should work without any additional configuration.

To ONLY target AAD login, WebAccountProviderType can be explicitly set using the new value, WebAccountProviderType.Aad.

@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Jun 11, 2021
@shweaver-MSFT shweaver-MSFT mentioned this issue Jun 11, 2021
17 tasks
@ghost ghost added the In-PR 🚀 label Jun 29, 2021
This was referenced Jun 29, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Jul 6, 2021
@shweaver-MSFT shweaver-MSFT modified the milestones: 7.1.0, 7.0.0 Jul 6, 2021
@shweaver-MSFT shweaver-MSFT modified the milestones: 7.0.0, 7.1.0 Jul 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant