log rotation #48
log rotation #48
Conversation
ltitanb
left a comment
ltitanb
left a comment
There was a problem hiding this comment.
just a couple of small changes needed, then gtg. Also make sure to test this locally to make sure everything works as expected
crates/common/src/module_names.rs
Outdated
| pub const BUILDER_LOG_NAME: &str = "builder_log"; | ||
| pub const CUSTOM_BOOST_NAME: &str = "custom_boost"; |
There was a problem hiding this comment.
let's remove these as they are just examples. For external modules, we should use the module id from the module config. Let's move PBS_MODULE_NAME and SIGNER_MODULE_NAME to config/log.rs
examples/builder_log/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| commit-boost = { path = "../../bin" } | ||
| cb-common = {path="../../crates/common"} |
There was a problem hiding this comment.
module should only ever import commit-boost and no "internal" crates, so we re-export everything needed in commit_boost::prelude::*. In this case seems that we only used it for the BUILDER_LOG_NAME. Given that this is just an example of a module, we should have them hardcoded in the repo, let's use the module id from the config, which all modules have
tbd: log rotation policy, simplify #47