Skip to content

Conversation

@mikirov
Copy link

@mikirov mikirov commented Aug 1, 2024

Adds a new binary and docker service that creates a new log file each day and retains log files for specified period (30 days by default).

@mikirov mikirov requested review from David-Petrov and ltitanb August 1, 2024 13:42
@mikirov mikirov self-assigned this Aug 1, 2024
@fbrv fbrv mentioned this pull request Aug 1, 2024
@fbrv
Copy link
Contributor

fbrv commented Aug 1, 2024

Hey @mikirov I think that the log rotation is a bit convoluted, I quickly opened a draft pr, #48 where you can see the usage of tracing_appender crate

@mikirov
Copy link
Author

mikirov commented Aug 2, 2024

Hey @mikirov I think that the log rotation is a bit convoluted, I quickly opened a draft pr, #48 where you can see the usage of tracing_appender crate

I like the simplicity and elegance of this approach. Let me close this PR and lets iterate on the one you opened

@mikirov
Copy link
Author

mikirov commented Aug 2, 2024

Will continue with the approach in #48

@mikirov mikirov closed this Aug 2, 2024
@ltitanb ltitanb deleted the feat/logs branch August 2, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants