Positionable: Common interface for canvas items #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor out duplicated code from Node
Node bounds once per render Cached results
- Removes margin param from getNodeOnPos - Removes margin param from getGroupOnPos - Hitboxes now uniform for render / mouse features - Simplifies code
webfiltered
force-pushed
the
positionable
branch
from
ef2d2f0
to
642f4fb
Compare
|
Requires Comfy-Org/ComfyUI_frontend#1405 |
|
Requires Comfy-Org/ComfyUI_frontend#1408 🐬 |
huchenlei
approved these changes
Nov 3, 2024
|
LGTM! This is such a huge leap forward on code structure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user-positionable canvas objects (groups, nodes, future-types) to share common features such as selection, arranging, and movement. Enables a more intuitive and natural UX.
Nodes
sizeis now a getter/setter backed by aRect; array ref can no longer be overwritten (in line withposand groups)is_selectedis now a legacy accessor forPositionable.selectedrenderArea- calculated once per frame, replacing repeat calls to getBounding (and onBounding callback)Groups
idto groupsget_X_OnPosfunctions