Update tests with precise node positions / sizes #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
webfiltered
commented
Nov 2, 2024
•
webfiltered
commented
- Enhances test accuracy
- Sets exact positions of nodes
- Screeenshots may require regeneration, as some values were 5-6 px off (resize teleports to cursor pos instead of drag offset for now)
- Fixes flaky tests (async / await & mouseover)
huchenlei
force-pushed
the
positionable-tests
branch
from
cf9f4e3
to
5addf39
Compare
huchenlei
added
the
New Browser Test Expectations
huchenlei
approved these changes
Nov 3, 2024
huchenlei
added
New Browser Test Expectations
|
Note: Diffs are pixel level:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.