Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snaps for Comfy 🫰 #239

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Snaps for Comfy 🫰 #239

merged 5 commits into from
Oct 30, 2024

Conversation

webfiltered
Copy link
Collaborator

Snaps for Comfy 🫰

Snaps connecting links to the target slot when hovering over nodes. An edge glow effect indicates that the link has snapped.

snaps-for-comfy.mp4
  • Uses existing hard-coded colours
  • Snap border indicator can be disabled
  • All features in this PR can be completely disabled via LiteGraph setting
  • Does not use animations

@webfiltered webfiltered marked this pull request as draft October 29, 2024 03:09
@webfiltered
Copy link
Collaborator Author

Requires:
#233
Comfy-Org/ComfyUI_frontend#1343

@webfiltered webfiltered marked this pull request as ready for review October 30, 2024 02:02
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fast widget convertion (When dragging link onto widget, auto convert the widget to input slot) feature is broken by this PR:
image

The feature was introduced by #180

@webfiltered
Copy link
Collaborator Author

This PR really highlights the gap between widgets when you're dragging a primitive connection over them. I'm thinking the gap should be removed.

@huchenlei huchenlei merged commit 95af20c into master Oct 30, 2024
4 checks passed
@huchenlei huchenlei deleted the snaps-for-comfy branch October 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants