Support allowing links to widgets #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
force-pushed
the
support-link-widget
branch
from
7b294cb
to
9155e77
Compare
huchenlei
approved these changes
Oct 1, 2024
webfiltered
added a commit
to webfiltered/litegraph.js
that referenced
this pull request
Oct 5, 2024
Support allowing links to widgets (Comfy-Org#180) c23e610
huchenlei
added a commit
that referenced
this pull request
Oct 7, 2024
* Convert litegraph.js to TS * Overhaul static litegraph.d.ts with updated types * Fix rename oversights and revert fix unused param - Some functions were broken by merging updated TS function signatures which included param renames - Removal of unused params does not belong in the TS conversion PR, and has been reverted * Remove legacy static .d.ts file * Add callback decl from #180 Support allowing links to widgets (#180) c23e610 * Convert NodeId to string | number Results in significantly less downstream changes, despite being a change from the old static file. --------- Co-authored-by: filtered <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a mechanism for creating links to widgets, for widget->input support by dragging instead of Right Click->Convert to Input
By default, this doesn't do anything,
getWidgetLinkTypeneeds to be implemented externally.Enables this:
https://github.com/user-attachments/assets/360013b2-d350-4fb0-bbce-cb860178d9ed
(Sorry poor quality)