Skip to content

[backport core/1.40] Fix essentials nodes not being marked core (#9287)#9574

Merged
christian-byrne merged 1 commit intocore/1.40from
backport-9287-to-core-1.40
Mar 8, 2026
Merged

[backport core/1.40] Fix essentials nodes not being marked core (#9287)#9574
christian-byrne merged 1 commit intocore/1.40from
backport-9287-to-core-1.40

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Mar 8, 2026 •
edited by sync-by-unito bot
Loading

Backport of #9287 to core/1.40. Snapshot PNG conflict resolved (accepted theirs).

Original PR: #9287
Pipeline ticket: 15e1f241-efaa-4fe5-88ca-4ccc7bfb3345

┆Issue is synchronized with this Notion page by Unito

@AustinMroz @christian-byrne
Fix essentials nodes not being marked core (#9287)
17674b1 
In adding an essentials cateogory for nodes, #8987 introduced a
regression where core nodes which are also essential are marked as being
from a `nodes` custom node instead of being marked core. Since the
essentials designation should pre-empt core and custom nodes can choose
to mark themself as essential, the getter for `isCoreNode` is updated to
instead repeat the existing check for if a node is core.

| Before | After |
| ------ | ----- |
| <img width="360" alt="before"
src="https://github.com/user-attachments/assets/f1b8bf80-d072-409a-a0f9-4837e1d11767"
/> | <img width="360" alt="after"
src="https://github.com/user-attachments/assets/14ff525b-9833-4e73-888f-791aff6cf531"/>|

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9287-Fix-essentials-nodes-not-being-marked-core-3146d73d365081fca2a0f8bdc2baf01a)
by [Unito](https://www.unito.io)
@christian-byrne christian-byrne requested a review from a team as a code owner March 8, 2026 02:26
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 8, 2026
@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 03/08/2026, 02:27:46 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: ❌ Deployment failed
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: ❌ Deployment failed

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1b5ab42a-4ad9-4da2-a406-92aefbb7bb53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-9287-to-core-1.40

Comment @coderabbitai help to get the list of available commands and usage tips.

@christian-byrne christian-byrne merged commit c5f42b0 into core/1.40 Mar 8, 2026
18 of 21 checks passed
@christian-byrne christian-byrne deleted the backport-9287-to-core-1.40 branch March 8, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christian-byrne @AustinMroz