Fix essentials nodes not being marked core#9287
Merged
AustinMroz merged 3 commits intomainfrom Feb 28, 2026
Merged
Conversation
dosubot
bot
added
the
size:XS
🎨 Storybook: ✅ Built — View Storybook |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCore-node detection was changed from an enum/type check to a module-prefix check: a new exported Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 549 passed, 0 failed · 4 flaky📊 Browser Reports
|
AustinMroz
added
needs-backport
📦 Bundle: 4.46 MB gzip 🟢 -52 BDetailsSummary
Category Glance App Entry Points — 17.9 kB (baseline 17.9 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.03 MB (baseline 1.03 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 435 kB (baseline 435 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 736 B (baseline 736 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 47 kB (baseline 47 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.55 MB (baseline 2.55 MB) • 🔴 +108 BStores, services, APIs, and repositories
Status: 13 added / 13 removed Utilities & Hooks — 55.5 kB (baseline 55.5 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 11 added / 11 removed Vendor & Third-Party — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.86 MB (baseline 7.86 MB) • ⚪ 0 BBundles that do not match a named category
Status: 52 added / 52 removed |
⚡ Performance Report
Raw data{
"timestamp": "2026-02-27T22:31:52.381Z",
"gitSha": "8105497c0211ad6b3f3f1329c53a86bbf0ac932e",
"branch": "austin/fix-is-core",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2059.827999999982,
"styleRecalcs": 125,
"styleRecalcDurationMs": 17.998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.32400000000007,
"heapDeltaBytes": -2588564
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2011.572000000001,
"styleRecalcs": 182,
"styleRecalcDurationMs": 55.641999999999996,
"layouts": 12,
"layoutDurationMs": 3.451,
"taskDurationMs": 1023.6890000000001,
"heapDeltaBytes": -1914588
},
{
"name": "dom-widget-clipping",
"durationMs": 571.4470000000063,
"styleRecalcs": 41,
"styleRecalcDurationMs": 13.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.447,
"heapDeltaBytes": 6816580
}
]
} |
Collaborator
Author
|
Manually updated the incorrect snapshot. The other test is a known unrelated flake. |
dosubot
bot
added
size:S
pythongosssss
approved these changes
Feb 27, 2026
|
|
DrJKL
pushed a commit
that referenced
this pull request
Feb 28, 2026
In adding an essentials cateogory for nodes, #8987 introduced a regression where core nodes which are also essential are marked as being from a `nodes` custom node instead of being marked core. Since the essentials designation should pre-empt core and custom nodes can choose to mark themself as essential, the getter for `isCoreNode` is updated to instead repeat the existing check for if a node is core. | Before | After | | ------ | ----- | | <img width="360" alt="before" src="https://github.com/user-attachments/assets/f1b8bf80-d072-409a-a0f9-4837e1d11767" /> | <img width="360" alt="after" src="https://github.com/user-attachments/assets/14ff525b-9833-4e73-888f-791aff6cf531"/>| ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9287-Fix-essentials-nodes-not-being-marked-core-3146d73d365081fca2a0f8bdc2baf01a) by [Unito](https://www.unito.io)
christian-byrne
pushed a commit
that referenced
this pull request
Mar 8, 2026
In adding an essentials cateogory for nodes, #8987 introduced a regression where core nodes which are also essential are marked as being from a `nodes` custom node instead of being marked core. Since the essentials designation should pre-empt core and custom nodes can choose to mark themself as essential, the getter for `isCoreNode` is updated to instead repeat the existing check for if a node is core. | Before | After | | ------ | ----- | | <img width="360" alt="before" src="https://github.com/user-attachments/assets/f1b8bf80-d072-409a-a0f9-4837e1d11767" /> | <img width="360" alt="after" src="https://github.com/user-attachments/assets/14ff525b-9833-4e73-888f-791aff6cf531"/>| ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9287-Fix-essentials-nodes-not-being-marked-core-3146d73d365081fca2a0f8bdc2baf01a) by [Unito](https://www.unito.io)
christian-byrne
added a commit
that referenced
this pull request
Mar 8, 2026
… (#9574) Backport of #9287 to core/1.40. Snapshot PNG conflict resolved (accepted theirs). **Original PR:** #9287 **Pipeline ticket:** 15e1f241-efaa-4fe5-88ca-4ccc7bfb3345 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9574-backport-core-1-40-Fix-essentials-nodes-not-being-marked-core-9287-31d6d73d365081a48f01f6cb2ef00619) by [Unito](https://www.unito.io) Co-authored-by: AustinMroz <austin@comfy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In adding an essentials cateogory for nodes, #8987 introduced a regression where core nodes which are also essential are marked as being from a
nodescustom node instead of being marked core. Since the essentials designation should pre-empt core and custom nodes can choose to mark themself as essential, the getter forisCoreNodeis updated to instead repeat the existing check for if a node is core.┆Issue is synchronized with this Notion page by Unito