Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/locales/ar/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "تنزيل",
"exportWorkflow": "تصدير سير العمل",
"insertAsNodeInWorkflow": "إدراج كعقدة في سير العمل",
"addToWorkflow": "إدراج كعقدة في سير العمل",
"inspect": "تفقد الأصل",
"more": "خيارات أخرى",
"moreOptions": "خيارات أخرى",
Expand Down
1 change: 1 addition & 0 deletions src/locales/en/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -2631,6 +2631,7 @@
"moreOptions": "More options",
"seeMoreOutputs": "See more outputs",
"insertAsNodeInWorkflow": "Insert as node in workflow",
"addToWorkflow": "Insert as node in workflow",
"download": "Download",
"openWorkflow": "Open as workflow in new tab",
"exportWorkflow": "Export workflow",
Expand Down
1 change: 1 addition & 0 deletions src/locales/es/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "Descargar",
"exportWorkflow": "Exportar flujo de trabajo",
"insertAsNodeInWorkflow": "Insertar como nodo en el flujo de trabajo",
"addToWorkflow": "Insertar como nodo en el flujo de trabajo",
"inspect": "Inspeccionar recurso",
Comment on lines 1438 to 1440
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Avoid manual updates to non‑English locale files.

This repo auto‑generates non‑en locale files on release, so changes to src/locales/es/main.json will be overwritten and shouldn’t be made in PRs. Please keep only the src/locales/en/main.json change and remove this entry here. Based on learnings: “locale files other than src/locales/en/main.json are generated automatically on every release… manual updates to other locale files … are not required and should not be suggested in reviews.”

🧹 Proposed removal
-      "addToWorkflow": "Insertar como nodo en el flujo de trabajo",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"insertAsNodeInWorkflow": "Insertar como nodo en el flujo de trabajo",
"addToWorkflow": "Insertar como nodo en el flujo de trabajo",
"inspect": "Inspeccionar recurso",
"insertAsNodeInWorkflow": "Insertar como nodo en el flujo de trabajo",
"inspect": "Inspeccionar recurso",
🤖 Prompt for AI Agents
In `@src/locales/es/main.json` around lines 1438 - 1440, Remove the manual Spanish
translations for the keys "insertAsNodeInWorkflow", "addToWorkflow", and
"inspect" from the non-English locale file (they were added in
src/locales/es/main.json) because non-English locale files are auto-generated;
keep your changes only in the English source (the "en" main.json) and
revert/delete these entries from the Spanish file so they won’t be overwritten
on release.

"more": "Más opciones",
"moreOptions": "Más opciones",
Expand Down
1 change: 1 addition & 0 deletions src/locales/fa/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "دانلود",
"exportWorkflow": "خروجی گرفتن از workflow",
"insertAsNodeInWorkflow": "افزودن به عنوان node در workflow",
"addToWorkflow": "افزودن به عنوان node در workflow",
"inspect": "بررسی دارایی",
"more": "گزینه‌های بیشتر",
"moreOptions": "گزینه‌های بیشتر",
Expand Down
1 change: 1 addition & 0 deletions src/locales/fr/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "Télécharger",
"exportWorkflow": "Exporter le flux de travail",
"insertAsNodeInWorkflow": "Insérer comme nœud dans le workflow",
"addToWorkflow": "Insérer comme nœud dans le workflow",
"inspect": "Inspecter l’actif",
"more": "Plus d’options",
"moreOptions": "Plus d’options",
Expand Down
1 change: 1 addition & 0 deletions src/locales/ja/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "ダウンロード",
"exportWorkflow": "ワークフローをエクスポート",
"insertAsNodeInWorkflow": "ワークフローにノードとして挿入",
"addToWorkflow": "ワークフローにノードとして挿入",
"inspect": "アセットを確認",
"more": "その他のオプション",
"moreOptions": "その他のオプション",
Expand Down
1 change: 1 addition & 0 deletions src/locales/ko/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "다운로드",
"exportWorkflow": "워크플로우 내보내기",
"insertAsNodeInWorkflow": "워크플로우에 노드로 삽입",
"addToWorkflow": "워크플로우에 노드로 삽입",
"inspect": "에셋 검사",
"more": "더 많은 옵션",
"moreOptions": "더 많은 옵션",
Expand Down
1 change: 1 addition & 0 deletions src/locales/pt-BR/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "Baixar",
"exportWorkflow": "Exportar fluxo de trabalho",
"insertAsNodeInWorkflow": "Inserir como nó no fluxo de trabalho",
"addToWorkflow": "Inserir como nó no fluxo de trabalho",
"inspect": "Inspecionar recurso",
"more": "Mais opções",
"moreOptions": "Mais opções",
Expand Down
1 change: 1 addition & 0 deletions src/locales/ru/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "Скачать",
"exportWorkflow": "Экспортировать рабочий процесс",
"insertAsNodeInWorkflow": "Вставить как узел в рабочий процесс",
"addToWorkflow": "Вставить как узел в рабочий процесс",
"inspect": "Просмотреть ресурс",
"more": "Больше опций",
"moreOptions": "Больше опций",
Expand Down
1 change: 1 addition & 0 deletions src/locales/tr/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "İndir",
"exportWorkflow": "İş akışını dışa aktar",
"insertAsNodeInWorkflow": "Çalışma akışına düğüm olarak ekle",
"addToWorkflow": "Çalışma akışına düğüm olarak ekle",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Manual update to auto-generated locale file is unnecessary.

According to project conventions, locale files other than src/locales/en/main.json are generated automatically on every release. Only the English locale file needs manual updates—other locale files (including Turkish) will be auto-generated from it.

This manual change may be overwritten during the next release cycle. Consider removing changes to all non-English locale files and ensuring only src/locales/en/main.json contains the new addToWorkflow key.

Based on learnings: "Locale files other than src/locales/en/main.json are generated automatically on every release. Developers only need to add English (en) key/values in src/locales/en/main.json when making PRs."

🤖 Prompt for AI Agents
In `@src/locales/tr/main.json` at line 1439, Remove the manual addition of the
"addToWorkflow" key from the Turkish locale main.json (non-English) and instead
add or ensure that the new "addToWorkflow" entry exists only in the English
locale main.json; revert the change in the Turkish file so non-English locale
files remain auto-generated and will be populated from the English source during
release.

"inspect": "Varlığı incele",
"more": "Daha fazla seçenek",
"moreOptions": "Daha fazla seçenek",
Expand Down
1 change: 1 addition & 0 deletions src/locales/zh-TW/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "下載",
"exportWorkflow": "匯出工作流程",
"insertAsNodeInWorkflow": "插入為工作流程節點",
"addToWorkflow": "插入為工作流程節點",
"inspect": "檢查資產",
"more": "更多選項",
"moreOptions": "更多選項",
Expand Down
1 change: 1 addition & 0 deletions src/locales/zh/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -1436,6 +1436,7 @@
"download": "下载",
"exportWorkflow": "导出工作流",
"insertAsNodeInWorkflow": "作为节点插入到工作流",
"addToWorkflow": "作为节点插入到工作流",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Remove manual changes to auto-generated locale file.

According to repository conventions, locale files other than src/locales/en/main.json are generated automatically on every release. Manual updates to non-English locale files (zh, ar, fr, ja, ko, ru, etc.) are not required.

Only add the new key to src/locales/en/main.json. The Chinese translation will be auto-generated during the next release.

Based on learnings: "In the Comfy-Org/ComfyUI_frontend repository, locale files other than src/locales/en/main.json are generated automatically on every release. Developers only need to add English (en) key/values in src/locales/en/main.json when making PRs."

🤖 Prompt for AI Agents
In `@src/locales/zh/main.json` at line 1439, Remove the manual addition of the
"addToWorkflow" key from the Chinese locale file (zh main.json); per repo
conventions non-English locale files are auto-generated, so revert this change
in the zh main.json and instead ensure the new key "addToWorkflow" is added only
to the English main.json (en) so the translation will be generated automatically
on release.

"inspect": "查看资产",
"more": "更多设置",
"moreOptions": "更多选项",
Expand Down