fix: add missing media asset addToWorkflow localization #8437
Conversation
dosubot
bot
added
the
size:S
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/29/2026, 10:09:11 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests: ✅ PassedResults: 507 passed, 0 failed, 0 flaky, 8 skipped (Total: 515) 📊 Browser Reports
|
benceruleanlu
added
needs-backport
📝 WalkthroughWalkthroughA new translation key Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
bot
requested review from
KarryCharon,
Yorha4D,
christian-byrne and
shinshin86
|
I think it needs all locales because it's a backport and there won't be another release since cloud uses hashes? Regardless, it should be fine either way. |
There was a problem hiding this comment.
Pull request overview
This PR adds the missing localization key mediaAsset.actions.addToWorkflow to prevent displaying raw i18n keys in the Media Assets context menu across all supported locales.
Changes:
- Added
addToWorkflowtranslation key to 12 locale files (ar, en, es, fa, fr, ja, ko, pt-BR, ru, tr, zh-TW, zh) - Each translation mirrors the existing
insertAsNodeInWorkflowvalue to maintain consistency
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/locales/en/main.json | Added English translation "Insert as node in workflow" |
| src/locales/ar/main.json | Added Arabic translation matching insertAsNodeInWorkflow |
| src/locales/es/main.json | Added Spanish translation matching insertAsNodeInWorkflow |
| src/locales/fa/main.json | Added Farsi translation matching insertAsNodeInWorkflow |
| src/locales/fr/main.json | Added French translation matching insertAsNodeInWorkflow |
| src/locales/ja/main.json | Added Japanese translation matching insertAsNodeInWorkflow |
| src/locales/ko/main.json | Added Korean translation matching insertAsNodeInWorkflow |
| src/locales/pt-BR/main.json | Added Brazilian Portuguese translation matching insertAsNodeInWorkflow |
| src/locales/ru/main.json | Added Russian translation matching insertAsNodeInWorkflow |
| src/locales/tr/main.json | Added Turkish translation matching insertAsNodeInWorkflow |
| src/locales/zh/main.json | Added Simplified Chinese translation matching insertAsNodeInWorkflow |
| src/locales/zh-TW/main.json | Added Traditional Chinese translation matching insertAsNodeInWorkflow |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 26 kB (baseline 26 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 974 kB (baseline 974 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 471 kB (baseline 471 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.89 kB (baseline 2.89 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.7 MB (baseline 2.7 MB) • 🔴 +1 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 25.3 kB (baseline 25.3 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.1 MB (baseline 7.1 MB) • 🔴 +566 BBundles that do not match a named category
Status: 47 added / 47 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (6)
src/locales/ja/main.json (1)
1433-1440: Do not manually edit generated locale files.Non-English locale files are generated on release, so this change should live only in
src/locales/en/main.jsonand be propagated automatically. Please remove the manual edit here.🧹 Suggested removal
"insertAsNodeInWorkflow": "ワークフローにノードとして挿入", - "addToWorkflow": "ワークフローにノードとして挿入",Based on learnings: In the Comfy-Org/ComfyUI_frontend repository, locale files other than
src/locales/en/main.jsonare generated automatically on every release. Developers only need to add English (en) key/values insrc/locales/en/main.jsonwhen making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.src/locales/fr/main.json (1)
1433-1440: Do not manually edit generated locale files.Non-English locale files are generated on release, so this change should live only in
src/locales/en/main.jsonand be propagated automatically. Please remove the manual edit here.🧹 Suggested removal
"insertAsNodeInWorkflow": "Insérer comme nœud dans le workflow", - "addToWorkflow": "Insérer comme nœud dans le workflow",Based on learnings: In the Comfy-Org/ComfyUI_frontend repository, locale files other than
src/locales/en/main.jsonare generated automatically on every release. Developers only need to add English (en) key/values insrc/locales/en/main.jsonwhen making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.src/locales/ko/main.json (1)
1433-1440: Remove manual edits from generated locale files.Non‑English locale files are auto-generated; this manual addition will be overwritten. Please revert this change and keep the new key only in the English locale.
🧹 Suggested fix
"insertAsNodeInWorkflow": "워크플로우에 노드로 삽입", - "addToWorkflow": "워크플로우에 노드로 삽입", "inspect": "에셋 검사",Based on learnings: "In the Comfy-Org/ComfyUI_frontend repository, locale files other than
src/locales/en/main.jsonare generated automatically on every release. Developers only need to add English (en) key/values insrc/locales/en/main.jsonwhen making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews."src/locales/zh-TW/main.json (1)
1433-1440: Remove manual edits from generated locale files.Non‑English locale files are auto-generated; this manual addition will be overwritten. Please revert this change and keep the new key only in the English locale.
🧹 Suggested fix
"insertAsNodeInWorkflow": "插入為工作流程節點", - "addToWorkflow": "插入為工作流程節點", "inspect": "檢查資產",Based on learnings: "In the Comfy-Org/ComfyUI_frontend repository, locale files other than
src/locales/en/main.jsonare generated automatically on every release. Developers only need to add English (en) key/values insrc/locales/en/main.jsonwhen making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews."src/locales/pt-BR/main.json (1)
1433-1440: Remove manual pt-BR locale edit; add key only in en locale.Non‑en locale files are auto‑generated on release, so manual updates here will be overwritten. Please move the new key to
src/locales/en/main.jsononly and drop this change from pt‑BR.🧹 Suggested diff
- "addToWorkflow": "Inserir como nó no fluxo de trabalho",Based on learnings: “locale files other than
src/locales/en/main.jsonare generated automatically on every release… only add English (en) key/values insrc/locales/en/main.json.”src/locales/ru/main.json (1)
1433-1440: Remove manual ru locale edit; add key only in en locale.Non‑en locale files are auto‑generated on release, so manual updates here will be overwritten. Please move the new key to
src/locales/en/main.jsononly and drop this change from ru.🧹 Suggested diff
- "addToWorkflow": "Вставить как узел в рабочий процесс",Based on learnings: “locale files other than
src/locales/en/main.jsonare generated automatically on every release… only add English (en) key/values insrc/locales/en/main.json.”
🤖 Fix all issues with AI agents
In `@src/locales/es/main.json`:
- Around line 1438-1440: Remove the manual Spanish translations for the keys
"insertAsNodeInWorkflow", "addToWorkflow", and "inspect" from the non-English
locale file (they were added in src/locales/es/main.json) because non-English
locale files are auto-generated; keep your changes only in the English source
(the "en" main.json) and revert/delete these entries from the Spanish file so
they won’t be overwritten on release.
In `@src/locales/tr/main.json`:
- Line 1439: Remove the manual addition of the "addToWorkflow" key from the
Turkish locale main.json (non-English) and instead add or ensure that the new
"addToWorkflow" entry exists only in the English locale main.json; revert the
change in the Turkish file so non-English locale files remain auto-generated and
will be populated from the English source during release.
In `@src/locales/zh/main.json`:
- Line 1439: Remove the manual addition of the "addToWorkflow" key from the
Chinese locale file (zh main.json); per repo conventions non-English locale
files are auto-generated, so revert this change in the zh main.json and instead
ensure the new key "addToWorkflow" is added only to the English main.json (en)
so the translation will be generated automatically on release.
| "insertAsNodeInWorkflow": "Insertar como nodo en el flujo de trabajo", | ||
| "addToWorkflow": "Insertar como nodo en el flujo de trabajo", | ||
| "inspect": "Inspeccionar recurso", |
There was a problem hiding this comment.
Avoid manual updates to non‑English locale files.
This repo auto‑generates non‑en locale files on release, so changes to src/locales/es/main.json will be overwritten and shouldn’t be made in PRs. Please keep only the src/locales/en/main.json change and remove this entry here. Based on learnings: “locale files other than src/locales/en/main.json are generated automatically on every release… manual updates to other locale files … are not required and should not be suggested in reviews.”
🧹 Proposed removal
- "addToWorkflow": "Insertar como nodo en el flujo de trabajo",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "insertAsNodeInWorkflow": "Insertar como nodo en el flujo de trabajo", | |
| "addToWorkflow": "Insertar como nodo en el flujo de trabajo", | |
| "inspect": "Inspeccionar recurso", | |
| "insertAsNodeInWorkflow": "Insertar como nodo en el flujo de trabajo", | |
| "inspect": "Inspeccionar recurso", |
🤖 Prompt for AI Agents
In `@src/locales/es/main.json` around lines 1438 - 1440, Remove the manual Spanish
translations for the keys "insertAsNodeInWorkflow", "addToWorkflow", and
"inspect" from the non-English locale file (they were added in
src/locales/es/main.json) because non-English locale files are auto-generated;
keep your changes only in the English source (the "en" main.json) and
revert/delete these entries from the Spanish file so they won’t be overwritten
on release.
| "download": "İndir", | ||
| "exportWorkflow": "İş akışını dışa aktar", | ||
| "insertAsNodeInWorkflow": "Çalışma akışına düğüm olarak ekle", | ||
| "addToWorkflow": "Çalışma akışına düğüm olarak ekle", |
There was a problem hiding this comment.
Manual update to auto-generated locale file is unnecessary.
According to project conventions, locale files other than src/locales/en/main.json are generated automatically on every release. Only the English locale file needs manual updates—other locale files (including Turkish) will be auto-generated from it.
This manual change may be overwritten during the next release cycle. Consider removing changes to all non-English locale files and ensuring only src/locales/en/main.json contains the new addToWorkflow key.
Based on learnings: "Locale files other than src/locales/en/main.json are generated automatically on every release. Developers only need to add English (en) key/values in src/locales/en/main.json when making PRs."
🤖 Prompt for AI Agents
In `@src/locales/tr/main.json` at line 1439, Remove the manual addition of the
"addToWorkflow" key from the Turkish locale main.json (non-English) and instead
add or ensure that the new "addToWorkflow" entry exists only in the English
locale main.json; revert the change in the Turkish file so non-English locale
files remain auto-generated and will be populated from the English source during
release.
| "download": "下载", | ||
| "exportWorkflow": "导出工作流", | ||
| "insertAsNodeInWorkflow": "作为节点插入到工作流", | ||
| "addToWorkflow": "作为节点插入到工作流", |
There was a problem hiding this comment.
Remove manual changes to auto-generated locale file.
According to repository conventions, locale files other than src/locales/en/main.json are generated automatically on every release. Manual updates to non-English locale files (zh, ar, fr, ja, ko, ru, etc.) are not required.
Only add the new key to src/locales/en/main.json. The Chinese translation will be auto-generated during the next release.
Based on learnings: "In the Comfy-Org/ComfyUI_frontend repository, locale files other than src/locales/en/main.json are generated automatically on every release. Developers only need to add English (en) key/values in src/locales/en/main.json when making PRs."
🤖 Prompt for AI Agents
In `@src/locales/zh/main.json` at line 1439, Remove the manual addition of the
"addToWorkflow" key from the Chinese locale file (zh main.json); per repo
conventions non-English locale files are auto-generated, so revert this change
in the zh main.json and instead ensure the new key "addToWorkflow" is added only
to the English main.json (en) so the translation will be generated automatically
on release.
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
How do I reproduce the issue? All the user-facing strings seem correct to me on testcloud.comfy.org
More context in slack, but this has been solved |
4 participants
Motivation
mediaAsset.actions.addToWorkflowinstead of localized text when the translated entry was missing.Description
mediaAsset.actions.addToWorkflowto theactionssection insrc/locales/*/main.jsonto mirror the existinginsertAsNodeInWorkflowlabel.en,ar,es,fa,fr,ja,ko,pt-BR,ru,tr,zh-TW, andzh.Testing
pnpm formatto normalize formatting and it completed successfully.pnpm lintand it finished with no warnings or errors.pnpm typecheck(vue-tsc --noEmit) and it completed with no type errors.Codex Task
┆Issue is synchronized with this Notion page by Unito