Skip to content

[backport cloud/1.37] [bugfix] Fix inconsistent menu icon sizes in ComfyMenuButton#8288

Merged
DrJKL merged 1 commit intocloud/1.37from
backport-8268-to-cloud-1.37
Jan 24, 2026
Merged

[backport cloud/1.37] [bugfix] Fix inconsistent menu icon sizes in ComfyMenuButton#8288
DrJKL merged 1 commit intocloud/1.37from
backport-8268-to-cloud-1.37

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 24, 2026

Backport of #8268 to cloud/1.37

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

## Summary
Replace MDI font icons with Tailwind Iconify (Lucide) icons for Settings
and Manage Extensions menu items to fix size inconsistency with Browse
Template icon.

## Changes
- **What**: MDI font icons (`mdi mdi-cog-outline`, `mdi
mdi-puzzle-outline`) rendered at 14px (`text-sm` font-size), while the
Tailwind Iconify icon (`icon-[comfy--template]`) rendered at ~16.8px due
to `scale: 1.2` in the Tailwind plugin config. Replaced with
`icon-[lucide--settings]` and `icon-[lucide--puzzle]` so all icons use
the same rendering pipeline.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 24, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 24, 2026 02:53
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 24, 2026
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 24, 2026
@github-actions
Copy link

github-actions bot commented Jan 24, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/24/2026, 02:54:52 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 24, 2026

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 502 passed, 0 failed, 2 flaky, 8 skipped (Total: 512)

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 492 / ❌ 0 / ⚠️ 1 / ⏭️ 8)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@DrJKL DrJKL merged commit 4c3c61f into cloud/1.37 Jan 24, 2026
37 checks passed
@DrJKL DrJKL deleted the backport-8268-to-cloud-1.37 branch January 24, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants