[bugfix] Fix inconsistent menu icon sizes in ComfyMenuButton#8268
Merged
viva-jinyi merged 1 commit intomainfrom Jan 23, 2026
Merged
[bugfix] Fix inconsistent menu icon sizes in ComfyMenuButton#8268viva-jinyi merged 1 commit intomainfrom
viva-jinyi merged 1 commit intomainfrom
Conversation
viva-jinyi
added
the
verified bug
viva-jinyi
added
area:topbar-menu
verified bug
dosubot
bot
added
the
size:XS
Contributor
📝 WalkthroughWalkthroughUpdated icon styling in the ComfyMenuButton Vue component, converting two menu item icons from mdi-style to lucide-style classes. The "settings" and "manage-extensions" entries now reference lucide icons instead of Material Design Icons, with no behavioral changes to commands or event handlers. Changes
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/23/2026, 06:42:22 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.7 kB (baseline 22.7 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 949 kB (baseline 949 kB) • 🔴 +3 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 440 kB (baseline 440 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.17 MB (baseline 3.17 MB) • 🔴 +1 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 24 kB (baseline 24 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.36 MB (baseline 6.36 MB) • 🟢 -192 BBundles that do not match a named category
Status: 30 added / 30 removed |
christian-byrne
approved these changes
Jan 23, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/sidebar/ComfyMenuButton.vue (1)
244-244: Consider updating the Help icon for full consistency.This line still assigns an MDI icon (
mdi mdi-help-circle-outline) to the Help menu item, which will exhibit the same size inconsistency that this PR addresses for Settings and Manage Extensions. Consider updating it toicon-[lucide--circle-help]for uniform icon rendering.♻️ Suggested change
- items[helpIndex].icon = 'mdi mdi-help-circle-outline' + items[helpIndex].icon = 'icon-[lucide--circle-help]'
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2026
## Summary Replace MDI font icons with Tailwind Iconify (Lucide) icons for Settings and Manage Extensions menu items to fix size inconsistency with Browse Template icon. ## Changes - **What**: MDI font icons (`mdi mdi-cog-outline`, `mdi mdi-puzzle-outline`) rendered at 14px (`text-sm` font-size), while the Tailwind Iconify icon (`icon-[comfy--template]`) rendered at ~16.8px due to `scale: 1.2` in the Tailwind plugin config. Replaced with `icon-[lucide--settings]` and `icon-[lucide--puzzle]` so all icons use the same rendering pipeline.
Member
|
@viva-jinyi Successfully backported to #8288 |
github-actions
bot
removed
the
needs-backport
DrJKL
pushed a commit
that referenced
this pull request
Jan 24, 2026
…mfyMenuButton (#8288) Backport of #8268 to `cloud/1.37` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8288-backport-cloud-1-37-bugfix-Fix-inconsistent-menu-icon-sizes-in-ComfyMenuButton-2f26d73d365081f4a184dd5c98ec736d) by [Unito](https://www.unito.io) Co-authored-by: Jin Yi <jin12cc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace MDI font icons with Tailwind Iconify (Lucide) icons for Settings and Manage Extensions menu items to fix size inconsistency with Browse Template icon.
Changes
mdi mdi-cog-outline,mdi mdi-puzzle-outline) rendered at 14px (text-smfont-size), while the Tailwind Iconify icon (icon-[comfy--template]) rendered at ~16.8px due toscale: 1.2in the Tailwind plugin config. Replaced withicon-[lucide--settings]andicon-[lucide--puzzle]so all icons use the same rendering pipeline.Review Focus
┆Issue is synchronized with this Notion page by Unito