-
Notifications
You must be signed in to change notification settings - Fork 491
feat: add settings option to always show advanced widgets on all nodes #8244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add settings option to always show advanced widgets on all nodes #8244
Conversation
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/23/2026, 05:53:14 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Tests:
|
📝 WalkthroughWalkthroughThis pull request introduces a global setting to always display advanced widgets across all nodes. It refactors widget list computation into a shared utility function and integrates the new setting throughout the right-side panel components and node widget rendering to centralize advanced widget visibility logic. Changes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.7 kB (baseline 22.7 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 951 kB (baseline 949 kB) • 🔴 +1.8 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 440 kB (baseline 440 kB) • 🟢 -8 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.83 kB (baseline 2.83 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 33.7 kB (baseline 33.7 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 3.17 MB (baseline 3.17 MB) • 🔴 +286 BStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 24 kB (baseline 24 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.7 MB (baseline 10.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.36 MB (baseline 6.36 MB) • 🟢 -192 BBundles that do not match a named category
Status: 30 added / 30 removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/renderer/extensions/vueNodes/components/LGraphNode.vue`:
- Around line 133-142: The SubgraphNode branch in the
showAdvancedState/internalState setter never assigns the new value back to
internalState, so clicking the toggle never flips off; update the setter in the
SubgraphNode branch (the computed setter that handles
showAdvancedState/internalState) to include internalState = value when node is a
SubgraphNode so the internal state actually toggles and the label switches
between show/hide.
christian-byrne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to support the hide/show of widgets when in Litegraph mode (non-Vue), which will allow us to simplify this PR considerably.
…ow-advanced-widgets-on-all-nodes
…ow-advanced-widgets-on-all-nodes
Okay, I have removed the related code. |
Solved issue:
Currently, the display status of advanced widgets can only be set individually for each node, but users would like to have a global switch to always display all advanced widgets.
I also adjusted some related code to solve the issue of code duplication.
┆Issue is synchronized with this Notion page by Unito