feat(panel): add collapsible Advanced Inputs section for widgets marked advanced #8146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughAdds computed properties to identify and label advanced widgets grouped by node, and extends the template to render a collapsible advanced Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/20/2026, 09:29:33 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.4 kB (baseline 22.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.02 MB (baseline 1.02 MB) • 🔴 +1.29 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 430 kB (baseline 430 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Editors & Dialogs — 2.8 kB (baseline 2.8 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
UI Components — 32.8 kB (baseline 32.8 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 3.04 MB (baseline 3.04 MB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 18.7 kB (baseline 18.7 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 10.4 MB (baseline 10.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 6.25 MB (baseline 6.25 MB) • ⚪ 0 BBundles that do not match a named category
|
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
dosubot
bot
added
the
size:M
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/rightSidePanel/parameters/TabNormalInputs.vue`:
- Around line 116-120: The v-if condition on the <template> is redundant because
advancedWidgetsSectionDataList is already filtered to exclude empty widget
groups; replace the current .some(({ widgets }) => widgets.length > 0)
expression with a simple check of advancedWidgetsSectionDataList's
presence/length (e.g., advancedWidgetsSectionDataList &&
advancedWidgetsSectionDataList.length > 0 or just
advancedWidgetsSectionDataList.length) to simplify the condition; update the
template v-if that references advancedWidgetsSectionDataList accordingly (locate
the template block around the v-if and the filter logic that builds
advancedWidgetsSectionDataList).
Addresses coderabbit review comment:
- advancedWidgetsSectionDataList already filters out empty widget groups
- .some(({ widgets }) => widgets.length > 0) is redundant, use .length > 0
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/rightSidePanel/parameters/TabNormalInputs.vue`:
- Around line 114-124: The advanced sections render uses SectionWidgets with a
fixed label and missing locate button; update the advancedWidgetsSectionDataList
rendering so its SectionWidgets receives the same conditional label behavior as
the normal widgets (set label to undefined when multiple nodes are selected so
SectionWidgets can show per-node titles) and add the show-locate-button prop
binding to enable locating the node; reference the
advancedWidgetsSectionDataList loop and SectionWidgets component to apply these
changes.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/components/rightSidePanel/parameters/TabNormalInputs.vue`:
- Around line 78-82: The computed advancedLabel currently ignores
mustShowNodeTitle; update the advancedLabel computed to mirror the normal label
logic by returning undefined when isMultipleNodesSelected.value is true OR
mustShowNodeTitle.value is true, and only return
t('rightSidePanel.advancedInputs') when a single node is selected and
mustShowNodeTitle is false; also ensure the translation key
'rightSidePanel.advancedInputs' is used (it already exists in locales).
- Around line 120-130: The advanced widgets block should be hidden while the
user is performing a search: update the template where
advancedWidgetsSectionDataList is rendered (the SectionWidgets instance) to
include a search guard, e.g. change the v-if to check both
advancedWidgetsSectionDataList.length > 0 and that searching is false
(v-if="advancedWidgetsSectionDataList.length > 0 && !isSearching"); if
TabNormalInputs.vue does not already expose a search state, add a computed prop
named isSearching that returns Boolean(searchQuery || searchText) using the
existing search prop/state used for filtering normal widgets (locate the
component property used for filtering and reference it inside isSearching), and
ensure SectionWidgets, advancedLabel and isMultipleNodesSelected props remain
unchanged.
godwiniheuwa
pushed a commit
to godwiniheuwa/ComfyUI_frontend
that referenced
this pull request
Jan 22, 2026
…ed advanced (Comfy-Org#8146) Adds a collapsible 'Advanced Inputs' section to the right-side panel that displays widgets marked with `options.advanced = true`. <img width="1903" height="875" alt="image" src="https://github.com/user-attachments/assets/5f76e680-7904-4c43-b42b-1b98f8f78458" /> ## Changes - Filters normal widgets to exclude advanced ones - Adds new `advancedWidgetsSectionDataList` computed for advanced widgets - Renders a collapsible section (collapsed by default) for advanced widgets ## Related - Backend PR that adds `advanced` flag: Comfy-Org/ComfyUI#11939 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8146-feat-panel-add-collapsible-Advanced-Inputs-section-for-widgets-marked-advanced-2ec6d73d36508120af1af27110a6fb96) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Rizumu Ayaka <rizumu@ayaka.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a collapsible 'Advanced Inputs' section to the right-side panel that displays widgets marked with
options.advanced = true.Changes
advancedWidgetsSectionDataListcomputed for advanced widgetsRelated
advancedflag: feat: add advanced parameter to Input classes for advanced widgets support ComfyUI#11939┆Issue is synchronized with this Notion page by Unito