Skip to content

refactor: use orderBy for queue list sorting #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benceruleanlu merged 2 commits into from
Jan 22, 2026
Merged

refactor: use orderBy for queue list sorting #8228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96acab9
fix: use orderBy for queue list sorting
benceruleanlu Jan 22, 2026
dcc91bf
Merge branch 'main' into chore/queue-orderby
DrJKL Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/composables/queue/useJobList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { orderBy } from 'es-toolkit/array'
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for orderBy should use 'es-toolkit/compat' instead of 'es-toolkit/array' for consistency with the existing codebase. The file useRegistrySearch.ts already imports orderBy from 'es-toolkit/compat', and using the same import path ensures consistency across the project.

Suggested change
import { orderBy } from 'es-toolkit/array'
import { orderBy } from 'es-toolkit/compat'

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@benceruleanlu benceruleanlu Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we can't use array

import { computed, onUnmounted, ref, watch } from 'vue'
import { useI18n } from 'vue-i18n'

Expand Down Expand Up @@ -205,10 +206,7 @@ export function useJobList() {
...queueStore.runningTasks,
...queueStore.historyTasks
]
return all.sort((a, b) => {
const delta = mostRecentTimestamp(b) - mostRecentTimestamp(a)
return delta === 0 ? 0 : delta
})
return orderBy(all, [mostRecentTimestamp], ['desc'])
})

const tasksWithJobState = computed<TaskWithState[]>(() =>
Expand Down