refactor: use orderBy for queue list sorting #8228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/22/2026, 03:42:52 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Contributor
📝 WalkthroughWalkthroughThe change refactors task sorting in Changes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the queue list sorting implementation to use es-toolkit's orderBy utility function instead of a custom Array.sort comparator. The change aligns with the project's dependency on es-toolkit for utility functions and makes the sorting intent more explicit.
Changes:
- Replaced
Array.sortwith custom comparator withorderByfrom es-toolkit - Added import for
orderByfrom es-toolkit/array - Maintained existing sorting behavior (descending by most recent timestamp)
| @@ -1,3 +1,4 @@ | |||
| import { orderBy } from 'es-toolkit/array' | |||
There was a problem hiding this comment.
The import path for orderBy should use 'es-toolkit/compat' instead of 'es-toolkit/array' for consistency with the existing codebase. The file useRegistrySearch.ts already imports orderBy from 'es-toolkit/compat', and using the same import path ensures consistency across the project.
Suggested change
| import { orderBy } from 'es-toolkit/array' | |
| import { orderBy } from 'es-toolkit/compat' |
Member
Author
There was a problem hiding this comment.
I don't see why we can't use array
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.02 MB (baseline 1.02 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 80.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed Panels & Settings — 430 kB (baseline 430 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 8 added / 8 removed User & Accounts — 3.94 kB (baseline 3.94 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.8 kB (baseline 2.8 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 32.8 kB (baseline 32.8 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed Data & Services — 3.06 MB (baseline 3.06 MB) • 🟢 -29 BStores, services, APIs, and repositories
Status: 7 added / 7 removed Utilities & Hooks — 18.1 kB (baseline 18.1 kB) • 🔴 +1 BHelpers, composables, and utility bundles
Status: 7 added / 7 removed Vendor & Third-Party — 10.4 MB (baseline 10.4 MB) • 🔴 +100 BExternal libraries and shared vendor chunks
Status: 1 added / 1 removed Other — 6.28 MB (baseline 6.28 MB) • 🟢 -214 BBundles that do not match a named category
Status: 35 added / 35 removed |
benceruleanlu
changed the title
DrJKL
approved these changes
Jan 22, 2026
godwiniheuwa
pushed a commit
to godwiniheuwa/ComfyUI_frontend
that referenced
this pull request
Jan 22, 2026
Use es-toolkit orderBy for queue list sorting. The queue overlay list already sorts by create time, but the implementation used Array.sort with a custom comparator and mutated the array in place. Switch to es-toolkit's orderBy to make the sort intent explicit, avoid mutation, and align with the utility set we already depend on. Sorting keys and direction remain the same, so behavior is unchanged. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8228-fix-use-orderBy-for-queue-list-sorting-2f06d73d365081e791fff7d2212537f8) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use es-toolkit orderBy for queue list sorting.
The queue overlay list already sorts by create time, but the implementation used Array.sort with a custom comparator and mutated the array in place. Switch to es-toolkit's orderBy to make the sort intent explicit, avoid mutation, and align with the utility set we already depend on. Sorting keys and direction remain the same, so behavior is unchanged.
┆Issue is synchronized with this Notion page by Unito