Skip to content

chore: migrate Vite config to Vite 8 beta (Rolldown) #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 6 commits into from
Jan 20, 2026
Merged

chore: migrate Vite config to Vite 8 beta (Rolldown) #8152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
036aed3
chore: migrate Vite config to Vite 8 beta (Rolldown)
DrJKL Jan 18, 2026
d82482c
Enable strictExecutionOrder
DrJKL Jan 19, 2026
2a1ebc8
Merge branch 'main' into drjkl/more-configsolidation
DrJKL Jan 19, 2026
6a8c49e
fix: migrate Storybook config to Vite 8 rolldown options
DrJKL Jan 19, 2026
8067f0c
Mark console logs as pure for treeshaking.
DrJKL Jan 19, 2026
0f29774
Merge branch 'main' into drjkl/more-configsolidation
DrJKL Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,15 @@ const config: StorybookConfig = {
}
]
},
esbuild: {
// Prevent minification of identifiers to preserve _sfc_main
minifyIdentifiers: false,
keepNames: true
},
build: {
rollupOptions: {
// Disable tree-shaking for Storybook to prevent Vue SFC exports from being removed
rolldownOptions: {
experimental: {
strictExecutionOrder: true
},
treeshake: false,
output: {
keepNames: true
},
onwarn: (warning, warn) => {
// Suppress specific warnings
if (
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop-ui/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default defineConfig(() => {
})
],
build: {
minify: SHOULD_MINIFY ? ('esbuild' as const) : false,
minify: SHOULD_MINIFY,
target: 'es2022',
sourcemap: true
}
Expand Down
122 changes: 64 additions & 58 deletions vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,77 +412,83 @@ export default defineConfig({
],

build: {
minify: SHOULD_MINIFY ? 'esbuild' : false,
minify: SHOULD_MINIFY,
target: 'es2022',
sourcemap: GENERATE_SOURCEMAP,
rollupOptions: {
treeshake: true,
output: {
manualChunks: (id) => {
if (!id.includes('node_modules')) {
return undefined
}

if (id.includes('primevue') || id.includes('@primeuix')) {
return 'vendor-primevue'
}

if (id.includes('@tiptap')) {
return 'vendor-tiptap'
}

if (id.includes('chart.js')) {
return 'vendor-chart'
}

if (id.includes('three') || id.includes('@sparkjsdev')) {
return 'vendor-three'
}

if (id.includes('@xterm')) {
return 'vendor-xterm'
}

if (id.includes('/vue') || id.includes('pinia')) {
return 'vendor-vue'
}
if (id.includes('reka-ui')) {
return 'vendor-reka-ui'
}

return 'vendor-other'
}
}
}
},

esbuild: {
minifyIdentifiers: SHOULD_MINIFY,
keepNames: true,
minifySyntax: SHOULD_MINIFY,
minifyWhitespace: SHOULD_MINIFY,
pure: SHOULD_MINIFY
? [
'console.log',
Copy link
Contributor

@christian-byrne christian-byrne Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't want to DCE these anymore?

rolldownOptions: {
treeshake: {
manualPureFunctions: [
'console.clear',
'console.count',
'console.countReset',
'console.debug',
'console.info',
'console.trace',
'console.dir',
'console.dirxml',
'console.group',
'console.groupCollapsed',
'console.groupEnd',
'console.info',
'console.log',
'console.profile',
'console.profileEnd',
'console.table',
'console.time',
'console.timeEnd',
'console.timeLog',
'console.count',
'console.countReset',
'console.profile',
'console.profileEnd',
'console.clear'
'console.trace'
]
: []
},
experimental: {
strictExecutionOrder: true
},
output: {
keepNames: true,
codeSplitting: {
groups: [
{
name: 'vendor-primevue',
test: /[\\/]node_modules[\\/](@?primevue|@primeuix)[\\/]/,
priority: 10
},
{
name: 'vendor-tiptap',
test: /[\\/]node_modules[\\/]@tiptap[\\/]/,
priority: 10
},
{
name: 'vendor-chart',
test: /[\\/]node_modules[\\/]chart\.js[\\/]/,
priority: 10
},
{
name: 'vendor-three',
test: /[\\/]node_modules[\\/](three|@sparkjsdev)[\\/]/,
priority: 10
},
{
name: 'vendor-xterm',
test: /[\\/]node_modules[\\/]@xterm[\\/]/,
priority: 10
},
{
name: 'vendor-vue',
test: /[\\/]node_modules[\\/](vue|pinia)[\\/]/,
priority: 10
},
{
name: 'vendor-reka-ui',
test: /[\\/]node_modules[\\/]reka-ui[\\/]/,
priority: 10
},
{
name: 'vendor-other',
test: /[\\/]node_modules[\\/]/,
priority: 0
}
]
}
}
}
},

define: {
Expand Down