chore: migrate Vite config to Vite 8 beta (Rolldown) #8152
Merged
+72
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amp-Thread-ID: https://ampcode.com/threads/T-019bcfff-e466-73d8-830d-89b550859550 Co-authored-by: Amp <[email protected]>
Contributor
📝 WalkthroughWalkthroughThe PR updates Storybook and Vite build configurations to use Rolldown-specific options (replacing Changes
Possibly related PRs
Suggested reviewers
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Tests:
|
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/19/2026, 11:10:51 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 22.4 kB (baseline 18.1 kB) • 🔴 +4.21 kBMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.02 MB (baseline 878 kB) • 🔴 +142 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 80.7 kB (baseline 66.6 kB) • 🔴 +14.1 kBTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed Panels & Settings — 430 kB (baseline 385 kB) • 🔴 +45.3 kBConfiguration panels, inspectors, and settings screens
Status: 21 added / 21 removed User & Accounts — 3.94 kB (baseline 4.22 kB) • 🟢 -283 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed Editors & Dialogs — 2.8 kB (baseline 2.85 kB) • 🟢 -54 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 32.8 kB (baseline 26.3 kB) • 🔴 +6.44 kBReusable component library chunks
Status: 8 added / 8 removed Data & Services — 3.04 MB (baseline 2.75 MB) • 🔴 +291 kBStores, services, APIs, and repositories
Status: 8 added / 8 removed Utilities & Hooks — 18.7 kB (baseline 16.6 kB) • 🔴 +2.12 kBHelpers, composables, and utility bundles
Status: 9 added / 8 removed Vendor & Third-Party — 10.4 MB (baseline 9.09 MB) • 🔴 +1.34 MBExternal libraries and shared vendor chunks
Status: 8 added / 8 removed Other — 6.24 MB (baseline 5.91 MB) • 🔴 +333 kBBundles that do not match a named category
Status: 82 added / 83 removed |
dosubot
bot
added
the
size:L
christian-byrne
previously approved these changes
Jan 19, 2026
| minifyWhitespace: SHOULD_MINIFY, | ||
| pure: SHOULD_MINIFY | ||
| ? [ | ||
| 'console.log', |
Contributor
There was a problem hiding this comment.
You don't want to DCE these anymore?
christian-byrne
approved these changes
Jan 19, 2026
godwiniheuwa
pushed a commit
to godwiniheuwa/ComfyUI_frontend
that referenced
this pull request
Jan 22, 2026
Prepares Vite config for Vite 8 by migrating from esbuild/Rollup to Rolldown/Oxc. ## Changes - Migrate `build.rollupOptions` → `build.rolldownOptions` - Replace `manualChunks` with `codeSplitting.groups` - Update Storybook config with `strictExecutionOrder` for module loading compatibility ## Testing - [x] `pnpm typecheck` passes - [x] `pnpm build` succeeds - [x] `pnpm test:unit` passes --------- Co-authored-by: Amp <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares Vite config for Vite 8 by migrating from esbuild/Rollup to Rolldown/Oxc.
Changes
build.rollupOptions→build.rolldownOptionsmanualChunkswithcodeSplitting.groupsstrictExecutionOrderfor module loading compatibilityTesting
pnpm typecheckpassespnpm buildsucceedspnpm test:unitpasses