Road to No Explicit Any Part 5: load3d Module by Myestery · Pull Request #8064 · Comfy-Org/ComfyUI_frontend

Myestery · 2026-01-15T00:58:16Z

Summary

Removes all any types from the load3d module
Uses generics for EventCallback to provide type-safe event handling
Types node parameters with LGraphNode
Types onExecuted callback with NodeExecutionOutput
Types Camera Config property casts with CameraConfig interface

Changes

interfaces.ts: EventCallback generic, EventManagerInterface generic methods
EventManager.ts: Generic emitEvent/addEventListener/removeEventListener
AnimationManager.ts: setupModelAnimations originalModel typed as GLTF union
Load3d.ts: Event listener methods use EventCallback
load3d.ts: Node params typed as LGraphNode, onExecuted uses NodeExecutionOutput, CameraConfig casts

Test plan

pnpm typecheck passes
pnpm lint passes
pnpm test:unit passes

┆Issue is synchronized with this Notion page by Unito

…urcesUpload

coderabbitai · 2026-01-15T00:58:33Z

📝 Walkthrough

Walkthrough

Converts event callbacks to a generic EventCallback<T>, propagates that typing through EventManager and Load3d, tightens several 3D-related types (GLTF, THREE types, CameraConfig/CameraState) and replaces various loose any usages with specific unions and typed NodeExecutionOutput.

Changes

Cohort / File(s)	Summary
Interfaces & public types `src/extensions/core/load3d/interfaces.ts`	`EventCallback` made generic (`(data: T) => void`); `EventManagerInterface` methods become generic; `AnimationManagerInterface.setupModelAnimations` narrowed to `THREE.Object3D
Event system & public API `src/extensions/core/load3d/EventManager.ts`, `src/extensions/core/load3d/Load3d.ts`, `src/composables/useLoad3d.ts`	Listener storage moved to `Record<string, EventCallback[]>`; `addEventListener`/`removeEventListener`/`emitEvent` now generic (`<T>`); callsites cast handlers to `EventCallback` for type compatibility.
Animation handling `src/extensions/core/load3d/AnimationManager.ts`	`setupModelAnimations` second parameter changed from `any` to `THREE.Object3D
Core Load3d logic & typing `src/extensions/core/load3d.ts`	Introduced `CameraConfig`, `CameraState`, `NodeExecutionOutput` types; replaced many `any` usages with typed accessors/unions, added optional chaining and safer result extraction in execution handler and serialization paths.

Possibly related PRs

feat: add animation progress bar for 3D nodes and viewer #7839: Related changes to animation event registration and handling which interact with the new generic event callback types.
fix: improve type safety in type definitions #7337: Related updates to NodeExecutionOutput typing and onExecuted handler signature used in Load3d.

Suggested reviewers

DrJKL
simula-r

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d767d5 and 9e2a0ec.

📒 Files selected for processing (1)

src/extensions/core/load3d.ts

🧰 Additional context used

📓 Path-based instructions (6)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/extensions/core/load3d.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/extensions/core/load3d.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

src/extensions/core/load3d.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/extensions/core/load3d.ts

src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

src/extensions/core/load3d.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

src/extensions/core/load3d.ts

🧠 Learnings (10)

📓 Common learnings

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7898
File: src/composables/usePaste.test.ts:248-248
Timestamp: 2026-01-09T02:07:59.035Z
Learning: In test files at src/**/*.test.ts, when creating mock objects that partially implement an interface (e.g., LGraphNode), use `as Partial<InterfaceType> as InterfaceType` instead of `as any` or `as unknown as InterfaceType` to explicitly acknowledge the incomplete implementation while maintaining type safety.

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Never use `as any` type assertions - fix the underlying type issue

📚 Learning: 2026-01-09T02:07:59.035Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7898
File: src/composables/usePaste.test.ts:248-248
Timestamp: 2026-01-09T02:07:59.035Z
Learning: In test files at src/**/*.test.ts, when creating mock objects that partially implement an interface (e.g., LGraphNode), use `as Partial<InterfaceType> as InterfaceType` instead of `as any` or `as unknown as InterfaceType` to explicitly acknowledge the incomplete implementation while maintaining type safety.

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2026-01-10T00:24:17.695Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T00:24:17.695Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Never use `as any` type assertions - fix the underlying type issue

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2026-01-06T19:20:56.167Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7746
File: src/platform/assets/services/assetService.ts:484-491
Timestamp: 2026-01-06T19:20:56.167Z
Learning: In `src/platform/assets/services/assetService.ts`, prefer using `schema.safeParse()` over `schema.parse()` for validating API responses to avoid throwing ZodError with internal schema details; follow the existing pattern: call `safeParse()`, check `result.success`, and use `fromZodError(result.error)` to format error messages for logging while throwing user-friendly errors.

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/extensions/core/load3d.ts

📚 Learning: 2026-01-12T17:39:27.738Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Applied to files:

src/extensions/core/load3d.ts

🧬 Code graph analysis (1)

src/extensions/core/load3d.ts (2)

src/extensions/core/load3d/interfaces.ts (2)

CameraConfig (40-44)

CameraState (20-25)

src/schemas/apiSchema.ts (1)

NodeExecutionOutput (36-36)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: setup
GitHub Check: test
GitHub Check: lint-and-format
GitHub Check: collect

🔇 Additional comments (3)

src/extensions/core/load3d.ts (3)

7-19: LGTM on the type imports.

The type imports are properly separated from regular imports, following the coding guidelines.

40-45: LGTM on the function typing.

The node parameter is now properly typed as LGraphNode, and the widget lookup is correctly typed with the union IStringWidget | undefined.

338-340: LGTM on the CameraConfig type assertions.

The consistent pattern as CameraConfig | undefined properly handles the dynamic property access while maintaining type safety throughout the file.

Also applies to: 367-369, 400-401, 485-487

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-15T00:58:36Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 01/15/2026, 01:15:49 AM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

github-actions · 2026-01-15T00:58:43Z

🎭 Playwright Tests: ⚠️ Passed with flaky tests

Results: 501 passed, 0 failed, 3 flaky, 8 skipped (Total: 512)

❌ Failed Tests

📊 Browser Reports

chromium: View Report (✅ 491 / ❌ 0 / ⚠️ 2 / ⏭️ 8)
chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
mobile-chrome: View Report (✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

jtydhr88

LGTM

coderabbitai

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@src/composables/useLoad3d.ts`:
- Around line 565-570: handleEvents currently casts every handler from
eventConfig to EventCallback, losing the specific handler types; instead define
a typed event map (e.g., Load3dEventMap) that maps event names to their payload
types and use that generic when registering listeners via load3d?.[method];
update handleEvents to infer each event's type from the map when calling
addEventListener/removeEventListener so you preserve type safety for handlers
without broad-casting to EventCallback.

In `@src/extensions/core/load3d.ts`:
- Around line 499-513: The node.onExecuted handler currently accesses
output.result directly; follow the established pattern (as in
src/extensions/core/imageCompare.ts) by first casting output to Record<string,
unknown> (or similar) to access the passthrough properties safely, then extract
result as a typed array (e.g., const result = (outputAsRecord.result as
unknown[] | undefined)), and finally assign typed elements (filePath,
cameraState, bgImagePath) from that array before using them (e.g.,
modelWidget.value = filePath?.replaceAll('\\', '/')). Update all occurrences of
output.result in the node.onExecuted function to use this safe cast-and-type
approach.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3069c24 and 0d767d5.

📒 Files selected for processing (6)

src/composables/useLoad3d.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d/EventManager.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/interfaces.ts

🧰 Additional context used

📓 Path-based instructions (10)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Derive component types using vue-component-type-helpers (ComponentProps, ComponentSlots) instead of separate type files
Use es-toolkit for utility functions
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

src/**/{services,composables}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/{services,composables}/**/*.{ts,tsx}: Use api.apiURL() for backend endpoints instead of constructing URLs directly
Use api.fileURL() for static file access instead of constructing URLs directly

Files:

src/composables/useLoad3d.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: Use separate import type statements instead of inline type in mixed imports
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, 80-character width
Sort and group imports by plugin, run pnpm format before committing
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue
Write code that is expressive and self-documenting - avoid unnecessary comments
Do not add or retain redundant comments - clean as you go
Avoid mutable state - prefer immutability and assignment at point of declaration
Watch out for Code Smells and refactor to avoid them

Files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/composables/useLoad3d.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/composables/useLoad3d.ts

src/composables/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Name composables as useXyz.ts (e.g., useForm.ts)

Files:

src/composables/useLoad3d.ts

src/**/*.{ts,vue}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,vue}: Use ref for reactive state, computed() for derived values, and watch/watchEffect for side effects in Composition API
Avoid using ref with watch if a computed would suffice - minimize refs and derived state
Use provide/inject for dependency injection only when simpler alternatives (Store or shared composable) won't work
Leverage VueUse functions for performance-enhancing composables
Use VueUse function for useI18n in composition API for string literals

Files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx}: Keep functions short and functional
Minimize nesting (if statements, for loops, etc.)
Use function declarations instead of function expressions when possible

Files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

🧠 Learnings (7)

📓 Common learnings

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7898
File: src/composables/usePaste.test.ts:248-248
Timestamp: 2026-01-09T02:07:59.035Z
Learning: In test files at src/**/*.test.ts, when creating mock objects that partially implement an interface (e.g., LGraphNode), use `as Partial<InterfaceType> as InterfaceType` instead of `as any` or `as unknown as InterfaceType` to explicitly acknowledge the incomplete implementation while maintaining type safety.

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

📚 Learning: 2025-12-30T22:22:33.836Z

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Applied to files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

📚 Learning: 2026-01-12T17:39:27.738Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Applied to files:

src/composables/useLoad3d.ts
src/extensions/core/load3d/Load3d.ts
src/extensions/core/load3d/AnimationManager.ts
src/extensions/core/load3d.ts
src/extensions/core/load3d/interfaces.ts
src/extensions/core/load3d/EventManager.ts

🧬 Code graph analysis (4)

src/composables/useLoad3d.ts (1)

src/extensions/core/load3d/interfaces.ts (1)

EventCallback (50-52)

src/extensions/core/load3d/Load3d.ts (1)

src/extensions/core/load3d/interfaces.ts (1)

EventCallback (50-52)

src/extensions/core/load3d.ts (3)

src/lib/litegraph/src/types/widgets.ts (1)

IStringWidget (145-152)

src/extensions/core/load3d/interfaces.ts (2)

CameraConfig (40-44)

CameraState (20-25)

src/schemas/apiSchema.ts (1)

NodeExecutionOutput (36-36)

src/extensions/core/load3d/EventManager.ts (1)

src/extensions/core/load3d/interfaces.ts (1)

EventCallback (50-52)

🪛 GitHub Actions: CI: Size Data

src/extensions/core/load3d.ts

[error] 502-502: TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type '{}'.

🪛 GitHub Actions: CI: Tests E2E

src/extensions/core/load3d.ts

[error] 502-502: TypeScript error TS7053: Element implicitly has an 'any' type because expression of type '0' can't be used to index type '{}'.

[error] Build step failed during typecheck: vue-tsc --noEmit

🪛 GitHub Check: collect

src/extensions/core/load3d.ts

[failure] 511-511:
Element implicitly has an 'any' type because expression of type '2' can't be used to index type '{}'.

[failure] 510-510:
Element implicitly has an 'any' type because expression of type '1' can't be used to index type '{}'.

[failure] 502-502:
Element implicitly has an 'any' type because expression of type '0' can't be used to index type '{}'.

🪛 GitHub Check: setup

src/extensions/core/load3d.ts

[failure] 511-511:
Element implicitly has an 'any' type because expression of type '2' can't be used to index type '{}'.

[failure] 510-510:
Element implicitly has an 'any' type because expression of type '1' can't be used to index type '{}'.

[failure] 502-502:
Element implicitly has an 'any' type because expression of type '0' can't be used to index type '{}'.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: deploy-and-comment
GitHub Check: lint-and-format
GitHub Check: test

🔇 Additional comments (12)

src/extensions/core/load3d/interfaces.ts (3)

130-134: LGTM!

The generic signatures for addEventListener, removeEventListener, and emitEvent are consistent and properly typed with EventCallback<T>.

144-147: LGTM!

The setupModelAnimations signature with the union type THREE.Object3D | THREE.BufferGeometry | GLTF | null properly covers all model representations and aligns with ModelManagerInterface.originalModel at line 162.

50-52: Remove review comment—EventCallback signature change does not introduce a breaking change.

All emitEvent() calls in the codebase already pass a data argument explicitly, including cases where the value is null (e.g., emitEvent('exportLoadingEnd', null)). The signature change from optional to required data aligns with the actual usage patterns and poses no risk to existing event handlers.

Likely an incorrect or invalid review comment.

src/extensions/core/load3d/AnimationManager.ts (2)

2-8: LGTM!

The import statements correctly use separate import type statements as per repository lint rules, and the GLTF type import supports the new parameter typing. Based on learnings, this follows the required pattern.

42-60: LGTM!

The setupModelAnimations implementation correctly uses type guards ('animations' in originalModel and Array.isArray) to safely access the animations property across the union type. This is a proper pattern for handling discriminated unions.

src/extensions/core/load3d.ts (3)

40-45: LGTM!

The handleModelUpload function signature correctly uses LGraphNode instead of any, and the modelWidget is properly typed as IStringWidget | undefined to enable safe access to its properties.

367-374: LGTM!

The CameraConfig typing with fallback object creation correctly handles the case where the property may not exist, and the subsequent mutation of cameraConfig.state is type-safe.

7-19: LGTM!

The type imports are correctly separated into import type statements as required by repository lint rules. Based on learnings, this follows the established pattern.

src/composables/useLoad3d.ts (1)

7-18: LGTM!

The EventCallback type is correctly imported alongside other type imports from the interfaces module, following the repository's import type conventions.

src/extensions/core/load3d/Load3d.ts (2)

14-21: LGTM!

The EventCallback type is correctly imported and properly separated in the type imports block, aligning with the generic event handling introduced in this PR.

614-620: LGTM!

The addEventListener and removeEventListener methods are correctly updated to generic signatures <T>, consistent with the EventManagerInterface declaration. The implementation properly delegates to the underlying eventManager.

src/extensions/core/load3d/EventManager.ts (1)

4-25: LGTM! Well-implemented type-erased event system.

The generic approach properly balances type safety at the API boundary with the flexibility needed for dynamic event systems:

Record<string, EventCallback[]> is cleaner than an index signature.

The as EventCallback cast on line 10 is the standard approach for type-erased storage.

Reference comparison in removeEventListener correctly matches the stored callback.

emitEvent<T> correctly passes typed data to callbacks (since T is assignable to unknown).

This pattern relies on callers using consistent type parameters for the same event name across addEventListener and emitEvent calls—a typical trade-off in JavaScript event systems that avoids more complex typed event map approaches.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

src/composables/useLoad3d.ts

src/extensions/core/load3d.ts

…cess

github-actions · 2026-01-15T01:17:10Z

Bundle Size Report

Summary

Raw size: 19.7 MB baseline 19.7 MB — 🔴 +16 B
Gzip: 4.01 MB baseline 4.01 MB — 🟢 -39 B
Brotli: 3.06 MB baseline 3.06 MB — 🔴 +11 B
Bundles: 99 current • 99 baseline • 38 added / 38 removed

Category Glance
App Entry Points 🔴 +16 B (3.34 MB) · Vendor & Third-Party ⚪ 0 B (9.34 MB) · Other ⚪ 0 B (5.25 MB) · Graph Workspace ⚪ 0 B (1.15 MB) · Panels & Settings ⚪ 0 B (372 kB) · UI Components ⚪ 0 B (209 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.34 MB (baseline 3.34 MB) • 🔴 +16 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/index-_0DWRuA4.js~~ (removed)	3.14 MB	—	🟢 -3.14 MB	🟢 -657 kB	🟢 -499 kB
assets/index-C2efWzKm.js (new)	—	3.14 MB	🔴 +3.14 MB	🔴 +657 kB	🔴 +499 kB
assets/index-B8q1HFny.js (new)	—	200 kB	🔴 +200 kB	🔴 +44 kB	🔴 +36.4 kB
~~assets/index-C-d4DNz1.js~~ (removed)	200 kB	—	🟢 -200 kB	🟢 -44.1 kB	🟢 -36.4 kB
~~assets/index-BP3kbGF8.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -247 B	🟢 -235 B
assets/index-D7rBQd-X.js (new)	—	345 B	🔴 +345 B	🔴 +244 B	🔴 +233 B

Status: 3 added / 3 removed

Graph Workspace — 1.15 MB (baseline 1.15 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/GraphView-BMBCpDoz.js~~ (removed)	1.15 MB	—	🟢 -1.15 MB	🟢 -220 kB	🟢 -165 kB
assets/GraphView-BNBHR8Zl.js (new)	—	1.15 MB	🔴 +1.15 MB	🔴 +220 kB	🔴 +165 kB

Status: 1 added / 1 removed

Views & Navigation — 6.66 kB (baseline 6.66 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-BMPbhW8s.js (new)	—	6.66 kB	🔴 +6.66 kB	🔴 +2.16 kB	🔴 +1.92 kB
~~assets/UserSelectView-Dh88NVMf.js~~ (removed)	6.66 kB	—	🟢 -6.66 kB	🟢 -2.16 kB	🟢 -1.93 kB

Status: 1 added / 1 removed

Panels & Settings — 372 kB (baseline 372 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LegacyCreditsPanel-Bsae76qO.js (new)	—	25.2 kB	🔴 +25.2 kB	🔴 +5.76 kB	🔴 +5.02 kB
~~assets/LegacyCreditsPanel-CFHiHMsK.js~~ (removed)	25.2 kB	—	🟢 -25.2 kB	🟢 -5.76 kB	🟢 -5.02 kB
~~assets/KeybindingPanel-BA5j4ell.js~~ (removed)	14.9 kB	—	🟢 -14.9 kB	🟢 -3.59 kB	🟢 -3.13 kB
assets/KeybindingPanel-Cp3LjBS-.js (new)	—	14.9 kB	🔴 +14.9 kB	🔴 +3.59 kB	🔴 +3.13 kB
~~assets/ExtensionPanel-CY16B4zV.js~~ (removed)	11.1 kB	—	🟢 -11.1 kB	🟢 -2.63 kB	🟢 -2.31 kB
assets/ExtensionPanel-DwAnXiKA.js (new)	—	11.1 kB	🔴 +11.1 kB	🔴 +2.63 kB	🔴 +2.31 kB
~~assets/AboutPanel-DcSkMhCt.js~~ (removed)	9.2 kB	—	🟢 -9.2 kB	🟢 -2.47 kB	🟢 -2.22 kB
assets/AboutPanel-RmgFBq6r.js (new)	—	9.2 kB	🔴 +9.2 kB	🔴 +2.48 kB	🔴 +2.22 kB
assets/ServerConfigPanel-By-Qusz3.js (new)	—	7.55 kB	🔴 +7.55 kB	🔴 +2.06 kB	🔴 +1.83 kB
~~assets/ServerConfigPanel-qdfciqI_.js~~ (removed)	7.55 kB	—	🟢 -7.55 kB	🟢 -2.06 kB	🟢 -1.82 kB
assets/UserPanel-LgQ3E5u7.js (new)	—	6.92 kB	🔴 +6.92 kB	🔴 +1.8 kB	🔴 +1.58 kB
~~assets/UserPanel-phBJqNri.js~~ (removed)	6.92 kB	—	🟢 -6.92 kB	🟢 -1.81 kB	🟢 -1.58 kB
assets/settings-BGQfQzTx.js	25.6 kB	25.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BVE4KHTw.js	22.7 kB	22.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BVtpJmlU.js	30.9 kB	30.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C2aO00Dz.js	28.6 kB	28.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-Cm3ieBXR.js	27.8 kB	27.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CzQKMdK3.js	26.2 kB	26.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CzYUIUnL.js	27.1 kB	27.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DwKpL7jw.js	26.3 kB	26.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DX8feV4n.js	25.3 kB	25.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-mWzYycGc.js	22 kB	22 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-U4AdZ8Rl.js	34.9 kB	34.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 209 kB (baseline 209 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LazyImage.vue_vue_type_script_setup_true_lang-B1-qm-Es.js (new)	—	69.6 kB	🔴 +69.6 kB	🔴 +14.2 kB	🔴 +12.3 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-C9UTiDlS.js~~ (removed)	69.6 kB	—	🟢 -69.6 kB	🟢 -14.2 kB	🟢 -12.3 kB
~~assets/Load3D.vue_vue_type_script_setup_true_lang-d9hlWwDa.js~~ (removed)	56.4 kB	—	🟢 -56.4 kB	🟢 -8.78 kB	🟢 -7.54 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-DBiRVuLR.js (new)	—	56.4 kB	🔴 +56.4 kB	🔴 +8.78 kB	🔴 +7.53 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-BDGSk_JB.js (new)	—	48.1 kB	🔴 +48.1 kB	🔴 +10.4 kB	🔴 +8.99 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DPOi2-lY.js~~ (removed)	48.1 kB	—	🟢 -48.1 kB	🟢 -10.4 kB	🟢 -9 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DCero6Di.js (new)	—	16.4 kB	🔴 +16.4 kB	🔴 +4.11 kB	🔴 +3.64 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-QBvNGiCa.js~~ (removed)	16.4 kB	—	🟢 -16.4 kB	🟢 -4.11 kB	🟢 -3.64 kB
assets/ComfyQueueButton-CoNs5eug.js (new)	—	8.87 kB	🔴 +8.87 kB	🔴 +2.59 kB	🔴 +2.31 kB
~~assets/ComfyQueueButton-y6QE2YI7.js~~ (removed)	8.87 kB	—	🟢 -8.87 kB	🟢 -2.6 kB	🟢 -2.31 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-D_V6eAUa.js (new)	—	3.75 kB	🔴 +3.75 kB	🔴 +1.47 kB	🔴 +1.33 kB
~~assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-DdhEJ3-t.js~~ (removed)	3.75 kB	—	🟢 -3.75 kB	🟢 -1.47 kB	🟢 -1.33 kB
~~assets/WidgetButton-BDnmPhj8.js~~ (removed)	2.25 kB	—	🟢 -2.25 kB	🟢 -1.01 kB	🟢 -907 B
assets/WidgetButton-DTwqbDgT.js (new)	—	2.25 kB	🔴 +2.25 kB	🔴 +1.01 kB	🔴 +890 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-BeE2eFrD.js (new)	—	2.14 kB	🔴 +2.14 kB	🔴 +889 B	🔴 +772 B
~~assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-sYL36Reu.js~~ (removed)	2.14 kB	—	🟢 -2.14 kB	🟢 -891 B	🟢 -764 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-IJTLOeU1.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-BuYbrqPy.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.57 kB
~~assets/keybindingService-pz8JOstS.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.58 kB
assets/audioService-c1GWTQKM.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +961 B	🔴 +830 B
~~assets/audioService-D_UFtBV8.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -961 B	🟢 -828 B
assets/serverConfigStore-DyIvWaGz.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/audioUtils-B2aBdG_q.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +651 B	🔴 +548 B
~~assets/audioUtils-zgGaSg5r.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -651 B	🟢 -547 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.34 MB (baseline 9.34 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DZdD68iT.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-C9GFBFnP.js	3.93 MB	3.93 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-NX-4NPlN.js	1.95 MB	1.95 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-reka-ui-7Sidv1he.js	111 kB	111 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-Bz1zdJb0.js	2.08 MB	2.08 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-DFkXpum7.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-DMH2Ziq4.js	165 kB	165 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js	420 kB	420 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 5.25 MB (baseline 5.25 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/SubscriptionRequiredDialogContent-Cod9AGXu.js~~ (removed)	29.3 kB	—	🟢 -29.3 kB	🟢 -6.5 kB	🟢 -5.65 kB
assets/SubscriptionRequiredDialogContent-DMDaC3Xi.js (new)	—	29.3 kB	🔴 +29.3 kB	🔴 +6.5 kB	🔴 +5.65 kB
~~assets/WidgetRecordAudio-Bi_dOtLJ.js~~ (removed)	20.5 kB	—	🟢 -20.5 kB	🟢 -5.25 kB	🟢 -4.65 kB
assets/WidgetRecordAudio-CJ05hcqg.js (new)	—	20.5 kB	🔴 +20.5 kB	🔴 +5.25 kB	🔴 +4.66 kB
assets/AudioPreviewPlayer-CeujlnaG.js (new)	—	13.4 kB	🔴 +13.4 kB	🔴 +3.36 kB	🔴 +3.01 kB
~~assets/AudioPreviewPlayer-DLxtha_X.js~~ (removed)	13.4 kB	—	🟢 -13.4 kB	🟢 -3.36 kB	🟢 -3.01 kB
assets/ValueControlPopover-DsRc2oHB.js (new)	—	5.53 kB	🔴 +5.53 kB	🔴 +1.72 kB	🔴 +1.53 kB
~~assets/ValueControlPopover-Q-BsUg_d.js~~ (removed)	5.53 kB	—	🟢 -5.53 kB	🟢 -1.72 kB	🟢 -1.53 kB
~~assets/WidgetGalleria-Cj1cz1dD.js~~ (removed)	4.14 kB	—	🟢 -4.14 kB	🟢 -1.46 kB	🟢 -1.32 kB
assets/WidgetGalleria-Dvr79ji5.js (new)	—	4.14 kB	🔴 +4.14 kB	🔴 +1.46 kB	🔴 +1.32 kB
~~assets/WidgetColorPicker-D1s0GyMv.js~~ (removed)	3.44 kB	—	🟢 -3.44 kB	🟢 -1.4 kB	🟢 -1.25 kB
assets/WidgetColorPicker-Qa6R8ZeX.js (new)	—	3.44 kB	🔴 +3.44 kB	🔴 +1.4 kB	🔴 +1.25 kB
assets/WidgetTextarea-BikZTs2l.js (new)	—	3.12 kB	🔴 +3.12 kB	🔴 +1.23 kB	🔴 +1.09 kB
~~assets/WidgetTextarea-t3HqrHVC.js~~ (removed)	3.12 kB	—	🟢 -3.12 kB	🟢 -1.23 kB	🟢 -1.09 kB
assets/WidgetMarkdown-B96IbnuH.js (new)	—	3.12 kB	🔴 +3.12 kB	🔴 +1.29 kB	🔴 +1.14 kB
~~assets/WidgetMarkdown-JVg03fnB.js~~ (removed)	3.12 kB	—	🟢 -3.12 kB	🟢 -1.29 kB	🟢 -1.14 kB
assets/WidgetAudioUI-CDoh-f8_.js (new)	—	2.93 kB	🔴 +2.93 kB	🔴 +1.18 kB	🔴 +1.06 kB
~~assets/WidgetAudioUI-ydgmSXCS.js~~ (removed)	2.93 kB	—	🟢 -2.93 kB	🟢 -1.18 kB	🟢 -1.07 kB
assets/WidgetToggleSwitch-Du1AFNOb.js (new)	—	2.7 kB	🔴 +2.7 kB	🔴 +1.14 kB	🔴 +1.03 kB
~~assets/WidgetToggleSwitch-QxAe2tfr.js~~ (removed)	2.7 kB	—	🟢 -2.7 kB	🟢 -1.14 kB	🟢 -1.03 kB
~~assets/WidgetInputText-0EqB1GWD.js~~ (removed)	2.03 kB	—	🟢 -2.03 kB	🟢 -938 B	🟢 -871 B
assets/WidgetInputText-CjRkZ6l3.js (new)	—	2.03 kB	🔴 +2.03 kB	🔴 +936 B	🔴 +843 B
assets/Media3DTop-C87ONP4R.js (new)	—	1.53 kB	🔴 +1.53 kB	🔴 +783 B	🔴 +671 B
~~assets/Media3DTop-DMdq7ktC.js~~ (removed)	1.53 kB	—	🟢 -1.53 kB	🟢 -783 B	🟢 -672 B
~~assets/WidgetSelect-BZO-RXnq.js~~ (removed)	772 B	—	🟢 -772 B	🟢 -377 B	🟢 -358 B
assets/WidgetSelect-C3J9KVR7.js (new)	—	772 B	🔴 +772 B	🔴 +373 B	🔴 +356 B
assets/WidgetInputNumber-Cl3f2gls.js (new)	—	712 B	🔴 +712 B	🔴 +360 B	🔴 +325 B
~~assets/WidgetInputNumber-D2PcNlm6.js~~ (removed)	712 B	—	🟢 -712 B	🟢 -364 B	🟢 -331 B
assets/Load3D-BQ5_BRx1.js (new)	—	463 B	🔴 +463 B	🔴 +283 B	🔴 +237 B
~~assets/Load3D-BZi24O8m.js~~ (removed)	463 B	—	🟢 -463 B	🟢 -283 B	🟢 -238 B
~~assets/WidgetLegacy-CbmuOihI.js~~ (removed)	403 B	—	🟢 -403 B	🟢 -253 B	🟢 -213 B
assets/WidgetLegacy-Cmfj4ngB.js (new)	—	403 B	🔴 +403 B	🔴 +251 B	🔴 +213 B
assets/commands-B32ZbeYu.js	16.5 kB	16.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-B7wQT83I.js	17 kB	17 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BK3JVjMG.js	15.7 kB	15.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-C6twMpaZ.js	15.5 kB	15.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CDUWpEwM.js	18.3 kB	18.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CfZ6FPZ-.js	15.7 kB	15.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-COIPP_pv.js	17 kB	17 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CoPn_77e.js	14.7 kB	14.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CuRNS4XD.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DBHjCSPA.js	16.2 kB	16.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DZJaRLKH.js	15.7 kB	15.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-8eC7XcBf.js	95 kB	95 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BpcYE6Bq.js	109 kB	109 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BRhbiQsB.js	129 kB	129 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BrWdnTiG.js	113 kB	113 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-C-cUNbuc.js	123 kB	123 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CGe0e9vH.js	106 kB	106 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cv9Dlj-b.js	107 kB	107 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CzsdJqwO.js	94.3 kB	94.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dbu4m_fl.js	133 kB	133 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DwAX_AEJ.js	149 kB	149 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-kiVYDd2_.js	110 kB	110 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-DUiRGHAk.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-bDoNEAep.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BrNs2ijx.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-B-XzzBeS.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BGwoeek4.js	329 kB	329 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-C6xl5-mL.js	358 kB	358 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CRZGOJB7.js	310 kB	310 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D8-Yzlzh.js	289 kB	289 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Du8VrAwA.js	320 kB	320 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-jjlLVrIs.js	317 kB	317 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-JQwk1kgy.js	292 kB	292 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-JuuXdMpv.js	391 kB	391 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-l2Y20bod.js	314 kB	314 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-VLMdhOwo.js	357 kB	357 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/OBJLoader2WorkerModule-DTMpvldF.js	109 kB	109 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-CTa5K4p_.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-BAyqYPiH.js	3.21 kB	3.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 16 added / 16 removed

## Summary This PR removes unsafe type assertions ("as unknown as Type") from test files and improves type safety across the codebase. ### Key Changes #### Type Safety Improvements - Removed all instances of "as unknown as" patterns from test files - Used proper factory functions from litegraphTestUtils instead of custom mocks - Made incomplete mocks explicit using Partial<T> types - Fixed DialogStore mocking with proper interface exports - Improved type safety with satisfies operator where applicable #### App Parameter Removal - **Removed the unused `app` parameter from all ComfyExtension interface methods** - The app parameter was always undefined at runtime as it was never passed from invokeExtensions - Affected methods: init, setup, addCustomNodeDefs, beforeRegisterNodeDef, beforeRegisterVueAppNodeDefs, registerCustomNodes, loadedGraphNode, nodeCreated, beforeConfigureGraph, afterConfigureGraph ##### Breaking Change Analysis Verified via Sourcegraph that this is NOT a breaking change: - Searched all 10 affected methods across GitHub repositories - Only one external repository ([drawthingsai/draw-things-comfyui](https://github.com/drawthingsai/draw-things-comfyui)) declares the app parameter in their extension methods - That repository never actually uses the app parameter (just declares it in the function signature) - All other repositories already omit the app parameter - Search queries used: - [init method search](https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/.*+lang:typescript+%22init%28app%22+-repo:Comfy-Org/ComfyUI_frontend&patternType=standard) - [setup method search](https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/.*+lang:typescript+%22setup%28app%22+-repo:Comfy-Org/ComfyUI_frontend&patternType=standard) - Similar searches for all 10 methods confirmed no usage ### Files Changed Test files: - src/components/settings/widgets/__tests__/WidgetInputNumberInput.test.ts - src/services/keybindingService.escape.test.ts - src/services/keybindingService.forwarding.test.ts - src/utils/__tests__/newUserService.test.ts → src/utils/__tests__/useNewUserService.test.ts - src/services/jobOutputCache.test.ts - src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts - src/renderer/extensions/vueNodes/widgets/composables/useIntWidget.test.ts - src/renderer/extensions/vueNodes/widgets/composables/useFloatWidget.test.ts Source files: - src/types/comfy.ts - Removed app parameter from ComfyExtension interface - src/services/extensionService.ts - Improved type safety with FunctionPropertyNames helper - src/scripts/metadata/isobmff.ts - Fixed extractJson return type per review - src/extensions/core/*.ts - Updated extension implementations - src/scripts/app.ts - Updated app initialization ### Testing - All existing tests pass - Type checking passes - ESLint/oxlint checks pass - No breaking changes for external repositories Part of the "Road to No Explicit Any" initiative. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 (this PR)

## Summary This PR removes unsafe type assertions ("as unknown as Type") from test files and improves type safety across the codebase. ### Key Changes #### Type Safety Improvements - Removed improper `as unknown as Type` patterns from 17 test files in Group 8 part 7 - Replaced with proper TypeScript patterns using factory functions and Mock types - Fixed createTestingPinia usage in test files (was incorrectly using createPinia) - Fixed vi.hoisted pattern for mockSetDirty in viewport tests - Fixed vi.doMock lint issues with vi.mock and vi.hoisted pattern - Retained necessary `as unknown as` casts only for complex mock objects where direct type assertions would fail ### Files Changed Test files (Group 8 part 7 - services, stores, utils): - src/services/nodeOrganizationService.test.ts - src/services/providers/algoliaSearchProvider.test.ts - src/services/providers/registrySearchProvider.test.ts - src/stores/comfyRegistryStore.test.ts - src/stores/domWidgetStore.test.ts - src/stores/executionStore.test.ts - src/stores/firebaseAuthStore.test.ts - src/stores/modelToNodeStore.test.ts - src/stores/queueStore.test.ts - src/stores/subgraphNavigationStore.test.ts - src/stores/subgraphNavigationStore.viewport.test.ts - src/stores/subgraphStore.test.ts - src/stores/systemStatsStore.test.ts - src/stores/workspace/nodeHelpStore.test.ts - src/utils/colorUtil.test.ts - src/utils/executableGroupNodeChildDTO.test.ts Source files: - src/stores/modelStore.ts - Improved type handling ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - All affected test files pass (`pnpm test:unit`) - Linting passes without errors (`pnpm lint`) - Code formatting applied (`pnpm format`) Part of the "Road to No Explicit Any" initiative, cleaning up type casting issues from branch `fix/remove-any-types-part8`. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 (this PR) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8459-Road-to-No-explicit-any-Group-8-part-7-test-files-2f86d73d36508114ad28d82e72a3a5e9) by [Unito](https://www.unito.io)

## Summary This PR removes unsafe type assertions ("as unknown as Type") from test files and improves type safety across the codebase. ### Key Changes #### Type Safety Improvements - Removed improper `as unknown as Type` patterns from test files in Group 8 part 8 - Replaced with proper TypeScript patterns using Pinia store testing patterns - Fixed parameter shadowing issue in typeGuardUtil.test.ts (constructor → nodeConstructor) - Fixed stale mock values in useConflictDetection.test.ts using getter functions - Refactored useManagerState tests to follow proper Pinia store testing patterns with createTestingPinia ### Files Changed Test files (Group 8 part 8 - utils and manager composables): - src/utils/typeGuardUtil.test.ts - Fixed parameter shadowing - src/utils/graphTraversalUtil.test.ts - Removed unsafe type assertions - src/utils/litegraphUtil.test.ts - Improved type handling - src/workbench/extensions/manager/composables/useManagerState.test.ts - Complete rewrite using Pinia testing patterns - src/workbench/extensions/manager/composables/useConflictDetection.test.ts - Fixed stale mock values with getters - src/workbench/extensions/manager/composables/useManagerQueue.test.ts - Type safety improvements - src/workbench/extensions/manager/composables/nodePack/useMissingNodes.test.ts - Removed unsafe casts - src/workbench/extensions/manager/composables/nodePack/usePacksSelection.test.ts - Type improvements - src/workbench/extensions/manager/composables/nodePack/usePacksStatus.test.ts - Type improvements - src/workbench/extensions/manager/utils/versionUtil.test.ts - Type safety fixes Source files (minor type fixes): - src/utils/fuseUtil.ts - Type improvements - src/utils/linkFixer.ts - Type safety fixes - src/utils/syncUtil.ts - Type improvements - src/workbench/extensions/manager/composables/nodePack/useWorkflowPacks.ts - Type fix - src/workbench/extensions/manager/composables/useConflictAcknowledgment.ts - Type fix ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - All affected test files pass (`pnpm test:unit`) - Linting passes without errors (`pnpm lint`) - Code formatting applied (`pnpm format`) Part of the "Road to No Explicit Any" initiative, cleaning up type casting issues from branch `fix/remove-any-types-part8`. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 (this PR) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8496-Road-to-No-explicit-any-Group-8-part-8-test-files-2f86d73d365081f3afdcf8d01fba81e1) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>

## Summary This PR removes unsafe type assertions ("as unknown as Type") from test files and improves type safety across the codebase. ### Key Changes #### Type Safety Improvements - Removed improper `as unknown as Type` patterns from 17 test files in Group 8 part 7 - Replaced with proper TypeScript patterns using factory functions and Mock types - Fixed createTestingPinia usage in test files (was incorrectly using createPinia) - Fixed vi.hoisted pattern for mockSetDirty in viewport tests - Fixed vi.doMock lint issues with vi.mock and vi.hoisted pattern - Retained necessary `as unknown as` casts only for complex mock objects where direct type assertions would fail ### Files Changed Test files (Group 8 part 7 - services, stores, utils): - src/services/nodeOrganizationService.test.ts - src/services/providers/algoliaSearchProvider.test.ts - src/services/providers/registrySearchProvider.test.ts - src/stores/comfyRegistryStore.test.ts - src/stores/domWidgetStore.test.ts - src/stores/executionStore.test.ts - src/stores/firebaseAuthStore.test.ts - src/stores/modelToNodeStore.test.ts - src/stores/queueStore.test.ts - src/stores/subgraphNavigationStore.test.ts - src/stores/subgraphNavigationStore.viewport.test.ts - src/stores/subgraphStore.test.ts - src/stores/systemStatsStore.test.ts - src/stores/workspace/nodeHelpStore.test.ts - src/utils/colorUtil.test.ts - src/utils/executableGroupNodeChildDTO.test.ts Source files: - src/stores/modelStore.ts - Improved type handling ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - All affected test files pass (`pnpm test:unit`) - Linting passes without errors (`pnpm lint`) - Code formatting applied (`pnpm format`) Part of the "Road to No Explicit Any" initiative, cleaning up type casting issues from branch `fix/remove-any-types-part8`. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 (this PR) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8459-Road-to-No-explicit-any-Group-8-part-7-test-files-2f86d73d36508114ad28d82e72a3a5e9) by [Unito](https://www.unito.io)

## Summary This PR removes unsafe type assertions ("as unknown as Type") from test files and improves type safety across the codebase. ### Key Changes #### Type Safety Improvements - Removed improper `as unknown as Type` patterns from test files in Group 8 part 8 - Replaced with proper TypeScript patterns using Pinia store testing patterns - Fixed parameter shadowing issue in typeGuardUtil.test.ts (constructor → nodeConstructor) - Fixed stale mock values in useConflictDetection.test.ts using getter functions - Refactored useManagerState tests to follow proper Pinia store testing patterns with createTestingPinia ### Files Changed Test files (Group 8 part 8 - utils and manager composables): - src/utils/typeGuardUtil.test.ts - Fixed parameter shadowing - src/utils/graphTraversalUtil.test.ts - Removed unsafe type assertions - src/utils/litegraphUtil.test.ts - Improved type handling - src/workbench/extensions/manager/composables/useManagerState.test.ts - Complete rewrite using Pinia testing patterns - src/workbench/extensions/manager/composables/useConflictDetection.test.ts - Fixed stale mock values with getters - src/workbench/extensions/manager/composables/useManagerQueue.test.ts - Type safety improvements - src/workbench/extensions/manager/composables/nodePack/useMissingNodes.test.ts - Removed unsafe casts - src/workbench/extensions/manager/composables/nodePack/usePacksSelection.test.ts - Type improvements - src/workbench/extensions/manager/composables/nodePack/usePacksStatus.test.ts - Type improvements - src/workbench/extensions/manager/utils/versionUtil.test.ts - Type safety fixes Source files (minor type fixes): - src/utils/fuseUtil.ts - Type improvements - src/utils/linkFixer.ts - Type safety fixes - src/utils/syncUtil.ts - Type improvements - src/workbench/extensions/manager/composables/nodePack/useWorkflowPacks.ts - Type fix - src/workbench/extensions/manager/composables/useConflictAcknowledgment.ts - Type fix ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - All affected test files pass (`pnpm test:unit`) - Linting passes without errors (`pnpm lint`) - Code formatting applied (`pnpm format`) Part of the "Road to No Explicit Any" initiative, cleaning up type casting issues from branch `fix/remove-any-types-part8`. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 (this PR) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8496-Road-to-No-explicit-any-Group-8-part-8-test-files-2f86d73d365081f3afdcf8d01fba81e1) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>

## Summary This PR removes `any` types from UI component files and replaces them with proper TypeScript types. ### Key Changes #### Type Safety Improvements - Replaced `any` with `unknown`, explicit types, or proper interfaces across UI components - Used `ComponentPublicInstance` with explicit method signatures for component refs - Used `Record<string, unknown>` for dynamic property access - Added generics for form components with flexible value types - Used `CSSProperties` for style objects ### Files Changed UI Components: - src/components/common/ComfyImage.vue - Used proper class prop type - src/components/common/DeviceInfo.vue - Used `string | number` for formatValue - src/components/common/FormItem.vue - Used `unknown` for model value - src/components/common/FormRadioGroup.vue - Added generic type parameter - src/components/common/TreeExplorer.vue - Used proper async function signature - src/components/custom/widget/WorkflowTemplateSelectorDialog.vue - Fixed duplicate import - src/components/graph/CanvasModeSelector.vue - Used `ComponentPublicInstance` for ref - src/components/node/NodePreview.vue - Changed `any` to `unknown` - src/components/queue/job/JobDetailsPopover.vue - Removed unnecessary casts - src/components/queue/job/JobFiltersBar.vue - Removed `as any` casts - src/platform/assets/components/MediaAssetContextMenu.vue - Added `ContextMenuInstance` type - src/renderer/extensions/minimap/MiniMapPanel.vue - Used `CSSProperties` - src/renderer/extensions/vueNodes/composables/useNodeTooltips.ts - Added `PrimeVueTooltipElement` interface - src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue - Used `Record<string, unknown>` - src/workbench/extensions/manager/components/manager/infoPanel/tabs/DescriptionTabPanel.vue - Added `LicenseObject` interface ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - Linting passes without errors (`pnpm lint`) Part of the "Road to No Explicit Any" initiative. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 - Part 9: #8498 - Part 10: #8499 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-8499-Road-to-No-Explicit-Any-Part-10-2f86d73d365081aab129f165c7d02434) by [Unito](https://www.unito.io)

## Summary This PR removes `any` types from core source files and replaces them with proper TypeScript types. ### Key Changes #### Type Safety Improvements - Replaced `any` with `unknown`, explicit types, or proper interfaces across core files - Introduced new type definitions: `SceneConfig`, `Load3DNode`, `ElectronWindow` - Used `Object.assign` instead of `as any` for dynamic property assignment - Replaced `as any` casts with proper type assertions ### Files Changed Source files: - src/extensions/core/widgetInputs.ts - Removed unnecessary `as any` cast - src/platform/cloud/onboarding/auth.ts - Used `Record<string, unknown>` and Sentry types - src/platform/telemetry/providers/cloud/MixpanelTelemetryProvider.ts - Used `AuditLog[]` type - src/platform/workflow/management/stores/workflowStore.ts - Used `typeof ComfyWorkflow` constructor type - src/scripts/app.ts - Used `ResultItem[]` for Clipspace images - src/services/colorPaletteService.ts - Used `Object.assign` instead of `as any` - src/services/customerEventsService.ts - Used `unknown` instead of `any` - src/services/load3dService.ts - Added proper interface types for Load3D nodes - src/types/litegraph-augmentation.d.ts - Used `TWidgetValue[]` type - src/utils/envUtil.ts - Added ElectronWindow interface - src/workbench/extensions/manager/stores/comfyManagerStore.ts - Typed event as `CustomEvent<{ ui_id?: string }>` ### Testing - All TypeScript type checking passes (`pnpm typecheck`) - Linting passes without errors (`pnpm lint`) - Code formatting applied (`pnpm format`) Part of the "Road to No Explicit Any" initiative. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 - Part 9: #8498 (this PR)

@public

## Summary This PR removes `any` types from widgets, services, stores, and test files, replacing them with proper TypeScript types. ### Key Changes #### Type Safety Improvements - Replaced `any` with `unknown`, explicit types, or proper interfaces across widgets and services - Added proper type imports (TgpuRoot, Point, StyleValue, etc.) - Created typed interfaces (NumericWidgetOptions, TestWindow, ImportFailureDetail, etc.) - Fixed function return types to be non-nullable where appropriate - Added type guards and null checks instead of non-null assertions - Used `ComponentProps` from vue-component-type-helpers for component testing #### Widget System - Added index signature to IWidgetOptions for Record compatibility - Centralized disabled logic in WidgetInputNumberInput - Moved template type assertions to computed properties - Fixed ComboWidget getOptionLabel type assertions - Improved remote widget type handling with runtime checks #### Services & Stores - Fixed getOrCreateViewer to return non-nullable values - Updated addNodeOnGraph to use specific options type `{ pos?: Point }` - Added proper type assertions for settings store retrieval - Fixed executionIdToCurrentId return type (string | undefined) #### Test Infrastructure - Exported GraphOrSubgraph from litegraph barrel to avoid circular dependencies - Updated test fixtures with proper TypeScript types (TestInfo, LGraphNode) - Replaced loose Record types with ComponentProps in tests - Added proper error handling in WebSocket fixture #### Code Organization - Created shared i18n-types module for locale data types - Made ImportFailureDetail non-exported (internal use only) - Added @public JSDoc tag to ElectronWindow type - Fixed console.log usage in scripts to use allowed methods ### Files Changed **Widgets & Components:** - src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue - src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue - src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue - src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue - src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.ts - src/lib/litegraph/src/widgets/ComboWidget.ts - src/lib/litegraph/src/types/widgets.ts - src/components/common/LazyImage.vue - src/components/load3d/Load3dViewerContent.vue **Services & Stores:** - src/services/litegraphService.ts - src/services/load3dService.ts - src/services/colorPaletteService.ts - src/stores/maskEditorStore.ts - src/stores/nodeDefStore.ts - src/platform/settings/settingStore.ts - src/platform/workflow/management/stores/workflowStore.ts **Composables & Utils:** - src/composables/node/useWatchWidget.ts - src/composables/useCanvasDrop.ts - src/utils/widgetPropFilter.ts - src/utils/queueDisplay.ts - src/utils/envUtil.ts **Test Files:** - browser_tests/fixtures/ComfyPage.ts - browser_tests/fixtures/ws.ts - browser_tests/tests/actionbar.spec.ts - src/workbench/extensions/manager/components/manager/skeleton/PackCardGridSkeleton.test.ts - src/lib/litegraph/src/subgraph/subgraphUtils.test.ts - src/components/rightSidePanel/shared.test.ts - src/platform/cloud/subscription/composables/useSubscription.test.ts - src/platform/workflow/persistence/composables/useWorkflowPersistence.test.ts **Scripts & Types:** - scripts/i18n-types.ts (new shared module) - scripts/diff-i18n.ts - scripts/check-unused-i18n-keys.ts - src/workbench/extensions/manager/types/conflictDetectionTypes.ts - src/types/algoliaTypes.ts - src/types/simplifiedWidget.ts **Infrastructure:** - src/lib/litegraph/src/litegraph.ts (added GraphOrSubgraph export) - src/lib/litegraph/src/infrastructure/CustomEventTarget.ts - src/platform/assets/services/assetService.ts **Stories:** - apps/desktop-ui/src/views/InstallView.stories.ts - src/components/queue/job/JobDetailsPopover.stories.ts **Extension Manager:** - src/workbench/extensions/manager/composables/useConflictDetection.ts - src/workbench/extensions/manager/composables/useManagerQueue.ts - src/workbench/extensions/manager/services/comfyManagerService.ts - src/workbench/extensions/manager/utils/conflictMessageUtil.ts ### Testing - [x] All TypeScript type checking passes (`pnpm typecheck`) - [x] ESLint passes without errors (`pnpm lint`) - [x] Format checks pass (`pnpm format:check`) - [x] Knip (unused exports) passes (`pnpm knip`) - [x] Pre-commit and pre-push hooks pass Part of the "Road to No Explicit Any" initiative. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 - Part 9: #8498 - Part 10: #8499 --------- Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>

@public

## Summary This PR removes `any` types from widgets, services, stores, and test files, replacing them with proper TypeScript types. ### Key Changes #### Type Safety Improvements - Replaced `any` with `unknown`, explicit types, or proper interfaces across widgets and services - Added proper type imports (TgpuRoot, Point, StyleValue, etc.) - Created typed interfaces (NumericWidgetOptions, TestWindow, ImportFailureDetail, etc.) - Fixed function return types to be non-nullable where appropriate - Added type guards and null checks instead of non-null assertions - Used `ComponentProps` from vue-component-type-helpers for component testing #### Widget System - Added index signature to IWidgetOptions for Record compatibility - Centralized disabled logic in WidgetInputNumberInput - Moved template type assertions to computed properties - Fixed ComboWidget getOptionLabel type assertions - Improved remote widget type handling with runtime checks #### Services & Stores - Fixed getOrCreateViewer to return non-nullable values - Updated addNodeOnGraph to use specific options type `{ pos?: Point }` - Added proper type assertions for settings store retrieval - Fixed executionIdToCurrentId return type (string | undefined) #### Test Infrastructure - Exported GraphOrSubgraph from litegraph barrel to avoid circular dependencies - Updated test fixtures with proper TypeScript types (TestInfo, LGraphNode) - Replaced loose Record types with ComponentProps in tests - Added proper error handling in WebSocket fixture #### Code Organization - Created shared i18n-types module for locale data types - Made ImportFailureDetail non-exported (internal use only) - Added @public JSDoc tag to ElectronWindow type - Fixed console.log usage in scripts to use allowed methods ### Files Changed **Widgets & Components:** - src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberInput.vue - src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue - src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue - src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue - src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.ts - src/lib/litegraph/src/widgets/ComboWidget.ts - src/lib/litegraph/src/types/widgets.ts - src/components/common/LazyImage.vue - src/components/load3d/Load3dViewerContent.vue **Services & Stores:** - src/services/litegraphService.ts - src/services/load3dService.ts - src/services/colorPaletteService.ts - src/stores/maskEditorStore.ts - src/stores/nodeDefStore.ts - src/platform/settings/settingStore.ts - src/platform/workflow/management/stores/workflowStore.ts **Composables & Utils:** - src/composables/node/useWatchWidget.ts - src/composables/useCanvasDrop.ts - src/utils/widgetPropFilter.ts - src/utils/queueDisplay.ts - src/utils/envUtil.ts **Test Files:** - browser_tests/fixtures/ComfyPage.ts - browser_tests/fixtures/ws.ts - browser_tests/tests/actionbar.spec.ts - src/workbench/extensions/manager/components/manager/skeleton/PackCardGridSkeleton.test.ts - src/lib/litegraph/src/subgraph/subgraphUtils.test.ts - src/components/rightSidePanel/shared.test.ts - src/platform/cloud/subscription/composables/useSubscription.test.ts - src/platform/workflow/persistence/composables/useWorkflowPersistence.test.ts **Scripts & Types:** - scripts/i18n-types.ts (new shared module) - scripts/diff-i18n.ts - scripts/check-unused-i18n-keys.ts - src/workbench/extensions/manager/types/conflictDetectionTypes.ts - src/types/algoliaTypes.ts - src/types/simplifiedWidget.ts **Infrastructure:** - src/lib/litegraph/src/litegraph.ts (added GraphOrSubgraph export) - src/lib/litegraph/src/infrastructure/CustomEventTarget.ts - src/platform/assets/services/assetService.ts **Stories:** - apps/desktop-ui/src/views/InstallView.stories.ts - src/components/queue/job/JobDetailsPopover.stories.ts **Extension Manager:** - src/workbench/extensions/manager/composables/useConflictDetection.ts - src/workbench/extensions/manager/composables/useManagerQueue.ts - src/workbench/extensions/manager/services/comfyManagerService.ts - src/workbench/extensions/manager/utils/conflictMessageUtil.ts ### Testing - [x] All TypeScript type checking passes (`pnpm typecheck`) - [x] ESLint passes without errors (`pnpm lint`) - [x] Format checks pass (`pnpm format:check`) - [x] Knip (unused exports) passes (`pnpm knip`) - [x] Pre-commit and pre-push hooks pass Part of the "Road to No Explicit Any" initiative. ### Previous PRs in this series: - Part 2: #7401 - Part 3: #7935 - Part 4: #7970 - Part 5: #8064 - Part 6: #8083 - Part 7: #8092 - Part 8 Group 1: #8253 - Part 8 Group 2: #8258 - Part 8 Group 3: #8304 - Part 8 Group 4: #8314 - Part 8 Group 5: #8329 - Part 8 Group 6: #8344 - Part 8 Group 7: #8459 - Part 8 Group 8: #8496 - Part 9: #8498 - Part 10: #8499 --------- Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: christian-byrne <72887196+christian-byrne@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>

Myestery added 5 commits January 15, 2026 01:07

fix(load3d): type EventCallback and event methods with generics

21eb45f

fix(load3d): type setupModelAnimations originalModel parameter

b946110

fix(load3d): type node parameters in handleModelUpload and handleReso…

5b3660f

…urcesUpload

fix(load3d): type onExecuted callback with NodeExecutionOutput

9a392b6

fix(load3d): type Camera Config property casts with CameraConfig

0d767d5

Myestery requested review from a team and jtydhr88 as code owners January 15, 2026 00:58

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 15, 2026

coderabbitai bot requested review from DrJKL and simula-r January 15, 2026 00:59

Myestery assigned jtydhr88 Jan 15, 2026

jtydhr88 previously approved these changes Jan 15, 2026

View reviewed changes

coderabbitai bot reviewed Jan 15, 2026

View reviewed changes

src/composables/useLoad3d.ts Show resolved Hide resolved

src/extensions/core/load3d.ts Show resolved Hide resolved

fix(load3d): use Record<string, unknown> pattern for output.result ac…

9e2a0ec

…cess

Myestery dismissed jtydhr88’s stale review via 9e2a0ec January 15, 2026 01:14

Myestery enabled auto-merge (squash) January 15, 2026 01:16

Myestery disabled auto-merge January 15, 2026 01:21

Myestery merged commit 538f007 into main Jan 15, 2026
27 checks passed

Myestery deleted the fix/remove-any-types-part5 branch January 15, 2026 01:21

coderabbitai bot mentioned this pull request Jan 15, 2026

Road to No Explicit Any Part 6: Composables and Extensions #8083

Merged

4 tasks

Myestery mentioned this pull request Jan 29, 2026

Road to No explicit any: Group 8 (part 6) test files #8344

Merged

Myestery mentioned this pull request Jan 30, 2026

Road to No explicit any: Group 8 (part 7) test files #8459

Merged

Myestery mentioned this pull request Jan 30, 2026

Road to No explicit any: Group 8 (part 8) test files #8496

Merged

This was referenced Jan 30, 2026

Road to No Explicit Any Part 9 #8498

Merged

Road to No Explicit Any Part 10 #8499

Merged

Myestery mentioned this pull request Feb 3, 2026

Road to No Explicit Any Part 11 #8565

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Road to No Explicit Any Part 5: load3d Module#8064

Road to No Explicit Any Part 5: load3d Module#8064
Myestery merged 6 commits intomainfrom
fix/remove-any-types-part5

Myestery commented Jan 15, 2026 •

edited by sync-by-unito bot

Loading

Uh oh!

coderabbitai bot commented Jan 15, 2026 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

jtydhr88 left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Myestery commented Jan 15, 2026 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

coderabbitai bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

github-actions bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Tests: ⚠️ Passed with flaky tests

❌ Failed Tests

Uh oh!

jtydhr88 left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2026

Bundle Size Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Myestery commented Jan 15, 2026 •

edited by sync-by-unito bot

Loading

coderabbitai bot commented Jan 15, 2026 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading

github-actions bot commented Jan 15, 2026 •

edited

Loading