feat: add animation progress bar for 3D nodes and viewer#7839
Conversation
dosubot
bot
added
the
size:L
📝 WalkthroughWalkthroughAdded animation progress seeking capability to 3D model viewer through a new draggable progress slider in the AnimationControls component. Integrated animation state management across composables and the Load3d animation engine, enabling users to seek to specific points in longer animations rather than watching from the beginning. Changes
Sequence DiagramsequenceDiagram
participant User
participant AnimationControls as AnimationControls<br/>(UI)
participant Load3DViewer as Load3dViewerContent<br/>(Container)
participant useViewer as useLoad3dViewer<br/>(Composable)
participant Load3d as Load3d Instance<br/>(Core Engine)
participant AnimMgr as AnimationManager<br/>(Animation State)
User->>AnimationControls: Drag slider to seek position
AnimationControls->>AnimationControls: handleSliderChange(newProgress)
AnimationControls->>AnimationControls: emit seek(newProgress)
AnimationControls->>Load3DViewer: `@seek` event
Load3DViewer->>useViewer: handleSeek(progress)
useViewer->>useViewer: Compute time from progress
useViewer->>Load3d: setAnimationTime(time)
Load3d->>AnimMgr: setAnimationTime(time)
AnimMgr->>AnimMgr: Clamp & update action.currentTime
AnimMgr->>AnimMgr: Sync with mixer
AnimMgr->>AnimMgr: emit animationProgressChange
AnimMgr->>useViewer: animationProgressChange event
useViewer->>useViewer: Update animationProgress,<br/>animationDuration refs
useViewer-->>AnimationControls: v-model update
AnimationControls-->>User: Display updated time & slider position
Load3d->>Load3d: forceRender()
Load3d-->>User: Updated 3D view
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/04/2026, 03:07:33 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 01/04/2026, 03:12:44 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.23 MB (baseline 3.21 MB) • 🔴 +14.3 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1000 kB (baseline 1000 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 193 kB (baseline 199 kB) • 🟢 -5.66 kBReusable component library chunks
Status: 10 added / 10 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.12 MB (baseline 9.12 MB) • 🔴 +1.1 kBExternal libraries and shared vendor chunks
Status: 6 added / 6 removed Other — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BBundles that do not match a named category
Status: 25 added / 25 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (9)
src/components/load3d/Load3D.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3d.tssrc/composables/useLoad3dViewer.tssrc/extensions/core/load3d/AnimationManager.tssrc/extensions/core/load3d/Load3d.tssrc/extensions/core/load3d/interfaces.tssrc/services/load3dService.ts
🧰 Additional context used
📓 Path-based instructions (16)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vuesrc/services/load3dService.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vuesrc/services/load3dService.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vuesrc/services/load3dService.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not useanytype oras anytype assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vuesrc/services/load3dService.ts
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vuesrc/services/load3dService.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Minimize the surface area (exported values) of each module and composable
Files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/composables/useLoad3d.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/composables/useLoad3d.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/composables/useLoad3d.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
**/**/use[A-Z]*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Name composables using the pattern
useXyz.ts
Files:
src/composables/useLoad3d.tssrc/composables/useLoad3dViewer.ts
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components
Files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3.5+ with TypeScript in.vuefiles, exclusively using Composition API with<script setup lang="ts">syntax
Use Tailwind 4 for styling in Vue components; avoid<style>blocks
Name Vue components using PascalCase (e.g.,MenuHamburger.vue)
Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
Prefercomputed()overrefwithwatchwhen deriving values
PreferuseModelover separately defining prop and emit for two-way binding
Usevue-i18nin composition API for string literals; place new translation entries insrc/locales/en/main.json
Usecn()utility function from@/utils/tailwindUtilfor merging Tailwind class names; do not use:class="[]"syntax
Do not use thedark:Tailwind variant; use semantic values from thestyle.csstheme instead (e.g.,bg-node-component-surface)
Do not use!importantor the!important prefix for Tailwind classes; find and correct interfering!importantclasses instead
Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Leverage VueUse functions for performance-enhancing styles in Vue components
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
🧠 Learnings (24)
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
📚 Learning: 2025-12-30T22:22:33.836Z
Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().
Applied to files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/composables/useLoad3dViewer.tssrc/services/load3dService.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/extensions/core/load3d/interfaces.tssrc/extensions/core/load3d/Load3d.tssrc/composables/useLoad3d.tssrc/extensions/core/load3d/AnimationManager.tssrc/components/load3d/controls/AnimationControls.vuesrc/composables/useLoad3dViewer.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vuesrc/services/load3dService.ts
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/Load3D.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use Vue 3.5+ with TypeScript in `.vue` files, exclusively using Composition API with `<script setup lang="ts">` syntax
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/components/load3d/Load3dViewerContent.vuesrc/services/load3dService.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize Vue 3's Teleport component when needed
Applied to files:
src/components/load3d/Load3dViewerContent.vuesrc/services/load3dService.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use setup() function in Vue 3 Composition API
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use setup() function for component logic
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement lifecycle hooks with onMounted, onUpdated, etc.
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use ref/reactive for state management in Vue 3 Composition API
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use Teleport/Suspense when needed for component rendering
Applied to files:
src/components/load3d/Load3dViewerContent.vue
📚 Learning: 2025-12-18T20:39:30.137Z
Learnt from: jtydhr88
Repo: Comfy-Org/ComfyUI_frontend PR: 7621
File: src/components/load3d/Load3DScene.vue:4-4
Timestamp: 2025-12-18T20:39:30.137Z
Learning: In src/components/load3d/Load3DScene.vue, the scoped `<style>` block with `!important` declarations for the canvas element is necessary because Three.js dynamically creates the canvas with inline styles, preventing direct application of Tailwind classes. This is a valid exception to the Tailwind-only styling guideline.
Applied to files:
src/services/load3dService.ts
🧬 Code graph analysis (2)
src/extensions/core/load3d/AnimationManager.ts (1)
src/scripts/app.ts (1)
progress(270-272)
src/composables/useLoad3dViewer.ts (1)
src/extensions/core/load3d/interfaces.ts (1)
AnimationItem(81-84)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint-and-format
- GitHub Check: collect
- GitHub Check: setup
- GitHub Check: test
🔇 Additional comments (24)
src/services/load3dService.ts (3)
2-2: LGTM! Proper import for skeletal animation support.The SkeletonUtils import is necessary for correctly cloning models with skeletal animations, preserving bone hierarchies and animation data.
79-83: LGTM! Proper cleanup before model replacement.Removing the existing model before adding the new one prevents scene duplication and potential memory leaks. This is good defensive coding practice.
118-123: Consider adding explicit null check for clarity.While
setupModelAnimations()safely handles a nullsourceOriginalModelthrough defensive null-checking (line 51 in AnimationManager), passing a potentially null value is implicit. For code clarity, consider guarding the call:if (source.hasAnimations() && sourceOriginalModel) { target.animationManager.setupModelAnimations( modelClone, sourceOriginalModel ) }This makes the contract explicit and prevents unnecessary function calls when animations exist but
originalModelis unavailable.src/extensions/core/load3d/interfaces.ts (1)
149-151: LGTM! Well-defined interface additions for animation control.The three new methods provide a clean public API for reading and controlling animation timing. The signatures are properly typed and consistent with the existing interface conventions.
src/extensions/core/load3d/Load3d.ts (1)
729-740: LGTM! Proper delegation with render synchronization.The three new methods correctly delegate to the animation manager and follow the established pattern. The
forceRender()call insetAnimationTimeensures the display updates immediately after seeking, which is essential for responsive UI feedback.src/composables/useLoad3d.ts (4)
63-64: LGTM! New animation state properties.The
animationProgressandanimationDurationrefs provide the necessary reactive state for the progress bar feature. They are properly initialized and integrated with the event system.
362-367: LGTM! Proper defensive checks in seek handler.The
handleSeekfunction includes appropriate guards:
- Verifies
load3dexists before calling methods- Checks
animationDuration.value > 0to prevent division by zero- Correctly converts progress (0-100 range) to time in seconds
The implementation is safe and follows best practices.
526-533: LGTM! Animation progress event handling.The
animationProgressChangeevent handler correctly updates bothanimationProgressandanimationDurationfrom the event data. This enables reactive updates when the animation playback advances.
593-594: LGTM! Properly exposed public API.The new animation state properties and
handleSeekhandler are correctly exposed in the composable's return object, making them available to consuming components.Also applies to: 607-607
src/components/load3d/Load3D.vue (2)
36-38: LGTM!The new animation progress bindings are correctly wired:
v-model:animation-progress,v-model:animation-duration, and@seekevent are properly connected to the composable's state and handler.
125-127: LGTM!The destructuring of
animationProgress,animationDuration, andhandleSeekfromuseLoad3dcorrectly exposes the new animation control API for use in the template bindings.Also applies to: 138-138
src/extensions/core/load3d/AnimationManager.ts (3)
128-134: LGTM!Emitting initial progress with duration when an animation is selected ensures the UI starts with correct state. This enables the progress bar to display the correct duration immediately.
160-171: LGTM!The guard check for
animationActions.length > 0before emitting progress prevents potential errors when no actions exist. The progress calculation correctly derives percentage from action time and clip duration.
174-182: LGTM!Simple and correct getter implementations with appropriate fallback to 0 when no animation actions exist.
src/components/load3d/controls/AnimationControls.vue (5)
6-21: LGTM!The play/pause button correctly uses the repo's Button component with appropriate icon handling and i18n-translated aria-label.
69-78: LGTM!The model definitions for
animationProgressandanimationDurationwith defaults, plus the typed emit forseek, correctly establish the component's public API for animation control.
88-97: LGTM!The
currentTimecomputed property andformatTimeutility are well-implemented. The format logic correctly handles both sub-minute and multi-minute durations with proper zero-padding.
103-108: LGTM!The handler correctly guards against undefined values, updates the model, and emits the seek event for parent components to handle.
40-52: Consider adding accessibility attributes to the slider.The slider lacks an accessible label. Screen reader users won't understand its purpose.
🔎 Proposed fix
<Slider :model-value="[animationProgress]" :min="0" :max="100" :step="0.1" class="flex-1" + :aria-label="$t('load3d.animationProgress')" @update:model-value="handleSliderChange" />Add the translation key to
src/locales/en/main.json:{ "load3d": { "animationProgress": "Animation progress" } }⛔ Skipped due to learnings
Learnt from: DrJKL Repo: Comfy-Org/ComfyUI_frontend PR: 7603 File: src/components/queue/QueueOverlayHeader.vue:49-59 Timestamp: 2025-12-18T21:15:54.349Z Learning: For Vue components in Comfy-Org/ComfyUI_frontend: Do not suggest adding aria-label to buttons that already have visible text content (e.g., <span> elements with labels). The visible text automatically provides the accessible name. aria-label should only be used for elements without visible labels, such as icon-only buttons.src/composables/useLoad3dViewer.ts (5)
53-59: LGTM!Animation state refs are properly typed and initialized with sensible defaults.
186-203: Verify edge case: speed value of 0 will be skipped.The condition
if (load3d && newValue)on line 194 will skip updating whennewValueis 0 (falsy). While 0 speed is likely not a valid option in the UI, consider using explicit undefined/null checks for robustness.🔎 Proposed fix (if 0 speed should be allowed)
watch(selectedSpeed, (newValue) => { - if (load3d && newValue) { + if (load3d && newValue !== undefined) { load3d.setAnimationSpeed(newValue) } })
205-210: LGTM!The seek handler correctly converts progress percentage to time and guards against missing load3d instance or zero duration.
337-338: LGTM!The
setupAnimationEvents()call is correctly placed after load3d initialization and state copying in both node mode and standalone mode initialization paths.Also applies to: 379-380
598-604: LGTM!The new animation state and
handleSeekmethod are correctly exported, completing the public API surface for animation control in the viewer.Also applies to: 618-618
2 participants
Summary
fix #7830 and #7831
Screenshots (if applicable)
2026-01-03.22-04-25.mp4
┆Issue is synchronized with this Notion page by Unito