Skip to content

[backport cloud/1.36] Fix linked asset widget promotion in vue#8003

Merged
christian-byrne merged 1 commit intocloud/1.36from
backport-7895-to-cloud-1.36
Jan 13, 2026
Merged

[backport cloud/1.36] Fix linked asset widget promotion in vue#8003
christian-byrne merged 1 commit intocloud/1.36from
backport-7895-to-cloud-1.36

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Jan 13, 2026

Backport of #7895 to cloud/1.36

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

Asset widgets resolve the list of models by checking the name of the
node the widget is contained on. When an asset widget is linked to a
subgraph node, a clone is made of the widget and then the clone is used
to initialize an asset widget in vue mode. Since the widget no longer
holds any form of reference to the original node, asset data fails to
resolve.

This is fixed by storing the original nodeType as an option on the
cloned widget when an asset widget is linked to a subgraph input.

| Before | After |
| ------ | ----- |
| <img width="360" alt="before"
src="https://github.com/user-attachments/assets/345f9cc1-da04-44ab-8fed-76379c8528de"/>
| <img width="360" alt="after"
src="https://github.com/user-attachments/assets/88d1ddaa-56fb-41b3-8d5d-0ded02aaa7d2"
/>|

See also #7563, #7560

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7895-Fix-linked-asset-widget-promotion-in-vue-2e26d73d365081e5b295f6236458b978)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 13, 2026
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner January 13, 2026 04:21
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jan 13, 2026
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 01/13/2026, 04:22:45 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 01/13/2026, 04:28:01 AM UTC

📈 Summary

  • Total Tests: 512
  • Passed: 502 ✅
  • Failed: 1 ❌
  • Flaky: 1 ⚠️
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 492 / ❌ 1 / ⚠️ 0 / ⏭️ 8
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit 74ebfec into cloud/1.36 Jan 13, 2026
36 of 37 checks passed
@christian-byrne christian-byrne deleted the backport-7895-to-cloud-1.36 branch January 13, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants