Fix selecting loras on cloud #7560
Conversation
dosubot
bot
added
the
size:XS
📝 WalkthroughWalkthroughThe changes modify widget callback invocation logic across two components. In Changes
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results⏰ Completed at: 12/16/2025, 07:53:29 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/16/2025, 07:41:03 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.25 MB (baseline 3.25 MB) • 🟢 -55 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 992 kB (baseline 992 kB) • 🔴 +37 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 299 kB (baseline 299 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.75 MB (baseline 3.75 MB) • ⚪ 0 BBundles that do not match a named category
Status: 19 added / 19 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue (1)
231-247: Remove redundant manual emit -defineModelemits automatically.Line 245 sets
modelValue.value = name, which automatically emitsupdate:modelValuethrough thedefineModelmacro. The manual emit on line 246 creates a duplicate event, causing the parent component to receive the update twice. This could lead to unintended side effects if the parent's update handler performs actions like API calls or state mutations.Based on learnings, prefer
defineModelto separately defining a prop and emit.Apply this diff to remove the redundant manual emit:
modelValue.value = name - emit('update:modelValue', name) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue(2 hunks)
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use<script setup lang="ts">for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
PreferuseModelto separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using<style>blocks in Vue components
Use semantic Tailwind values fromstyle.csstheme instead of thedark:variant; for example, usebg-node-component-surfaceinstead ofdark:prefixes
Always usecn()utility from@/utils/tailwindUtilto merge Tailwind class names; do not use:class="[]"syntax
Usereffor reactive state in Vue Composition API components
Implement computed properties withcomputed()from Vue; avoid using arefwith awatchif acomputedwould work instead
UsewatchandwatchEffectfor side effects in Vue components
Implement lifecycle hooks usingonMounted,onUpdated, and other Vue lifecycle functions
Useprovide/injectfor dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundantcomputed, and prefercomputedoverwatch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries insrc/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
**/*.{ts,tsx,js,jsx,vue,json}
📄 CodeRabbit inference engine (AGENTS.md)
Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see
.prettierrc)
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; runpnpm formatbefore committing
Use TypeScript for type safety; never useanytype - use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nestediforforstatements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
🧠 Learnings (11)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Prefer `useModel` to separately defining a prop and emit
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : In Vue Components, implement proper props and emits definitions
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Define proper props and emits definitions in Vue components
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Prefer emit/event-name for state changes over other communication patterns
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement proper props and emits definitions
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Define proper props and emits definitions in Vue components
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Prefer emit/event-name for state changes over other communication patterns
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement proper props and emits definitions
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : In Vue Components, implement proper props and emits definitions
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Prefer `useModel` to separately defining a prop and emit
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: collect
- GitHub Check: lint-and-format
🔇 Additional comments (1)
src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue (1)
305-311: Verify if direct prop mutation is intentional.Line 309 directly mutates
props.widget.options.valuesby pushing new paths. While direct prop mutation is generally discouraged in Vue, this might be intentional for the LiteGraph integration where widget objects are expected to be mutable.Please confirm this is the intended pattern for updating widget values in the LiteGraph context.
| return props.widget.options?.values?.[0] || '' | ||
| } | ||
| }) | ||
| const emit = defineEmits(['update:modelValue']) |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Remove redundant defineEmits - defineModel already handles this.
The defineModel macro (lines 46-50) automatically creates both the prop and the emit handler for update:modelValue. Manually declaring the emit is redundant and violates the coding guideline to prefer defineModel over separately defining props and emits.
Based on learnings, prefer useModel to separately defining a prop and emit.
Apply this diff to remove the redundant emit definition:
-const emit = defineEmits(['update:modelValue'])
-
const toastStore = useToastStore()Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue
around line 51, remove the redundant "const emit =
defineEmits(['update:modelValue'])" since defineModel already creates the prop
and emit; delete this line and any direct uses of the local "emit" variable
(replace them with the model updater from defineModel or switch to useModel if
you need a composable API), ensuring update:modelValue is still emitted via the
model helper instead of the removed emit variable.
AustinMroz
force-pushed
the
austin/cloud-vue-lora
branch
from
ac7fa36 to
1ab474f
Compare
dosubot
bot
added
size:S
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/composables/graph/useGraphNodeManager.ts(2 hunks)src/renderer/extensions/vueNodes/components/NodeWidgets.vue(1 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use<script setup lang="ts">for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
PreferuseModelto separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using<style>blocks in Vue components
Use semantic Tailwind values fromstyle.csstheme instead of thedark:variant; for example, usebg-node-component-surfaceinstead ofdark:prefixes
Always usecn()utility from@/utils/tailwindUtilto merge Tailwind class names; do not use:class="[]"syntax
Usereffor reactive state in Vue Composition API components
Implement computed properties withcomputed()from Vue; avoid using arefwith awatchif acomputedwould work instead
UsewatchandwatchEffectfor side effects in Vue components
Implement lifecycle hooks usingonMounted,onUpdated, and other Vue lifecycle functions
Useprovide/injectfor dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundantcomputed, and prefercomputedoverwatch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries insrc/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
**/*.{ts,tsx,js,jsx,vue,json}
📄 CodeRabbit inference engine (AGENTS.md)
Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see
.prettierrc)
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; runpnpm formatbefore committing
Use TypeScript for type safety; never useanytype - use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nestediforforstatements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safetyMinimize the surface area (exported values) of each module and composable
Files:
src/composables/graph/useGraphNodeManager.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/composables/graph/useGraphNodeManager.ts
src/composables/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Composable files must follow the naming pattern
useXyz.ts
Files:
src/composables/graph/useGraphNodeManager.ts
🧠 Learnings (7)
📓 Common learnings
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:57.926Z
Learning: In src/renderer/extensions/vueNodes/components/ImagePreview.vue and LGraphNode.vue, keyboard navigation for image galleries should respond to node-level focus (via keyEvent injection from LGraphNode), not require focus within the image preview wrapper itself. This allows users to navigate the gallery with arrow keys immediately when the node is focused/selected.
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/composables/graph/useGraphNodeManager.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/composables/graph/useGraphNodeManager.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/composables/graph/useGraphNodeManager.ts
🧬 Code graph analysis (1)
src/composables/graph/useGraphNodeManager.ts (2)
src/lib/litegraph/src/types/widgets.ts (1)
IBaseWidget(271-429)src/lib/litegraph/src/widgets/BaseWidget.ts (2)
value(100-102)value(104-106)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (3)
src/composables/graph/useGraphNodeManager.ts (2)
340-340: LGTM: Improved type safety.Expanding the widget parameter type from a minimal shape to
IBaseWidgetprovides better type safety and aligns with the canonical widget interface definition.
367-367: This behavioral change is safe and follows Vue best practices.The change normalizes
nulltoundefinedthrough the nullish coalescing operator, which is idiomatic JavaScript. Downstream code inuseNodePricing.tsexplicitly handles bothnullandundefinedwith OR logic, treating them identically. Vue documentation endorses using either value as a placeholder for undefined state, making this normalization a consistency improvement rather than a breaking change.src/renderer/extensions/vueNodes/components/NodeWidgets.vue (1)
179-184: LGTM: Proper separation of concerns.The updateHandler now consistently invokes the widget callback, which is correct because
widget.callbackis the wrapped callback fromcreateWrappedWidgetCallbackinuseGraphNodeManager.ts. The wrapped callback handles the asset widget filtering logic (line 370), properly separating UI concerns from value propagation logic.This change, combined with the asset widget filtering in the manager, ensures that model/lora selections on cloud are properly propagated via emit.
| if (originalCallback && widget.type !== 'asset') { | ||
| originalCallback.call(widget, value) | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Get the file and examine lines 360-380 to understand the callback context
cat -n src/composables/graph/useGraphNodeManager.ts | sed -n '360,380p'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 812
🏁 Script executed:
#!/bin/bash
# Get more context - the full function/section to understand widget handling
cat -n src/composables/graph/useGraphNodeManager.ts | sed -n '320,380p'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 2350
🏁 Script executed:
#!/bin/bash
# Search for asset widget type usage and callback context
rg -n --type=ts --type=vue 'type.*asset' src/composables/graph/ -A 3 -B 3
# Also search for where createWrappedWidgetCallback is called
rg -n 'createWrappedWidgetCallback' src/composables/graph/ -A 3 -B 3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1277
🏁 Script executed:
#!/bin/bash
# Search for asset widget handling and understand the rationale
rg -n 'asset' src/composables/graph/ -A 5 -B 5
# Also look for any PR or issue context about this
git log --oneline -n 20 | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1037
🏁 Script executed:
#!/bin/bash
# Look at the commit that mentioned "Fix selection of assets in vue mode"
git show 1ab474fb --stat
git show 1ab474fb | head -100Repository: Comfy-Org/ComfyUI_frontend
Length of output: 50383
🏁 Script executed:
#!/bin/bash
# Look for the specific change in the commit related to asset widgets
git show 1ab474fb src/composables/graph/useGraphNodeManager.ts | grep -A 20 -B 20 'asset'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 2137
🏁 Script executed:
#!/bin/bash
# Search for "emit" in the widget callback context
rg -n 'emit' src/composables/graph/useGraphNodeManager.ts -B 5 -A 5
# Also search for any comments or context about why asset widgets are special
rg -n 'asset.*emit\|emit.*asset\|model.*emit\|callback.*asset' src/ --type=ts -B 3 -A 3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
🏁 Script executed:
#!/bin/bash
# Search for emit patterns in Vue nodes/widgets
rg -n 'emit' src/composables/graph/ -B 3 -A 3 --type=ts | head -50
# Also search for asset widget type definitions
rg -n '"asset"' src/ --type=ts | head -20Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1041
🏁 Script executed:
#!/bin/bash
# Search for PR references or comments about "Models must be updated"
rg -n 'Models.*emit\|model.*update.*emit' src/ --type=ts -B 5 -A 5
# Look at the full context around the widget callback setup
cat -n src/composables/graph/useGraphNodeManager.ts | sed -n '380,420p'Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1330
🏁 Script executed:
#!/bin/bash
# Search for asset widget callback handling in other files
rg -n 'widget.*type.*asset\|type.*asset.*widget' src/ --type=ts -B 5 -A 5
# Look for any recent changes or TODOs about asset widgets
rg -n 'TODO\|FIXME\|asset' src/composables/graph/useGraphNodeManager.ts | head -30
# Check if there are tests for asset widgets
find . -name "*.spec.ts" -o -name "*.test.ts" | xargs grep -l "asset" 2>/dev/null | head -5Repository: Comfy-Org/ComfyUI_frontend
Length of output: 287
🏁 Script executed:
#!/bin/bash
# Check widget.spec.ts for asset widget tests
rg -n 'asset' browser_tests/tests/widget.spec.ts -B 5 -A 5
# Also search for the PR/issue context in commit messages
git log --oneline --all | grep -i 'asset\|model.*update\|emit' | head -10Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1578
🏁 Script executed:
#!/bin/bash
# Look at the specific PR or issue related to this fix
git log --format="%h %s" --grep='asset' | head -15
# Check for any documentation or comments about the emit pattern
rg -n 'updateVueWidgetState' src/composables/graph/useGraphNodeManager.ts -B 5 -A 10
# Search for how asset widgets are actually used
rg -n 'load.*asset\|asset.*load' src/ --type=ts -i -B 2 -A 2 | head -30Repository: Comfy-Org/ComfyUI_frontend
Length of output: 1078
🏁 Script executed:
#!/bin/bash
# Search for how Vue emits are handled with widgets
rg -n '@update\|@change\|emit' src/components/vue-nodes/ --type=ts --type=vue -B 2 -A 2 | head -50
# Look for asset widget specific handling in Vue components
rg -n 'type.*asset' src/components/vue-nodes/ --type=vue -B 3 -A 3
# Check if there's a model or asset loader component
find src/components -name "*[Aa]sset*" -o -name "*[Ll]oad*" | head -10Repository: Comfy-Org/ComfyUI_frontend
Length of output: 565
🏁 Script executed:
#!/bin/bash
# Look for asset widget loading/selection behavior
rg -n 'type === .asset.\|type: .asset.' src/ --type=ts -B 5 -A 10 | head -60
# Search for widget callback usage patterns
rg -n 'widget.callback' src/ --type=ts -B 3 -A 3 | head -50Repository: Comfy-Org/ComfyUI_frontend
Length of output: 3429
🏁 Script executed:
#!/bin/bash
# Search for remote widget which seems to handle asset-like loading
cat -n src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.ts | sed -n '1,50p'
# Check what type of widgets use callbacks in the Vue nodes
rg -n 'widget\.type' src/renderer/extensions/vueNodes/ --type=ts -B 2 -A 2 | head -40
# Look for asset-specific widget handling
rg -n 'asset' src/renderer/extensions/vueNodes/ --type=ts -B 3 -A 3Repository: Comfy-Org/ComfyUI_frontend
Length of output: 26224
🏁 Script executed:
#!/bin/bash
# Look at how asset widgets handle their callbacks in tests
rg -n 'asset.*widget\|widget.*asset' browser_tests/tests/ --type=ts -B 3 -A 3 | head -50
# Check if there are any tests for the asset widget dialog behavior
rg -n 'assetBrowserDialog\|onAssetSelected' src/renderer/extensions/vueNodes/ --type=ts -B 2 -A 2 | head -40Repository: Comfy-Org/ComfyUI_frontend
Length of output: 52
Asset widgets bypass the original callback intentionally—update the comment for clarity.
Asset widgets handle value updates through a dedicated interaction pattern (asset browser dialog selection), not the traditional callback mechanism. They still update the LiteGraph widget value and Vue state, so skipping the original callback prevents duplicate behavior from the dialog's onAssetSelected handler.
Refine the suggested comment to be more precise:
- // 2. Call the original callback if it exists
- // Skip for asset widgets to ensure proper value propagation via emit
+ // 2. Call the original callback if it exists
+ // Skip for asset widgets—they handle value updates via the asset browser dialog
if (originalCallback && widget.type !== 'asset') {
originalCallback.call(widget, value)
}🤖 Prompt for AI Agents
In src/composables/graph/useGraphNodeManager.ts around lines 370 to 372, the
current behavior skips calling the originalCallback for asset widgets but the
inline comment is unclear; replace or update the comment to explicitly state
that asset widgets handle value updates via the asset browser dialog (its
onAssetSelected handler), that the code still updates the LiteGraph widget value
and Vue state elsewhere, and that skipping originalCallback prevents duplicate
handling/side-effects from the dialog’s selection flow.
luke-mino-altherr
added
needs-backport
Models must be updated by emit. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7560-Fix-selecting-loras-on-cloud-2cb6d73d365081d48d3de032317bcb71) by [Unito](https://www.unito.io)
|
@AustinMroz Successfully backported to #7567 |
github-actions
bot
removed
the
needs-backport
Backport of #7560 to `cloud/1.35` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7567-backport-cloud-1-35-Fix-selecting-loras-on-cloud-2cb6d73d365081479a6fc918c7adf684) by [Unito](https://www.unito.io) Co-authored-by: AustinMroz <[email protected]>
Models must be updated by emit. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7560-Fix-selecting-loras-on-cloud-2cb6d73d365081d48d3de032317bcb71) by [Unito](https://www.unito.io)
Models must be updated by emit. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7560-Fix-selecting-loras-on-cloud-2cb6d73d365081d48d3de032317bcb71) by [Unito](https://www.unito.io)
Asset widgets resolve the list of models by checking the name of the node the widget is contained on. When an asset widget is linked to a subgraph node, a clone is made of the widget and then the clone is used to initialize an asset widget in vue mode. Since the widget no longer holds any form of reference to the original node, asset data fails to resolve. This is fixed by storing the original nodeType as an option on the cloned widget when an asset widget is linked to a subgraph input. | Before | After | | ------ | ----- | | <img width="360" alt="before" src="https://github.com/user-attachments/assets/345f9cc1-da04-44ab-8fed-76379c8528de"/> | <img width="360" alt="after" src="https://github.com/user-attachments/assets/88d1ddaa-56fb-41b3-8d5d-0ded02aaa7d2" />| See also #7563, #7560 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7895-Fix-linked-asset-widget-promotion-in-vue-2e26d73d365081e5b295f6236458b978) by [Unito](https://www.unito.io)
Models must be updated by emit.
┆Issue is synchronized with this Notion page by Unito